[GitHub] [dubbo-go-samples] zouyx commented on a change in pull request #243: add dubbogo tracing sample

[GitBox <gi...@apache.org>]

zouyx commented on a change in pull request #243:
URL: https://github.com/apache/dubbo-go-samples/pull/243#discussion_r706972467



##########
File path: tracing/dubbo/go-client/cmd/client.go
##########
@@ -20,66 +20,48 @@ package main
 import (
 	"context"
 	"fmt"
+	"github.com/opentracing/opentracing-go"

Review comment:
       format this import

##########
File path: tracing/dubbo/go-server/cmd/server.go
##########
@@ -19,31 +19,23 @@ package main
 
 import (
 	"fmt"
+	"github.com/opentracing/opentracing-go"

Review comment:
       as above

##########
File path: tracing/dubbo/go-server/pkg/user.go
##########
@@ -19,49 +19,43 @@ package pkg
 
 import (
 	"context"
+	"fmt"
+	gxlog "github.com/dubbogo/gost/log"

Review comment:
       > 我reformat代码后，没啥变化，这个是哪里不合格式规范吗？
   
   refer this rule : https://github.com/apache/dubbo-go/blob/master/CONTRIBUTING.md#34-import




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org