You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Steven Rowe (Created) (JIRA)" <ji...@apache.org> on 2012/04/05 22:26:25 UTC

[jira] [Created] (LUCENE-3959) Remove @author tags in Lucene/Solr sources

Remove @author tags in Lucene/Solr sources
------------------------------------------

                 Key: LUCENE-3959
                 URL: https://issues.apache.org/jira/browse/LUCENE-3959
             Project: Lucene - Java
          Issue Type: Improvement
          Components: general/javadocs
    Affects Versions: 4.0
            Reporter: Steven Rowe
            Priority: Trivial


Lucene/Solr sources should not include {{@author}} tags.  See the [solr-dev@l.a.o|http://lucene.markmail.org/thread/bbcbnfdssi3ir5sg] and [java-dev@l.a.o|http://lucene.markmail.org/thread/g6meuxgs34goy373] threads in which this was discussed. 

The Jenkins builds should fail if they are found, in the same way that {{nocommit}}'s are currently handled


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3959) Remove @author tags in Lucene/Solr sources

Posted by "Chris Male (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249050#comment-13249050 ] 

Chris Male commented on LUCENE-3959:
------------------------------------

Hey Steve,

Your @author tag check is now causing the 3x build to break (which demonstrates it works!).  Are you able to backport the @author removals?
                
> Remove @author tags in Lucene/Solr sources
> ------------------------------------------
>
>                 Key: LUCENE-3959
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3959
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: general/javadocs
>    Affects Versions: 4.0
>            Reporter: Steven Rowe
>            Assignee: Steven Rowe
>            Priority: Trivial
>             Fix For: 4.0
>
>         Attachments: LUCENE-3959.patch
>
>
> Lucene/Solr sources should not include {{@author}} tags.  See the [solr-dev@l.a.o|http://lucene.markmail.org/thread/bbcbnfdssi3ir5sg] and [java-dev@l.a.o|http://lucene.markmail.org/thread/g6meuxgs34goy373] threads in which this was discussed. 
> The Jenkins builds should fail if they are found, in the same way that {{nocommit}}'s are currently handled

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Resolved] (LUCENE-3959) Remove @author tags in Lucene/Solr sources

Posted by "Steven Rowe (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-3959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steven Rowe resolved LUCENE-3959.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 4.0
         Assignee: Steven Rowe
    Lucene Fields: New,Patch Available  (was: New)

Committed to trunk.

Modified {{dev/nightly/hudson-settings.sh}} to check for @author tags right after checking for no(n)commits in .java files.
                
> Remove @author tags in Lucene/Solr sources
> ------------------------------------------
>
>                 Key: LUCENE-3959
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3959
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: general/javadocs
>    Affects Versions: 4.0
>            Reporter: Steven Rowe
>            Assignee: Steven Rowe
>            Priority: Trivial
>             Fix For: 4.0
>
>         Attachments: LUCENE-3959.patch
>
>
> Lucene/Solr sources should not include {{@author}} tags.  See the [solr-dev@l.a.o|http://lucene.markmail.org/thread/bbcbnfdssi3ir5sg] and [java-dev@l.a.o|http://lucene.markmail.org/thread/g6meuxgs34goy373] threads in which this was discussed. 
> The Jenkins builds should fail if they are found, in the same way that {{nocommit}}'s are currently handled

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3959) Remove @author tags in Lucene/Solr sources

Posted by "Steven Rowe (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249110#comment-13249110 ] 

Steven Rowe commented on LUCENE-3959:
-------------------------------------

bq. I don't know how to disable these 3.x tasks in jenkins completely or i would.

I think you got it - thanks!

bq. so I think its ok to disable the 3.x tasks and dedicate them towards trunk?

+1
                
> Remove @author tags in Lucene/Solr sources
> ------------------------------------------
>
>                 Key: LUCENE-3959
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3959
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: general/javadocs
>    Affects Versions: 4.0
>            Reporter: Steven Rowe
>            Assignee: Steven Rowe
>            Priority: Trivial
>             Fix For: 4.0
>
>         Attachments: LUCENE-3959.patch
>
>
> Lucene/Solr sources should not include {{@author}} tags.  See the [solr-dev@l.a.o|http://lucene.markmail.org/thread/bbcbnfdssi3ir5sg] and [java-dev@l.a.o|http://lucene.markmail.org/thread/g6meuxgs34goy373] threads in which this was discussed. 
> The Jenkins builds should fail if they are found, in the same way that {{nocommit}}'s are currently handled

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3959) Remove @author tags in Lucene/Solr sources

Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249055#comment-13249055 ] 

Robert Muir commented on LUCENE-3959:
-------------------------------------

I don't know how to disable these 3.x tasks in jenkins completely or i would.

my hudson: http://sierranevada.servebeer.com/ is still running for 3.x and i will disable when 3.6
is released. 

so I think its ok to disable the 3.x tasks and dedicate them towards trunk?
                
> Remove @author tags in Lucene/Solr sources
> ------------------------------------------
>
>                 Key: LUCENE-3959
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3959
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: general/javadocs
>    Affects Versions: 4.0
>            Reporter: Steven Rowe
>            Assignee: Steven Rowe
>            Priority: Trivial
>             Fix For: 4.0
>
>         Attachments: LUCENE-3959.patch
>
>
> Lucene/Solr sources should not include {{@author}} tags.  See the [solr-dev@l.a.o|http://lucene.markmail.org/thread/bbcbnfdssi3ir5sg] and [java-dev@l.a.o|http://lucene.markmail.org/thread/g6meuxgs34goy373] threads in which this was discussed. 
> The Jenkins builds should fail if they are found, in the same way that {{nocommit}}'s are currently handled

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3959) Remove @author tags in Lucene/Solr sources

Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249049#comment-13249049 ] 

Robert Muir commented on LUCENE-3959:
-------------------------------------

This broke the 3.x hudson task. We should either disable this check for 3.x, or disable the 3.x hudson <-- best!
                
> Remove @author tags in Lucene/Solr sources
> ------------------------------------------
>
>                 Key: LUCENE-3959
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3959
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: general/javadocs
>    Affects Versions: 4.0
>            Reporter: Steven Rowe
>            Assignee: Steven Rowe
>            Priority: Trivial
>             Fix For: 4.0
>
>         Attachments: LUCENE-3959.patch
>
>
> Lucene/Solr sources should not include {{@author}} tags.  See the [solr-dev@l.a.o|http://lucene.markmail.org/thread/bbcbnfdssi3ir5sg] and [java-dev@l.a.o|http://lucene.markmail.org/thread/g6meuxgs34goy373] threads in which this was discussed. 
> The Jenkins builds should fail if they are found, in the same way that {{nocommit}}'s are currently handled

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (LUCENE-3959) Remove @author tags in Lucene/Solr sources

Posted by "Steven Rowe (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-3959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steven Rowe updated LUCENE-3959:
--------------------------------

    Attachment: LUCENE-3959.patch

Patch removing all {{@author}} tags from Lucene/Solr sources.
                
> Remove @author tags in Lucene/Solr sources
> ------------------------------------------
>
>                 Key: LUCENE-3959
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3959
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: general/javadocs
>    Affects Versions: 4.0
>            Reporter: Steven Rowe
>            Priority: Trivial
>         Attachments: LUCENE-3959.patch
>
>
> Lucene/Solr sources should not include {{@author}} tags.  See the [solr-dev@l.a.o|http://lucene.markmail.org/thread/bbcbnfdssi3ir5sg] and [java-dev@l.a.o|http://lucene.markmail.org/thread/g6meuxgs34goy373] threads in which this was discussed. 
> The Jenkins builds should fail if they are found, in the same way that {{nocommit}}'s are currently handled

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3959) Remove @author tags in Lucene/Solr sources

Posted by "Chris Male (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247813#comment-13247813 ] 

Chris Male commented on LUCENE-3959:
------------------------------------

+1

Matches the list of files I can find.
                
> Remove @author tags in Lucene/Solr sources
> ------------------------------------------
>
>                 Key: LUCENE-3959
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3959
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: general/javadocs
>    Affects Versions: 4.0
>            Reporter: Steven Rowe
>            Priority: Trivial
>         Attachments: LUCENE-3959.patch
>
>
> Lucene/Solr sources should not include {{@author}} tags.  See the [solr-dev@l.a.o|http://lucene.markmail.org/thread/bbcbnfdssi3ir5sg] and [java-dev@l.a.o|http://lucene.markmail.org/thread/g6meuxgs34goy373] threads in which this was discussed. 
> The Jenkins builds should fail if they are found, in the same way that {{nocommit}}'s are currently handled

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3959) Remove @author tags in Lucene/Solr sources

Posted by "Chris Male (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249051#comment-13249051 ] 

Chris Male commented on LUCENE-3959:
------------------------------------

Ha, beat me too it Robert.
                
> Remove @author tags in Lucene/Solr sources
> ------------------------------------------
>
>                 Key: LUCENE-3959
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3959
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: general/javadocs
>    Affects Versions: 4.0
>            Reporter: Steven Rowe
>            Assignee: Steven Rowe
>            Priority: Trivial
>             Fix For: 4.0
>
>         Attachments: LUCENE-3959.patch
>
>
> Lucene/Solr sources should not include {{@author}} tags.  See the [solr-dev@l.a.o|http://lucene.markmail.org/thread/bbcbnfdssi3ir5sg] and [java-dev@l.a.o|http://lucene.markmail.org/thread/g6meuxgs34goy373] threads in which this was discussed. 
> The Jenkins builds should fail if they are found, in the same way that {{nocommit}}'s are currently handled

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3959) Remove @author tags in Lucene/Solr sources

Posted by "Steven Rowe (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13248938#comment-13248938 ] 

Steven Rowe commented on LUCENE-3959:
-------------------------------------

Hossman's Solr commit removing @author tags in July 2007: http://svn.apache.org/viewvc?view=revision&revision=555343
                
> Remove @author tags in Lucene/Solr sources
> ------------------------------------------
>
>                 Key: LUCENE-3959
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3959
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: general/javadocs
>    Affects Versions: 4.0
>            Reporter: Steven Rowe
>            Priority: Trivial
>         Attachments: LUCENE-3959.patch
>
>
> Lucene/Solr sources should not include {{@author}} tags.  See the [solr-dev@l.a.o|http://lucene.markmail.org/thread/bbcbnfdssi3ir5sg] and [java-dev@l.a.o|http://lucene.markmail.org/thread/g6meuxgs34goy373] threads in which this was discussed. 
> The Jenkins builds should fail if they are found, in the same way that {{nocommit}}'s are currently handled

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (LUCENE-3959) Remove @author tags in Lucene/Solr sources

Posted by "Chris Male (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-3959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Male updated LUCENE-3959:
-------------------------------

    Comment: was deleted

(was: Ha, beat me too it Robert.)
    
> Remove @author tags in Lucene/Solr sources
> ------------------------------------------
>
>                 Key: LUCENE-3959
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3959
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: general/javadocs
>    Affects Versions: 4.0
>            Reporter: Steven Rowe
>            Assignee: Steven Rowe
>            Priority: Trivial
>             Fix For: 4.0
>
>         Attachments: LUCENE-3959.patch
>
>
> Lucene/Solr sources should not include {{@author}} tags.  See the [solr-dev@l.a.o|http://lucene.markmail.org/thread/bbcbnfdssi3ir5sg] and [java-dev@l.a.o|http://lucene.markmail.org/thread/g6meuxgs34goy373] threads in which this was discussed. 
> The Jenkins builds should fail if they are found, in the same way that {{nocommit}}'s are currently handled

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (LUCENE-3959) Remove @author tags in Lucene/Solr sources

Posted by "Chris Male (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-3959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Male updated LUCENE-3959:
-------------------------------

    Comment: was deleted

(was: Hey Steve,

Your @author tag check is now causing the 3x build to break (which demonstrates it works!).  Are you able to backport the @author removals?)
    
> Remove @author tags in Lucene/Solr sources
> ------------------------------------------
>
>                 Key: LUCENE-3959
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3959
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: general/javadocs
>    Affects Versions: 4.0
>            Reporter: Steven Rowe
>            Assignee: Steven Rowe
>            Priority: Trivial
>             Fix For: 4.0
>
>         Attachments: LUCENE-3959.patch
>
>
> Lucene/Solr sources should not include {{@author}} tags.  See the [solr-dev@l.a.o|http://lucene.markmail.org/thread/bbcbnfdssi3ir5sg] and [java-dev@l.a.o|http://lucene.markmail.org/thread/g6meuxgs34goy373] threads in which this was discussed. 
> The Jenkins builds should fail if they are found, in the same way that {{nocommit}}'s are currently handled

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org