You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@accumulo.apache.org by dl...@apache.org on 2023/02/06 16:26:33 UTC

[accumulo] branch 2.1 updated: Switch log level to trace in SystemPropUtil (#3184)

This is an automated email from the ASF dual-hosted git repository.

dlmarion pushed a commit to branch 2.1
in repository https://gitbox.apache.org/repos/asf/accumulo.git


The following commit(s) were added to refs/heads/2.1 by this push:
     new efc882a8c5 Switch log level to trace in SystemPropUtil (#3184)
efc882a8c5 is described below

commit efc882a8c52e5f593b2245c2143e14a10c9f0796
Author: Daniel Roberts <dd...@gmail.com>
AuthorDate: Mon Feb 6 11:26:27 2023 -0500

    Switch log level to trace in SystemPropUtil (#3184)
    
    The exceptions thrown here are already logged at the error level via the
    calling method `modifySystemProperties` from the
    `ManagerClientServiceHandler` class. Writing these exceptions at
     the error level would result in duplicate exception messages in the logs.
---
 .../main/java/org/apache/accumulo/server/util/SystemPropUtil.java   | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/server/base/src/main/java/org/apache/accumulo/server/util/SystemPropUtil.java b/server/base/src/main/java/org/apache/accumulo/server/util/SystemPropUtil.java
index 46e37992cd..219a6cee03 100644
--- a/server/base/src/main/java/org/apache/accumulo/server/util/SystemPropUtil.java
+++ b/server/base/src/main/java/org/apache/accumulo/server/util/SystemPropUtil.java
@@ -76,13 +76,13 @@ public class SystemPropUtil {
     if (!Property.isValidZooPropertyKey(property)) {
       IllegalArgumentException iae =
           new IllegalArgumentException("Zookeeper property is not mutable: " + property);
-      log.error("Encountered error setting zookeeper property", iae);
+      log.trace("Encountered error setting zookeeper property", iae);
       throw iae;
     }
     if (!Property.isValidProperty(property, value)) {
       IllegalArgumentException iae = new IllegalArgumentException(
           "Property " + property + " with value: " + value + " is not valid");
-      log.error("Encountered error setting zookeeper property", iae);
+      log.trace("Encountered error setting zookeeper property", iae);
       throw iae;
     }
 
@@ -100,7 +100,7 @@ public class SystemPropUtil {
         && !foundProp.getType().isValidFormat(value)))) {
       IllegalArgumentException iae = new IllegalArgumentException(
           "Ignoring property " + property + " it is either null or in an invalid format");
-      log.error("Attempted to set zookeeper property.  Value is either null or invalid", iae);
+      log.trace("Attempted to set zookeeper property.  Value is either null or invalid", iae);
       throw iae;
     }