[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14365: Fix memory leak for size-zero ndarray

[GitBox <gi...@apache.org>]

apeforest commented on a change in pull request #14365: Fix memory leak for size-zero ndarray
URL: https://github.com/apache/incubator-mxnet/pull/14365#discussion_r264964367
 
 

 ##########
 File path: include/mxnet/ndarray.h
 ##########
 @@ -1055,9 +1054,12 @@ class NDArray {
       }
       size_t aux_bytes = shape.Size() * mshadow::mshadow_sizeof(aux_types[i]);
       if (aux_handles[i].size < aux_bytes) {
-        // free storage if necessary and alloc again
-        if (aux_handles[i].size > 0) Storage::Get()->Free(aux_handles[i]);
-        // init aux storage
+        // set the context for aux handle to make sure we free it to the right device.
+        if (aux_handles[i].ctx.dev_type != ctx.dev_type) {
 
 Review comment:
   Is this related to memory leak? Why added here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services