[GitHub] [iceberg] rdblue commented on a diff in pull request #6450: Core: Key metadata in Avro format

["rdblue (via GitHub)" <gi...@apache.org>]

rdblue commented on code in PR #6450:
URL: https://github.com/apache/iceberg/pull/6450#discussion_r1186914840


##########
core/src/main/java/org/apache/iceberg/data/avro/IcebergDecoder.java:
##########
@@ -106,7 +100,10 @@ public void addSchema(org.apache.iceberg.Schema writeSchema) {
 
   private void addSchema(Schema writeSchema) {
     long fp = SchemaNormalization.parsingFingerprint64(writeSchema);
-    decoders.put(fp, new RawDecoder<>(readSchema, writeSchema));
+    decoders.put(
+        fp,
+        new RawDecoder<>(
+            readSchema, avroSchema -> DataReader.create(readSchema, avroSchema), writeSchema));

Review Comment:
   The formatting is awkward because there is too much on one line. Can you clean this up a little by moving the lambda or creating the decoder separately?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org