You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/02/19 10:49:44 UTC
[GitHub] [cloudstack] Pearl1594 opened a new pull request #4712: marvin: Bypass tests on Simulator
Pearl1594 opened a new pull request #4712:
URL: https://github.com/apache/cloudstack/pull/4712
### Description
This PR attempts to fix travis failures observed post merge of #4503. Checks have been added to skip specific tests for Simulator based envs.
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [X] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [X] Minor
- [ ] Trivial
### How Has This Been Tested?
Test on Simulator env:
```
nosetests --with-xunit --xunit-file=results.xml --with-marvin --marvin-config=setup/dev/advanced.cfg -s -a tags=xx --hypervisor=Simulator test/integration/smoke/test_network.py
==== Marvin Init Started ====
=== Marvin Parse Config Successful ===
=== Marvin Setting TestData Successful===
==== Log Folder Path: /tmp/MarvinLogs/Feb_19_2021_16_14_35_UZ1YA0. All logs will be available here ====
=== Marvin Init Logging Successful===
==== Marvin Init Successful ====
===final results are now copied to: /tmp/MarvinLogs/test_suite_1PU3PO===
```
Tests on KVM:
```
nosetests --with-xunit --xunit-file=results.xml --with-marvin --marvin-config=/marvin/ref-trl-2413-k-M7-david-jumani-advanced-cfg -s -a tags=xx --hypervisor=kvm test_net.py
==== Marvin Init Started ====
=== Marvin Parse Config Successful ===
=== Marvin Setting TestData Successful===
==== Log Folder Path: /marvin/MarvinLogs/Feb_19_2021_10_03_02_TAWBVC. All logs will be available here ====
=== Marvin Init Logging Successful===
==== Marvin Init Successful ====
Executing command '{'endip': '172.16.134.21', 'acltype': 'domain', 'routerip': '172.16.134.15', 'name': 'MySharedNetwork - Test', 'networkofferingid': u'59739a6f-d682-410c-901c-aa3a62e4e551', 'physicalnetworkid': u'f8f4c4cd-ae62-4f19-b789-b4144b97aa60', 'startip': '172.16.134.2', 'vlan': 3133, 'netmask': '255.255.255.0', 'displaytext': 'MySharedNetwork', 'scope': 'all', 'gateway': '172.16.134.1'}'
Executing command 'ip addr show eth0 |grep "inet "|cut -d " " -f6 |cut -d "/" -f1 |grep -w 172.16.134.15'
====Trying SSH Connection: Host:10.10.4.136 User:root Port:22 RetryCnt:60===
===SSH to Host 10.10.4.136 port : 22 SUCCESSFUL===
{Cmd: ssh -i ~/.ssh/id_rsa.cloud -ostricthostkeychecking=no -oUserKnownHostsFile=/dev/null -p 3922 169.254.133.68 ip addr show eth0 |grep "inet "|cut -d " " -f6 |cut -d "/" -f1 |grep -w 172.16.134.15 via Host: 10.10.4.136} {returns: [u'172.16.134.15']}
=== TestName: test_01_deployVMInSharedNetwork | Status : SUCCESS ===
Executing command 'ip addr show eth0 |grep "inet "|cut -d " " -f6 |cut -d "/" -f1 |grep -w 172.16.134.15'
====Trying SSH Connection: Host:10.10.3.147 User:root Port:22 RetryCnt:60===
====Trying SSH Connection: Host:10.10.3.147 User:root Port:22 RetryCnt:60===
===SSH to Host 10.10.3.147 port : 22 SUCCESSFUL===
===SSH to Host 10.10.3.147 port : 22 SUCCESSFUL===
{Cmd: ssh -i ~/.ssh/id_rsa.cloud -ostricthostkeychecking=no -oUserKnownHostsFile=/dev/null -p 3922 169.254.76.134 ip addr show eth0 |grep "inet "|cut -d " " -f6 |cut -d "/" -f1 |grep -w 172.16.134.15 via Host: 10.10.3.147} {returns: [u'172.16.134.15']}
{Cmd: ssh -i ~/.ssh/id_rsa.cloud -ostricthostkeychecking=no -oUserKnownHostsFile=/dev/null -p 3922 169.254.76.134 ip addr show eth0 |grep "inet "|cut -d " " -f6 |cut -d "/" -f1 |grep -w 172.16.134.15 via Host: 10.10.3.147} {returns: [u'172.16.134.15']}
=== TestName: test_02_verifyRouterIpAfterNetworkRestart | Status : SUCCESS ===
=== TestName: test_03_destroySharedNetwork | Status : SUCCESS ===
===final results are now copied to: /marvin//MarvinLogs//RNR1NY===
```
Tests run on VMware:
```
nosetests-2.7 --with-xunit --xunit-file=results.xml --with-marvin --marvin-config=/marvin/pr4577-t3581-vmware-67u3-advanced-cfg -s -a tags=xx --hypervisor=vmware test.py
==== Marvin Init Started ====
=== Marvin Parse Config Successful ===
=== Marvin Setting TestData Successful===
==== Log Folder Path: /marvin/MarvinLogs/Feb_19_2021_10_36_43_SQ3YFY. All logs will be available here ====
=== Marvin Init Logging Successful===
==== Marvin Init Successful ====
Executing command '{'endip': '172.16.128.21', 'acltype': 'domain', 'routerip': '172.16.128.15', 'name': 'MySharedNetwork - Test', 'networkofferingid': u'a3f03129-3c17-41b0-a5a7-240c0ceb6a4c', 'physicalnetworkid': u'ee587cf1-dcce-41eb-be18-6f42e78645c3', 'startip': '172.16.128.2', 'vlan': 723, 'netmask': '255.255.255.0', 'displaytext': 'MySharedNetwork', 'scope': 'all', 'gateway': '172.16.128.1'}'
172.16.128.15
Executing command 'ip addr show eth0 |grep "inet "|cut -d " " -f6 |cut -d "/" -f1 |grep -w 172.16.128.15'
====Trying SSH Connection: Host:10.10.4.172 User:root Port:22 RetryCnt:60===
===SSH to Host 10.10.4.172 port : 22 SUCCESSFUL===
{Cmd: ssh -i /var/cloudstack/management/.ssh/id_rsa -ostricthostkeychecking=no -oUserKnownHostsFile=/dev/null -p 3922 10.10.5.128 ip addr show eth0 |grep "inet "|cut -d " " -f6 |cut -d "/" -f1 |grep -w 172.16.128.15 via Host: 10.10.4.172} {returns: [u'172.16.128.15']}
=== TestName: test_01_deployVMInSharedNetwork | Status : SUCCESS ===
Executing command 'ip addr show eth0 |grep "inet "|cut -d " " -f6 |cut -d "/" -f1 |grep -w 172.16.128.15'
====Trying SSH Connection: Host:10.10.4.172 User:root Port:22 RetryCnt:60===
====Trying SSH Connection: Host:10.10.4.172 User:root Port:22 RetryCnt:60===
===SSH to Host 10.10.4.172 port : 22 SUCCESSFUL===
===SSH to Host 10.10.4.172 port : 22 SUCCESSFUL===
{Cmd: ssh -i /var/cloudstack/management/.ssh/id_rsa -ostricthostkeychecking=no -oUserKnownHostsFile=/dev/null -p 3922 10.10.5.126 ip addr show eth0 |grep "inet "|cut -d " " -f6 |cut -d "/" -f1 |grep -w 172.16.128.15 via Host: 10.10.4.172} {returns: [u'172.16.128.15']}
{Cmd: ssh -i /var/cloudstack/management/.ssh/id_rsa -ostricthostkeychecking=no -oUserKnownHostsFile=/dev/null -p 3922 10.10.5.126 ip addr show eth0 |grep "inet "|cut -d " " -f6 |cut -d "/" -f1 |grep -w 172.16.128.15 via Host: 10.10.4.172} {returns: [u'172.16.128.15']}
=== TestName: test_02_verifyRouterIpAfterNetworkRestart | Status : SUCCESS ===
=== TestName: test_03_destroySharedNetwork | Status : SUCCESS ===
===final results are now copied to: /marvin//MarvinLogs//O1X7IT===
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4712: marvin: Bypass tests on Simulator
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4712:
URL: https://github.com/apache/cloudstack/pull/4712
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4712: marvin: Bypass tests on Simulator
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4712:
URL: https://github.com/apache/cloudstack/pull/4712#issuecomment-782083280
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2768
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4712: marvin: Bypass tests on Simulator
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4712:
URL: https://github.com/apache/cloudstack/pull/4712#issuecomment-781997087
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #4712: marvin: Bypass tests on Simulator
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on a change in pull request #4712:
URL: https://github.com/apache/cloudstack/pull/4712#discussion_r579168297
##########
File path: test/integration/smoke/test_network.py
##########
@@ -2018,12 +2024,14 @@ def test_02_verifyRouterIpAfterNetworkRestart(self):
@attr(tags=["advanced", "shared"])
def test_03_destroySharedNetwork(self):
+ if self.hv.lower() == 'simulator':
+ self.skipTest("Hypervisor is simulator - skipping Test..")
routerIp = self.services["shared_network"]["routerip"]
try:
self.shared_network.delete(self.apiclient)
except Exception as e:
self.fail("Failed to destroy the shared network")
-
+ self._cleanup.remove(self.shared_network)
Review comment:
The intention of removing the shared network from the cleanup list is that, if the deletion of the n/w happens as part of the test, then it need not be cleaned up during the teardown phase, else, if for any reason this test fails or is skipped, the network will be deleted during teardown
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4712: marvin: Bypass tests on Simulator
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4712:
URL: https://github.com/apache/cloudstack/pull/4712#issuecomment-781997474
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4712: marvin: Bypass tests on Simulator
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #4712:
URL: https://github.com/apache/cloudstack/pull/4712#discussion_r579156786
##########
File path: test/integration/smoke/test_network.py
##########
@@ -2018,12 +2024,14 @@ def test_02_verifyRouterIpAfterNetworkRestart(self):
@attr(tags=["advanced", "shared"])
def test_03_destroySharedNetwork(self):
+ if self.hv.lower() == 'simulator':
+ self.skipTest("Hypervisor is simulator - skipping Test..")
routerIp = self.services["shared_network"]["routerip"]
try:
self.shared_network.delete(self.apiclient)
except Exception as e:
self.fail("Failed to destroy the shared network")
-
+ self._cleanup.remove(self.shared_network)
Review comment:
this should be done in the teardown method,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org