Re: svn commit: r882103 [1/2] - in /ofbiz/trunk: ./ applications/accounting/ applications/accounting/config/ applications/accounting/data/ applications/accounting/entitydef/ applications/accounting/script/org/ofbiz/accounting/payment/ applications/accounti

[Jacques Le Roux <ja...@les7arts.com>]

Thanks to care Scott,

I did not notice that and simply trusted Abdullah, who did a good work for his 1st patch BTW...

Jacques

From: "Scott Gray" <sc...@hotwaxmedia.com>
> Okay never mind, it seems that it is required: https://issues.apache.org/jira/browse/HTTPCLIENT-866
> 
> Regards
> Scott
> 
> On 20/11/2009, at 12:18 AM, Scott Gray wrote:
> 
>> Reference: http://www.mail-archive.com/dev@commons.apache.org/msg08913.html
>>
>> On 20/11/2009, at 12:15 AM, Scott Gray wrote:
>>
>>> Does httpclient actually depend on jcip-annotations?  My  
>>> understanding is that jcip-annotations is a compile time tool and  
>>> if we're not using the annotations that it provides in our source  
>>> code then we shouldn't need it.
>>>
>>> Regards
>>> Scott
>>>
>>> HotWax Media
>>> http://www.hotwaxmedia.com
>>>
>>> On 20/11/2009, at 12:02 AM, jleroux@apache.org wrote:
>>>
>>>> Author: jleroux
>>>> Date: Thu Nov 19 11:01:29 2009
>>>> New Revision: 882103
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=882103&view=rev
>>>> Log:
>>>> A patch from Abdullah Shaikh "SagePay payment gateway integrated" (https://issues.apache.org/jira/browse/OFBIZ-3180 
>>>> ) - OFBIZ-3180
>>>> SagePay payment gateway integrated. All the gateway parameters are  
>>>> configurable using the Payment gateway configuration, also the  
>>>> transaction types that are available in sagepay are configurable.
>>>>
>>>> I moved the httpclient httpcore jars to base/lib (also new jcip- 
>>>> annotations-1.0.jar)
>>>>
>>>> Added:
>>>>  ofbiz/trunk/applications/accounting/servicedef/ 
>>>> services_sagepay.xml   (with props)
>>>>  ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/ 
>>>> thirdparty/sagepay/
>>>>  ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/ 
>>>> thirdparty/sagepay/SagePayPaymentServices.java   (with props)
>>>>  ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/ 
>>>> thirdparty/sagepay/SagePayServices.java   (with props)
>>>>  ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/ 
>>>> thirdparty/sagepay/SagePayUtil.java   (with props)
>>>>  ofbiz/trunk/framework/base/lib/httpclient-4.0.jar   (with props)
>>>>  ofbiz/trunk/framework/base/lib/httpcore-4.0.1.jar   (with props)
>>>>  ofbiz/trunk/framework/base/lib/jcip-annotations-1.0.jar   (with  
>>>> props)
>>>> Removed:
>>>>  ofbiz/trunk/framework/testtools/lib/httpclient-4.0-beta1.jar
>>>>  ofbiz/trunk/framework/testtools/lib/httpcore-4.0-beta2.jar
>>>> Modified:
>>>>  ofbiz/trunk/.classpath
>>>>  ofbiz/trunk/applications/accounting/config/AccountingUiLabels.xml
>>>>  ofbiz/trunk/applications/accounting/data/AccountingTypeData.xml
>>>>  ofbiz/trunk/applications/accounting/entitydef/entitymodel.xml
>>>>  ofbiz/trunk/applications/accounting/ofbiz-component.xml
>>>>  ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ 
>>>> payment/PaymentGatewayConfigServices.xml
>>>>  ofbiz/trunk/applications/accounting/servicedef/ 
>>>> services_paymentgateway.xml
>>>>  ofbiz/trunk/applications/accounting/webapp/accounting/WEB-INF/ 
>>>> controller.xml
>>>>  ofbiz/trunk/applications/accounting/widget/ 
>>>> PaymentGatewayConfigForms.xml
>>>>  ofbiz/trunk/applications/accounting/widget/ 
>>>> PaymentGatewayConfigScreens.xml
>>>>
>>>
>>
> 
>