You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Cedric Nanni (Created) (JIRA)" <ji...@apache.org> on 2011/10/25 21:08:32 UTC

[jira] [Created] (VFS-369) Comppilation Issue

Comppilation Issue
------------------

                 Key: VFS-369
                 URL: https://issues.apache.org/jira/browse/VFS-369
             Project: Commons VFS
          Issue Type: Bug
    Affects Versions: 2.0
            Reporter: Cedric Nanni


When I try to compile VFS on my computer I've got compilation errors due maybe because I use a more recent version of jackrabbit. I patched the code and now it compiles.

diff -rupN original//org/apache/commons/vfs2/provider/webdav/ExceptionConverter.java patched//org/apache/commons/vfs2/provider/webdav/ExceptionConverter.java
--- original//org/apache/commons/vfs2/provider/webdav/ExceptionConverter.java	2011-08-18 06:57:10.000000000 +0200
+++ patched//org/apache/commons/vfs2/provider/webdav/ExceptionConverter.java	2011-10-24 20:35:41.000000000 +0200
@@ -50,7 +50,7 @@ public final class ExceptionConverter
         {
             try
             {
-                Element error = davExc.toXml(DomUtil.BUILDER_FACTORY.newDocumentBuilder().newDocument());
+                Element error = davExc.toXml(DomUtil.createDocument());
                 if (DomUtil.matches(error, DavException.XML_ERROR, DavConstants.NAMESPACE))
                 {
                     if (DomUtil.hasChildElement(error, "exception", null))
diff -rupN original//org/apache/commons/vfs2/provider/webdav/WebdavFileObject.java patched//org/apache/commons/vfs2/provider/webdav/WebdavFileObject.java
--- original//org/apache/commons/vfs2/provider/webdav/WebdavFileObject.java	2011-08-18 06:57:10.000000000 +0200
+++ patched//org/apache/commons/vfs2/provider/webdav/WebdavFileObject.java	2011-10-24 20:35:41.000000000 +0200
@@ -292,19 +292,17 @@ public class WebdavFileObject extends Ht
             URLFileName fileName = (URLFileName) getName();
             DavPropertySet properties = getProperties(fileName, PropFindMethod.PROPFIND_ALL_PROP,
                     new DavPropertyNameSet(), false);
-            @SuppressWarnings("unchecked") // iterator() is documented to return DavProperty instances
-            Iterator<DavProperty> iter = properties.iterator();
+            Iterator iter = properties.iterator();
             while (iter.hasNext())
             {
-                DavProperty property = iter.next();
+                DavProperty property = (DavProperty)iter.next();
                 attributes.put(property.getName().toString(), property.getValue());
             }
             properties = getPropertyNames(fileName);
-            @SuppressWarnings("unchecked") // iterator() is documented to return DavProperty instances
-            Iterator<DavProperty> iter2 = properties.iterator();
+            Iterator iter2 = properties.iterator();
             while (iter2.hasNext())
             {
-                DavProperty property = iter2.next();
+                DavProperty property = (DavProperty)iter2.next();
                 if (!attributes.containsKey(property.getName().getName()))
                 {
                     property = getProperty(fileName, property.getName());



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (VFS-369) Comppilation Issue

Posted by "Cedric Nanni (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/VFS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Cedric Nanni updated VFS-369:
-----------------------------

    Attachment: VFS-369.patch
    
> Comppilation Issue
> ------------------
>
>                 Key: VFS-369
>                 URL: https://issues.apache.org/jira/browse/VFS-369
>             Project: Commons VFS
>          Issue Type: Bug
>    Affects Versions: 2.0
>            Reporter: Cedric Nanni
>         Attachments: VFS-369.patch
>
>
> When I try to compile VFS on my computer I've got compilation errors due maybe because I use a more recent version of jackrabbit. I patched the code and now it compiles.
> diff -rupN original//org/apache/commons/vfs2/provider/webdav/ExceptionConverter.java patched//org/apache/commons/vfs2/provider/webdav/ExceptionConverter.java
> --- original//org/apache/commons/vfs2/provider/webdav/ExceptionConverter.java	2011-08-18 06:57:10.000000000 +0200
> +++ patched//org/apache/commons/vfs2/provider/webdav/ExceptionConverter.java	2011-10-24 20:35:41.000000000 +0200
> @@ -50,7 +50,7 @@ public final class ExceptionConverter
>          {
>              try
>              {
> -                Element error = davExc.toXml(DomUtil.BUILDER_FACTORY.newDocumentBuilder().newDocument());
> +                Element error = davExc.toXml(DomUtil.createDocument());
>                  if (DomUtil.matches(error, DavException.XML_ERROR, DavConstants.NAMESPACE))
>                  {
>                      if (DomUtil.hasChildElement(error, "exception", null))
> diff -rupN original//org/apache/commons/vfs2/provider/webdav/WebdavFileObject.java patched//org/apache/commons/vfs2/provider/webdav/WebdavFileObject.java
> --- original//org/apache/commons/vfs2/provider/webdav/WebdavFileObject.java	2011-08-18 06:57:10.000000000 +0200
> +++ patched//org/apache/commons/vfs2/provider/webdav/WebdavFileObject.java	2011-10-24 20:35:41.000000000 +0200
> @@ -292,19 +292,17 @@ public class WebdavFileObject extends Ht
>              URLFileName fileName = (URLFileName) getName();
>              DavPropertySet properties = getProperties(fileName, PropFindMethod.PROPFIND_ALL_PROP,
>                      new DavPropertyNameSet(), false);
> -            @SuppressWarnings("unchecked") // iterator() is documented to return DavProperty instances
> -            Iterator<DavProperty> iter = properties.iterator();
> +            Iterator iter = properties.iterator();
>              while (iter.hasNext())
>              {
> -                DavProperty property = iter.next();
> +                DavProperty property = (DavProperty)iter.next();
>                  attributes.put(property.getName().toString(), property.getValue());
>              }
>              properties = getPropertyNames(fileName);
> -            @SuppressWarnings("unchecked") // iterator() is documented to return DavProperty instances
> -            Iterator<DavProperty> iter2 = properties.iterator();
> +            Iterator iter2 = properties.iterator();
>              while (iter2.hasNext())
>              {
> -                DavProperty property = iter2.next();
> +                DavProperty property = (DavProperty)iter2.next();
>                  if (!attributes.containsKey(property.getName().getName()))
>                  {
>                      property = getProperty(fileName, property.getName());

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (VFS-369) Comppilation Issue

Posted by "Cedric Nanni (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/VFS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140561#comment-13140561 ] 

Cedric Nanni commented on VFS-369:
----------------------------------

Hi Gary,

I attached the patch.

Cedric.
                
> Comppilation Issue
> ------------------
>
>                 Key: VFS-369
>                 URL: https://issues.apache.org/jira/browse/VFS-369
>             Project: Commons VFS
>          Issue Type: Bug
>    Affects Versions: 2.0
>            Reporter: Cedric Nanni
>         Attachments: VFS-369.patch
>
>
> When I try to compile VFS on my computer I've got compilation errors due maybe because I use a more recent version of jackrabbit. I patched the code and now it compiles.
> diff -rupN original//org/apache/commons/vfs2/provider/webdav/ExceptionConverter.java patched//org/apache/commons/vfs2/provider/webdav/ExceptionConverter.java
> --- original//org/apache/commons/vfs2/provider/webdav/ExceptionConverter.java	2011-08-18 06:57:10.000000000 +0200
> +++ patched//org/apache/commons/vfs2/provider/webdav/ExceptionConverter.java	2011-10-24 20:35:41.000000000 +0200
> @@ -50,7 +50,7 @@ public final class ExceptionConverter
>          {
>              try
>              {
> -                Element error = davExc.toXml(DomUtil.BUILDER_FACTORY.newDocumentBuilder().newDocument());
> +                Element error = davExc.toXml(DomUtil.createDocument());
>                  if (DomUtil.matches(error, DavException.XML_ERROR, DavConstants.NAMESPACE))
>                  {
>                      if (DomUtil.hasChildElement(error, "exception", null))
> diff -rupN original//org/apache/commons/vfs2/provider/webdav/WebdavFileObject.java patched//org/apache/commons/vfs2/provider/webdav/WebdavFileObject.java
> --- original//org/apache/commons/vfs2/provider/webdav/WebdavFileObject.java	2011-08-18 06:57:10.000000000 +0200
> +++ patched//org/apache/commons/vfs2/provider/webdav/WebdavFileObject.java	2011-10-24 20:35:41.000000000 +0200
> @@ -292,19 +292,17 @@ public class WebdavFileObject extends Ht
>              URLFileName fileName = (URLFileName) getName();
>              DavPropertySet properties = getProperties(fileName, PropFindMethod.PROPFIND_ALL_PROP,
>                      new DavPropertyNameSet(), false);
> -            @SuppressWarnings("unchecked") // iterator() is documented to return DavProperty instances
> -            Iterator<DavProperty> iter = properties.iterator();
> +            Iterator iter = properties.iterator();
>              while (iter.hasNext())
>              {
> -                DavProperty property = iter.next();
> +                DavProperty property = (DavProperty)iter.next();
>                  attributes.put(property.getName().toString(), property.getValue());
>              }
>              properties = getPropertyNames(fileName);
> -            @SuppressWarnings("unchecked") // iterator() is documented to return DavProperty instances
> -            Iterator<DavProperty> iter2 = properties.iterator();
> +            Iterator iter2 = properties.iterator();
>              while (iter2.hasNext())
>              {
> -                DavProperty property = iter2.next();
> +                DavProperty property = (DavProperty)iter2.next();
>                  if (!attributes.containsKey(property.getName().getName()))
>                  {
>                      property = getProperty(fileName, property.getName());

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (VFS-369) Comppilation Issue

Posted by "Gary D. Gregory (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/VFS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140126#comment-13140126 ] 

Gary D. Gregory commented on VFS-369:
-------------------------------------

Cedric,

In order to for us consider this, please attach a patch file and grant the ASF license.

Thank you!
Gary
                
> Comppilation Issue
> ------------------
>
>                 Key: VFS-369
>                 URL: https://issues.apache.org/jira/browse/VFS-369
>             Project: Commons VFS
>          Issue Type: Bug
>    Affects Versions: 2.0
>            Reporter: Cedric Nanni
>
> When I try to compile VFS on my computer I've got compilation errors due maybe because I use a more recent version of jackrabbit. I patched the code and now it compiles.
> diff -rupN original//org/apache/commons/vfs2/provider/webdav/ExceptionConverter.java patched//org/apache/commons/vfs2/provider/webdav/ExceptionConverter.java
> --- original//org/apache/commons/vfs2/provider/webdav/ExceptionConverter.java	2011-08-18 06:57:10.000000000 +0200
> +++ patched//org/apache/commons/vfs2/provider/webdav/ExceptionConverter.java	2011-10-24 20:35:41.000000000 +0200
> @@ -50,7 +50,7 @@ public final class ExceptionConverter
>          {
>              try
>              {
> -                Element error = davExc.toXml(DomUtil.BUILDER_FACTORY.newDocumentBuilder().newDocument());
> +                Element error = davExc.toXml(DomUtil.createDocument());
>                  if (DomUtil.matches(error, DavException.XML_ERROR, DavConstants.NAMESPACE))
>                  {
>                      if (DomUtil.hasChildElement(error, "exception", null))
> diff -rupN original//org/apache/commons/vfs2/provider/webdav/WebdavFileObject.java patched//org/apache/commons/vfs2/provider/webdav/WebdavFileObject.java
> --- original//org/apache/commons/vfs2/provider/webdav/WebdavFileObject.java	2011-08-18 06:57:10.000000000 +0200
> +++ patched//org/apache/commons/vfs2/provider/webdav/WebdavFileObject.java	2011-10-24 20:35:41.000000000 +0200
> @@ -292,19 +292,17 @@ public class WebdavFileObject extends Ht
>              URLFileName fileName = (URLFileName) getName();
>              DavPropertySet properties = getProperties(fileName, PropFindMethod.PROPFIND_ALL_PROP,
>                      new DavPropertyNameSet(), false);
> -            @SuppressWarnings("unchecked") // iterator() is documented to return DavProperty instances
> -            Iterator<DavProperty> iter = properties.iterator();
> +            Iterator iter = properties.iterator();
>              while (iter.hasNext())
>              {
> -                DavProperty property = iter.next();
> +                DavProperty property = (DavProperty)iter.next();
>                  attributes.put(property.getName().toString(), property.getValue());
>              }
>              properties = getPropertyNames(fileName);
> -            @SuppressWarnings("unchecked") // iterator() is documented to return DavProperty instances
> -            Iterator<DavProperty> iter2 = properties.iterator();
> +            Iterator iter2 = properties.iterator();
>              while (iter2.hasNext())
>              {
> -                DavProperty property = iter2.next();
> +                DavProperty property = (DavProperty)iter2.next();
>                  if (!attributes.containsKey(property.getName().getName()))
>                  {
>                      property = getProperty(fileName, property.getName());

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Issue Comment Edited] (VFS-369) Comppilation Issue

Posted by "Cedric Nanni (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/VFS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140561#comment-13140561 ] 

Cedric Nanni edited comment on VFS-369 at 10/31/11 9:12 PM:
------------------------------------------------------------

Hi Gary,

Please find attached the patch.

Cedric.
                
      was (Author: cedric.nanni):
    Hi Gary,

I attached the patch.

Cedric.
                  
> Comppilation Issue
> ------------------
>
>                 Key: VFS-369
>                 URL: https://issues.apache.org/jira/browse/VFS-369
>             Project: Commons VFS
>          Issue Type: Bug
>    Affects Versions: 2.0
>            Reporter: Cedric Nanni
>         Attachments: VFS-369.patch
>
>
> When I try to compile VFS on my computer I've got compilation errors due maybe because I use a more recent version of jackrabbit. I patched the code and now it compiles.
> diff -rupN original//org/apache/commons/vfs2/provider/webdav/ExceptionConverter.java patched//org/apache/commons/vfs2/provider/webdav/ExceptionConverter.java
> --- original//org/apache/commons/vfs2/provider/webdav/ExceptionConverter.java	2011-08-18 06:57:10.000000000 +0200
> +++ patched//org/apache/commons/vfs2/provider/webdav/ExceptionConverter.java	2011-10-24 20:35:41.000000000 +0200
> @@ -50,7 +50,7 @@ public final class ExceptionConverter
>          {
>              try
>              {
> -                Element error = davExc.toXml(DomUtil.BUILDER_FACTORY.newDocumentBuilder().newDocument());
> +                Element error = davExc.toXml(DomUtil.createDocument());
>                  if (DomUtil.matches(error, DavException.XML_ERROR, DavConstants.NAMESPACE))
>                  {
>                      if (DomUtil.hasChildElement(error, "exception", null))
> diff -rupN original//org/apache/commons/vfs2/provider/webdav/WebdavFileObject.java patched//org/apache/commons/vfs2/provider/webdav/WebdavFileObject.java
> --- original//org/apache/commons/vfs2/provider/webdav/WebdavFileObject.java	2011-08-18 06:57:10.000000000 +0200
> +++ patched//org/apache/commons/vfs2/provider/webdav/WebdavFileObject.java	2011-10-24 20:35:41.000000000 +0200
> @@ -292,19 +292,17 @@ public class WebdavFileObject extends Ht
>              URLFileName fileName = (URLFileName) getName();
>              DavPropertySet properties = getProperties(fileName, PropFindMethod.PROPFIND_ALL_PROP,
>                      new DavPropertyNameSet(), false);
> -            @SuppressWarnings("unchecked") // iterator() is documented to return DavProperty instances
> -            Iterator<DavProperty> iter = properties.iterator();
> +            Iterator iter = properties.iterator();
>              while (iter.hasNext())
>              {
> -                DavProperty property = iter.next();
> +                DavProperty property = (DavProperty)iter.next();
>                  attributes.put(property.getName().toString(), property.getValue());
>              }
>              properties = getPropertyNames(fileName);
> -            @SuppressWarnings("unchecked") // iterator() is documented to return DavProperty instances
> -            Iterator<DavProperty> iter2 = properties.iterator();
> +            Iterator iter2 = properties.iterator();
>              while (iter2.hasNext())
>              {
> -                DavProperty property = iter2.next();
> +                DavProperty property = (DavProperty)iter2.next();
>                  if (!attributes.containsKey(property.getName().getName()))
>                  {
>                      property = getProperty(fileName, property.getName());

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (VFS-369) Compilation Issue

Posted by "Cedric Nanni (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/VFS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Cedric Nanni updated VFS-369:
-----------------------------

    Summary: Compilation Issue  (was: Comppilation Issue)
    
> Compilation Issue
> -----------------
>
>                 Key: VFS-369
>                 URL: https://issues.apache.org/jira/browse/VFS-369
>             Project: Commons VFS
>          Issue Type: Bug
>    Affects Versions: 2.0
>            Reporter: Cedric Nanni
>         Attachments: VFS-369.patch
>
>
> When I try to compile VFS on my computer I've got compilation errors due maybe because I use a more recent version of jackrabbit. I patched the code and now it compiles.
> diff -rupN original//org/apache/commons/vfs2/provider/webdav/ExceptionConverter.java patched//org/apache/commons/vfs2/provider/webdav/ExceptionConverter.java
> --- original//org/apache/commons/vfs2/provider/webdav/ExceptionConverter.java	2011-08-18 06:57:10.000000000 +0200
> +++ patched//org/apache/commons/vfs2/provider/webdav/ExceptionConverter.java	2011-10-24 20:35:41.000000000 +0200
> @@ -50,7 +50,7 @@ public final class ExceptionConverter
>          {
>              try
>              {
> -                Element error = davExc.toXml(DomUtil.BUILDER_FACTORY.newDocumentBuilder().newDocument());
> +                Element error = davExc.toXml(DomUtil.createDocument());
>                  if (DomUtil.matches(error, DavException.XML_ERROR, DavConstants.NAMESPACE))
>                  {
>                      if (DomUtil.hasChildElement(error, "exception", null))
> diff -rupN original//org/apache/commons/vfs2/provider/webdav/WebdavFileObject.java patched//org/apache/commons/vfs2/provider/webdav/WebdavFileObject.java
> --- original//org/apache/commons/vfs2/provider/webdav/WebdavFileObject.java	2011-08-18 06:57:10.000000000 +0200
> +++ patched//org/apache/commons/vfs2/provider/webdav/WebdavFileObject.java	2011-10-24 20:35:41.000000000 +0200
> @@ -292,19 +292,17 @@ public class WebdavFileObject extends Ht
>              URLFileName fileName = (URLFileName) getName();
>              DavPropertySet properties = getProperties(fileName, PropFindMethod.PROPFIND_ALL_PROP,
>                      new DavPropertyNameSet(), false);
> -            @SuppressWarnings("unchecked") // iterator() is documented to return DavProperty instances
> -            Iterator<DavProperty> iter = properties.iterator();
> +            Iterator iter = properties.iterator();
>              while (iter.hasNext())
>              {
> -                DavProperty property = iter.next();
> +                DavProperty property = (DavProperty)iter.next();
>                  attributes.put(property.getName().toString(), property.getValue());
>              }
>              properties = getPropertyNames(fileName);
> -            @SuppressWarnings("unchecked") // iterator() is documented to return DavProperty instances
> -            Iterator<DavProperty> iter2 = properties.iterator();
> +            Iterator iter2 = properties.iterator();
>              while (iter2.hasNext())
>              {
> -                DavProperty property = iter2.next();
> +                DavProperty property = (DavProperty)iter2.next();
>                  if (!attributes.containsKey(property.getName().getName()))
>                  {
>                      property = getProperty(fileName, property.getName());

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira