You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "geido (via GitHub)" <gi...@apache.org> on 2023/02/27 14:09:44 UTC
[GitHub] [superset] geido opened a new pull request, #23216: chore: Remove Cross Filter scoping modal
geido opened a new pull request, #23216:
URL: https://github.com/apache/superset/pull/23216
### SUMMARY
- Removes the cross filters scoping modal
- Changes the styles of the filter indicators in slice headers
- Fix an issue with highlighting the emitter chart
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N.A.
### TESTING INSTRUCTIONS
Verify that cross filters work as intended without the cross filter scoping modal
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [x] Required feature flags: DASHBOARD_CROSS_FILTERS
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #23216: chore: Remove Cross Filter scoping modal
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23216:
URL: https://github.com/apache/superset/pull/23216#issuecomment-1460296108
@kgabryje Ephemeral environment spinning up at http://54.71.89.70:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on a diff in pull request #23216: chore: Remove Cross Filter scoping modal
Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje commented on code in PR #23216:
URL: https://github.com/apache/superset/pull/23216#discussion_r1129636218
##########
superset-frontend/src/assets/images/icons/filter.svg:
##########
@@ -16,6 +16,7 @@ KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
-<svg width="24" height="24" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg">
Review Comment:
I think we already have this icon - it's called `filter_small.svg`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] TechAuditBI commented on pull request #23216: chore: Remove Cross Filter scoping modal
Posted by "TechAuditBI (via GitHub)" <gi...@apache.org>.
TechAuditBI commented on PR #23216:
URL: https://github.com/apache/superset/pull/23216#issuecomment-1499121163
@yousoph Hey! Any thoughts on my comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yousoph commented on pull request #23216: chore: Remove Cross Filter scoping modal
Posted by "yousoph (via GitHub)" <gi...@apache.org>.
yousoph commented on PR #23216:
URL: https://github.com/apache/superset/pull/23216#issuecomment-1539027169
It's in progress, there should be something up in the next week or two :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #23216: chore: Remove Cross Filter scoping modal
Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje commented on PR #23216:
URL: https://github.com/apache/superset/pull/23216#issuecomment-1460376444
1 more thing - the badge looks a bit weird when >= 10 filters are applied. I wonder if maybe we could change the shape to oval instead of a circle if there are 2 digits? @kasiazjc wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] TechAuditBI commented on pull request #23216: chore: Remove Cross Filter scoping modal
Posted by "TechAuditBI (via GitHub)" <gi...@apache.org>.
TechAuditBI commented on PR #23216:
URL: https://github.com/apache/superset/pull/23216#issuecomment-1494234195
> Hi @TechAuditBI ! I believe that the json metadata (in dashboard properties) can be used to cross filter control scoping for the time being.
>
> Would you be willing to share a bit more about your use case and how you're planning to use the cross filter scoping? Thanks in advance for the additional context!
Hi! We are mostly using it in situations where we have a bunch of different datasets in one dashboard to cross-filter charts using identically named columns. Usually it is helpful to create separate datasets for filtering in case of working with large amounts of data so that superset does not have to run select distinct queries to get all possible options. It speeds up dashboard loading process. Also we've developed some custom charts which tend to "mimic" filter box functionality via cross-filtering e.g. time filter in a form of slider aspired by such in PBI. And scoping is crucial for it's functionality. All in all i understand that our custom charts should not be a concern for the community. But scoping feature was very useful in a regular dashboard development. If it requires some effort to support scoping in this repository, we are ready to take this responsibility. You may have seen some PRs from @Always-prog he is our developer so we have already commited some of our work t
o the community and ready to expand our contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yousoph commented on pull request #23216: chore: Remove Cross Filter scoping modal
Posted by "yousoph (via GitHub)" <gi...@apache.org>.
yousoph commented on PR #23216:
URL: https://github.com/apache/superset/pull/23216#issuecomment-1489471034
Hi @TechAuditBI ! I believe that the json metadata (in dashboard properties) can be used to cross filter control scoping for the time being.
Would you be willing to share a bit more about your use case and how you're planning to use the cross filter scoping? Thanks in advance for the additional context!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on a diff in pull request #23216: chore: Remove Cross Filter scoping modal
Posted by "geido (via GitHub)" <gi...@apache.org>.
geido commented on code in PR #23216:
URL: https://github.com/apache/superset/pull/23216#discussion_r1129729590
##########
superset-frontend/src/assets/images/icons/filter.svg:
##########
@@ -16,6 +16,7 @@ KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
-<svg width="24" height="24" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg">
Review Comment:
The filter_small icon has a lot of padding around and it does not respect the sizes being given through the Icons component. In order to get a size M you would need to give it a XL. I believe the reason for that is because indeed it was meant to be "small". For that reason, I replaced the actual filter icon with the one from our design files as I believe it should be the same everywhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kasiazjc commented on pull request #23216: chore: Remove Cross Filter scoping modal
Posted by "kasiazjc (via GitHub)" <gi...@apache.org>.
kasiazjc commented on PR #23216:
URL: https://github.com/apache/superset/pull/23216#issuecomment-1461960514
> 1 more thing - the badge looks a bit weird when >= 10 filters are applied. I wonder if maybe we could change the shape to oval instead of a circle if there are 2 digits? @kasiazjc wdyt?
>
> <img alt="image" width="352" src="https://user-images.githubusercontent.com/15073128/223774736-0abb2a31-8dd3-4a06-b867-708a1d612e65.png">
Definitely agreed - my bad. Maybe we can just use the pill that is used in the "more filters" dropdown when filters are applied (horizontal filter bar)? (but keeping colors we have here)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #23216: chore: Remove Cross Filter scoping modal
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23216:
URL: https://github.com/apache/superset/pull/23216#issuecomment-1446416578
# [Codecov](https://codecov.io/gh/apache/superset/pull/23216?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23216](https://codecov.io/gh/apache/superset/pull/23216?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (01612bc) into [master](https://codecov.io/gh/apache/superset/commit/dcd3e00f39ca16979c53d7bead865a54d23bc622?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dcd3e00) will **decrease** coverage by `2.39%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #23216 +/- ##
==========================================
- Coverage 67.51% 65.13% -2.39%
==========================================
Files 1900 1900
Lines 73304 73290 -14
Branches 7928 7927 -1
==========================================
- Hits 49492 47736 -1756
- Misses 21780 23523 +1743
+ Partials 2032 2031 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.75% <ø> (ø)` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `52.66% <ø> (ø)` | |
| python | `77.33% <ø> (-4.94%)` | :arrow_down: |
| sqlite | `76.96% <ø> (ø)` | |
| unit | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/23216?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nd/src/dashboard/components/FiltersBadge/index.tsx](https://codecov.io/gh/apache/superset/pull/23216?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9pbmRleC50c3g=) | `86.11% <ø> (ø)` | |
| [...end/src/dashboard/components/SliceHeader/index.tsx](https://codecov.io/gh/apache/superset/pull/23216?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyL2luZGV4LnRzeA==) | `92.15% <ø> (+2.68%)` | :arrow_up: |
| [...dashboard/components/SliceHeaderControls/index.tsx](https://codecov.io/gh/apache/superset/pull/23216?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMvaW5kZXgudHN4) | `72.22% <ø> (+1.81%)` | :arrow_up: |
| [...set/advanced\_data\_type/plugins/internet\_address.py](https://codecov.io/gh/apache/superset/pull/23216?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYWR2YW5jZWRfZGF0YV90eXBlL3BsdWdpbnMvaW50ZXJuZXRfYWRkcmVzcy5weQ==) | `16.32% <0.00%> (-79.60%)` | :arrow_down: |
| [superset/utils/pandas\_postprocessing/boxplot.py](https://codecov.io/gh/apache/superset/pull/23216?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nL2JveHBsb3QucHk=) | `20.51% <0.00%> (-79.49%)` | :arrow_down: |
| [superset/charts/post\_processing.py](https://codecov.io/gh/apache/superset/pull/23216?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL3Bvc3RfcHJvY2Vzc2luZy5weQ==) | `12.40% <0.00%> (-77.38%)` | :arrow_down: |
| [...perset/advanced\_data\_type/plugins/internet\_port.py](https://codecov.io/gh/apache/superset/pull/23216?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYWR2YW5jZWRfZGF0YV90eXBlL3BsdWdpbnMvaW50ZXJuZXRfcG9ydC5weQ==) | `18.75% <0.00%> (-77.09%)` | :arrow_down: |
| [superset/datasets/commands/update.py](https://codecov.io/gh/apache/superset/pull/23216?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvdXBkYXRlLnB5) | `25.00% <0.00%> (-69.05%)` | :arrow_down: |
| [superset/utils/pandas\_postprocessing/rolling.py](https://codecov.io/gh/apache/superset/pull/23216?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nL3JvbGxpbmcucHk=) | `21.87% <0.00%> (-68.75%)` | :arrow_down: |
| [...perset/utils/pandas\_postprocessing/contribution.py](https://codecov.io/gh/apache/superset/pull/23216?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nL2NvbnRyaWJ1dGlvbi5weQ==) | `34.61% <0.00%> (-65.39%)` | :arrow_down: |
| ... and [112 more](https://codecov.io/gh/apache/superset/pull/23216?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #23216: chore: Remove Cross Filter scoping modal
Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje commented on PR #23216:
URL: https://github.com/apache/superset/pull/23216#issuecomment-1450502966
/testenv up FEATURE_DASHBOARD_CROSS_FILTERS=true FEATURE_HORIZONTAL_FILTER_BAR=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #23216: chore: Remove Cross Filter scoping modal
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on PR #23216:
URL: https://github.com/apache/superset/pull/23216#issuecomment-1466621160
/testenv up FEATURE_DASHBOARD_CROSS_FILTERS=true FEATURE_HORIZONTAL_FILTER_BAR=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #23216: chore: Remove Cross Filter scoping modal
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on PR #23216:
URL: https://github.com/apache/superset/pull/23216#issuecomment-1466615187
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #23216: chore: Remove Cross Filter scoping modal
Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje commented on PR #23216:
URL: https://github.com/apache/superset/pull/23216#issuecomment-1450522767
A few comments:
1. The filter icon looks different than in designs - it's much thinner
2. There is no background behind filter icon and the pill
3. The pill looks like an egg
4. The spacings between the icons are off
5. The cursor changes to pointer only on the filter icon (remains default between the icon and the pill, changes to text cursor on the pill) even though the whole thing is clickable
6. In some cases the pill overflows to second line
Screenshots of the implementation:
<img width="143" alt="image" src="https://user-images.githubusercontent.com/15073128/222212932-c92124bd-261f-4570-8d94-beb0c4ee6842.png">
<img width="115" alt="image" src="https://user-images.githubusercontent.com/15073128/222212974-360689dd-5ff5-4866-a080-fc1a8ed07fd2.png">
<img width="364" alt="image" src="https://user-images.githubusercontent.com/15073128/222213029-61bed2e4-ee95-41c8-b96b-ca35b1137e29.png">
Screenshots of the design:
<img width="229" alt="image" src="https://user-images.githubusercontent.com/15073128/222213148-0f8562fc-bc8a-4087-9794-5a72f952153e.png">
<img width="400" alt="image" src="https://user-images.githubusercontent.com/15073128/222213194-0a361b71-a764-4649-9aa3-075a3c875b8d.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #23216: chore: Remove Cross Filter scoping modal
Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje commented on PR #23216:
URL: https://github.com/apache/superset/pull/23216#issuecomment-1460289258
/testenv up FEATURE_DASHBOARD_CROSS_FILTERS=true FEATURE_HORIZONTAL_FILTER_BAR=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] TechAuditBI commented on pull request #23216: chore: Remove Cross Filter scoping modal
Posted by "TechAuditBI (via GitHub)" <gi...@apache.org>.
TechAuditBI commented on PR #23216:
URL: https://github.com/apache/superset/pull/23216#issuecomment-1508137831
> Hi all! We discussed the cross filters scoping a bit and we are thinking about bringing it back with the following improvements:
>
> * additional access point to set cross filter scoping from the filter bar settings menu
> * allow users to see all cross filter scoping in one place in a cross filter scoping modal and switch between scoping different charts from here
> * still allow setting up cross filter scoping by clicking from the chart overflow menu
>
> In addition to the above, we're also considering adding a global cross filter scoping option, so if some charts should not be impacted by any cross filters, that can be set at this global level instead of individually scoped from each emitting chart.
Good news!
What is an ETA on this? And do you need any assistance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yousoph commented on pull request #23216: chore: Remove Cross Filter scoping modal
Posted by "yousoph (via GitHub)" <gi...@apache.org>.
yousoph commented on PR #23216:
URL: https://github.com/apache/superset/pull/23216#issuecomment-1500705439
Thanks for the context, @TechAuditBI
@kasiazjc and I are going to discuss next steps, will provide another update in a few days
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on a diff in pull request #23216: chore: Remove Cross Filter scoping modal
Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje commented on code in PR #23216:
URL: https://github.com/apache/superset/pull/23216#discussion_r1129636986
##########
superset-frontend/src/dashboard/components/FiltersBadge/index.tsx:
##########
@@ -43,6 +43,47 @@ export interface FiltersBadgeProps {
chartId: number;
}
+const StyledFilterCount = styled.div`
+ ${({ theme }) => `
+ display: flex;
+ justify-items: center;
+ align-items: center;
+ cursor: pointer;
+ margin-right: ${theme.gridUnit}px;
+ padding-left: ${theme.gridUnit * 2}px;
+ padding-right: ${theme.gridUnit * 2}px;
+ background: ${theme.colors.grayscale.light4};
+ border-radius: 4px;
+ .anticon {
+ vertical-align: middle;
+ color: ${theme.colors.grayscale.base};
+ &:hover {
+ color: ${theme.colors.grayscale.light1}
+ }
+ }
+
+ .incompatible-count {
+ font-size: ${theme.typography.sizes.s}px;
+ }
+ `}
+`;
+
+const StyledBadge = styled(Badge)`
+ ${({ theme }) => `
+ vertical-align: middle;
+ margin-left: ${theme.gridUnit * 2 + 2}px;
Review Comment:
Can we use full grid units? I think it's ok to round this margin down to `gridUnit * 2`
##########
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx:
##########
@@ -557,6 +524,9 @@ class SliceHeaderControls extends React.PureComponent<
placement="bottomRight"
>
<span
+ css={(theme: SupersetTheme) => css`
+ padding-top: ${theme.gridUnit / 2}px;
Review Comment:
Could we center this button with flex maybe instead of padding?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #23216: chore: Remove Cross Filter scoping modal
Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje commented on PR #23216:
URL: https://github.com/apache/superset/pull/23216#issuecomment-1460367857
I think the spacing here is too big - it's 2*8px but it should be 8px. Other than that and a few nits in the code, looks great!
<img width="317" alt="image" src="https://user-images.githubusercontent.com/15073128/223759908-ebafbdfa-615a-4478-8631-b70fa4352057.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] TechAuditBI commented on pull request #23216: chore: Remove Cross Filter scoping modal
Posted by "TechAuditBI (via GitHub)" <gi...@apache.org>.
TechAuditBI commented on PR #23216:
URL: https://github.com/apache/superset/pull/23216#issuecomment-1485072906
Hi! I'm sorry but why have you deleted cross-filter scoping functionality? It was so useful and allowed to apply some sketchy filtering techniques.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #23216: chore: Remove Cross Filter scoping modal
Posted by "geido (via GitHub)" <gi...@apache.org>.
geido commented on PR #23216:
URL: https://github.com/apache/superset/pull/23216#issuecomment-1488144103
> @geido Sorry for bothering you but I'm really frustrated about this PR and our team would have to do a bunch of work to adapt our current custom functionality to this new reality.
Hello @TechAuditBI we are aware that this is creating a bit of discomfort and we are acting accordingly. Let me ping a few people for awareness @kasiazjc @yousoph
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] TechAuditBI commented on pull request #23216: chore: Remove Cross Filter scoping modal
Posted by "TechAuditBI (via GitHub)" <gi...@apache.org>.
TechAuditBI commented on PR #23216:
URL: https://github.com/apache/superset/pull/23216#issuecomment-1504823608
> Hi! We were also extensively using this feature and were sad to see it go. Here's our use case, which I did not see mentioned here as of yet (weird because I thought it's pretty common): Lets say we have a dashboard displaying events which have a 4 depth classification system: Component -> Category -> Sub Category -> Sub Sub Category We have 4 pie charts, one for each classification level, and we use them to drill down into a specific Sub Sub category We then see a table, and some time series charts, which show only events of this specific classification. This is working beautifully with the amazing cross dashboard filtering. Now regarding scoping, we don't want the Category pie chart to apply its filter to the Component pie chart! The Sub Category pie chart should not apply its filter to both Category and Component And the Sub Sub Category should not apply its filter to any other pie chart above it. Otherwise, you get that the pie charts which are above in the classification sy
stem show only a single slice, according to what was chosen below it, and it looks pretty funny.
Amazing usecase! Thanks for partisipating!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #23216: chore: Remove Cross Filter scoping modal
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23216:
URL: https://github.com/apache/superset/pull/23216#issuecomment-1466696839
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #23216: chore: Remove Cross Filter scoping modal
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23216:
URL: https://github.com/apache/superset/pull/23216#issuecomment-1466627268
@eschutho Ephemeral environment spinning up at http://34.214.121.29:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #23216: chore: Remove Cross Filter scoping modal
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23216:
URL: https://github.com/apache/superset/pull/23216#issuecomment-1466627306
@eschutho Ephemeral environment spinning up at http://34.214.121.29:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] TechAuditBI commented on pull request #23216: chore: Remove Cross Filter scoping modal
Posted by "TechAuditBI (via GitHub)" <gi...@apache.org>.
TechAuditBI commented on PR #23216:
URL: https://github.com/apache/superset/pull/23216#issuecomment-1488135061
@geido Sorry for bothering you but I'm really frustrated about this PR and our team would have to do a bunch of work to adapt our current custom functionality to this new reality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #23216: chore: Remove Cross Filter scoping modal
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #23216:
URL: https://github.com/apache/superset/pull/23216#issuecomment-1499246381
CC @villebro who had similar wishes for the revival of this feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] itaipelles commented on pull request #23216: chore: Remove Cross Filter scoping modal
Posted by "itaipelles (via GitHub)" <gi...@apache.org>.
itaipelles commented on PR #23216:
URL: https://github.com/apache/superset/pull/23216#issuecomment-1503637160
Hi!
We were also extensively using this feature and were sad to see it go.
Here's our use case, which I did not see mentioned here as of yet (weird because I thought it's pretty common):
Lets say we have a dashboard displaying events which have a 4 depth classification system:
Component -> Category -> Sub Category -> Sub Sub Category
We have 4 pie charts, one for each classification level, and we use them to drill down into a specific Sub Sub category
We then see a table, and some time series charts, which show only events of this specific classification.
This is working beautifully with the amazing cross dashboard filtering.
Now regarding scoping, we don't want the Category pie chart to apply its filter to the Component pie chart!
The Sub Category pie chart should not apply its filter to both Category and Component
And the Sub Sub Category should not apply its filter to any other pie chart above it.
Otherwise, you get that the pie charts which are above in the classification system show only a single slice, according to what was chosen below it, and it looks pretty funny.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #23216: chore: Remove Cross Filter scoping modal
Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje commented on PR #23216:
URL: https://github.com/apache/superset/pull/23216#issuecomment-1462259715
Looks great! I found 1 more, tiny issue - if there is no emitter icon, the badge has 22px height. If there is emitter icon, the badge has 25px height. Can we set a fixed 24px height like in the design? We can also do it as a follow up or "smuggle" the fix in another pr
<img width="366" alt="image" src="https://user-images.githubusercontent.com/15073128/224072923-00ed1034-0a8c-42b8-a815-c4dbb5aebbe5.png">
<img width="326" alt="image" src="https://user-images.githubusercontent.com/15073128/224073014-89fdbccd-bd5f-4290-be9f-da099b81c887.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jinghua-qa commented on pull request #23216: chore: Remove Cross Filter scoping modal
Posted by "jinghua-qa (via GitHub)" <gi...@apache.org>.
jinghua-qa commented on PR #23216:
URL: https://github.com/apache/superset/pull/23216#issuecomment-1466576732
OK to skip the flaky E2E test as long as we have a plan to fix and re-enable in the future. For the cross-filtering feature, will test after merge in FAT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] TechAuditBI commented on pull request #23216: chore: Remove Cross Filter scoping modal
Posted by "TechAuditBI (via GitHub)" <gi...@apache.org>.
TechAuditBI commented on PR #23216:
URL: https://github.com/apache/superset/pull/23216#issuecomment-1488251816
> > @geido Sorry for bothering you but I'm really frustrated about this PR and our team would have to do a bunch of work to adapt our current custom functionality to this new reality.
>
> Hello @TechAuditBI we are aware that this is creating a bit of discomfort and we are acting accordingly. Let me ping a few people for awareness @kasiazjc @yousoph
So did i understand you correctly that you are developing some alternative?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #23216: chore: Remove Cross Filter scoping modal
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #23216:
URL: https://github.com/apache/superset/pull/23216#issuecomment-1499253888
Thanks for pinging @rusackas - yes, I feel strongly about bringing this back, and I will be happy to participate in maintenance of said feature 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jinghua-qa merged pull request #23216: chore: Remove Cross Filter scoping modal
Posted by "jinghua-qa (via GitHub)" <gi...@apache.org>.
jinghua-qa merged PR #23216:
URL: https://github.com/apache/superset/pull/23216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yousoph commented on pull request #23216: chore: Remove Cross Filter scoping modal
Posted by "yousoph (via GitHub)" <gi...@apache.org>.
yousoph commented on PR #23216:
URL: https://github.com/apache/superset/pull/23216#issuecomment-1507645929
Hi all! We discussed the cross filters scoping a bit and we are thinking about bringing it back with the following improvements:
* additional access point to set cross filter scoping from the filter bar settings menu
* allow users to see all cross filter scoping in one place in a cross filter scoping modal and switch between scoping different charts from here
* still allow setting up cross filter scoping by clicking from the chart overflow menu
In addition to the above, we're also considering adding a global cross filter scoping option, so if some charts should not be impacted by any cross filters, that can be set at this global level instead of individually scoped from each emitting chart.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] TechAuditBI commented on pull request #23216: chore: Remove Cross Filter scoping modal
Posted by "TechAuditBI (via GitHub)" <gi...@apache.org>.
TechAuditBI commented on PR #23216:
URL: https://github.com/apache/superset/pull/23216#issuecomment-1485069039
Hi! I'm sorry but why have you deleted cross-filter scoping functionality? It was so useful and allowed to apply some sketchy filtering techniques.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #23216: chore: Remove Cross Filter scoping modal
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23216:
URL: https://github.com/apache/superset/pull/23216#issuecomment-1450507100
@kgabryje Ephemeral environment spinning up at http://34.217.33.133:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #23216: chore: Remove Cross Filter scoping modal
Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje commented on PR #23216:
URL: https://github.com/apache/superset/pull/23216#issuecomment-1462266303
If you set `height: 24px` on the badge, please remember to add `align-items: center` on the wrapper, otherwise the badge will be aligned to the top of the icon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on a diff in pull request #23216: chore: Remove Cross Filter scoping modal
Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje commented on code in PR #23216:
URL: https://github.com/apache/superset/pull/23216#discussion_r1129740954
##########
superset-frontend/src/assets/images/icons/filter.svg:
##########
@@ -16,6 +16,7 @@ KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
-<svg width="24" height="24" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg">
Review Comment:
Got it 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org