You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ode.apache.org by "Rafal Rusin (JIRA)" <ji...@apache.org> on 2009/06/19 21:24:07 UTC
[jira] Created: (ODE-626) Unpack details blob from ODE_JOB table
Unpack details blob from ODE_JOB table
--------------------------------------
Key: ODE-626
URL: https://issues.apache.org/jira/browse/ODE-626
Project: ODE
Issue Type: Improvement
Components: BPEL Runtime
Affects Versions: 2.0
Reporter: Rafal Rusin
Fix For: 2.0
Related discussion is here:
http://markmail.org/thread/iiy6utvsqew6nn6m
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (ODE-626) Unpack details blob from
ODE_JOB table
Posted by "Alexis Midon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725353#action_12725353 ]
Alexis Midon edited comment on ODE-626 at 6/29/09 2:18 PM:
-----------------------------------------------------------
#1. Regarding an eventual factory method to instantiate JobDetails, I'm wondering why we need an interface in the first place. JodDetails is a pojo and I can't think of any other implementations. I think the interface & factory is trying to solve an issue that does not exist yet, which is not good. So my opinion is: delete the interface JobDetails, rename JobDetailsImpl into JobDetails.
#2. Regarding ProcessCleanUpRunnable, RuntimeDataCleanupRunnable, I think Sean will know. I'll ping him for feedback.
#3 why should we keep the WorkEvent class? The purpose of this class was to "wraps around job detail map", witch is what your patch solves. I would remove the WorkEvent class and use JodDetails instead.
#4 don't you think we could maintain compatibility between old (packed) jobs and the new (unpacked) ones? This could spare a lot of migration pain for existing databases. JdbcDelegate#dequeueImmediate could check the detailsExt map for old keys and assign values to the corresponding new instance attributes.
was (Author: alexismidon):
#1. Regarding an eventual factory method to instantiate JobDetails, I'm wondering why we need an interface in the first place. JodDetails is a pojo and I can't think of any other implementations. I think the interface & factory is trying to solve an issue that does not exist yet, which is not good. So my opinion is: turns JodDetail into a class, delete JobDetailsimpl.
#2. Regarding ProcessCleanUpRunnable, RuntimeDataCleanupRunnable, I think Sean will know. I'll ping him for feedback.
#3 why should we keep the WorkEvent class? The purpose of this class was to "wraps around job detail map", witch is what your patch solves.
#4 don't you think we could maintain compatibility between old (packed) jobs and the new (unpacked) ones? This could spare a lot of migration pain for existing databases. JdbcDelegate#dequeueImmediate could check the detailsExt map for old keys and assign values to the corresponding new instance attributes.
> Unpack details blob from ODE_JOB table
> --------------------------------------
>
> Key: ODE-626
> URL: https://issues.apache.org/jira/browse/ODE-626
> Project: ODE
> Issue Type: Improvement
> Components: BPEL Runtime
> Affects Versions: 2.0
> Reporter: Rafal Rusin
> Assignee: Rafal Rusin
> Fix For: 2.0
>
> Attachments: unpackJobDetails.patch
>
>
> Related discussion is here:
> http://markmail.org/thread/iiy6utvsqew6nn6m
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (ODE-626) Unpack details blob from ODE_JOB table
Posted by "Rafal Rusin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rafal Rusin resolved ODE-626.
-----------------------------
Resolution: Fixed
> Unpack details blob from ODE_JOB table
> --------------------------------------
>
> Key: ODE-626
> URL: https://issues.apache.org/jira/browse/ODE-626
> Project: ODE
> Issue Type: Improvement
> Components: BPEL Runtime
> Affects Versions: 2.0
> Reporter: Rafal Rusin
> Assignee: Rafal Rusin
> Fix For: 2.0
>
> Attachments: unpackJobDetails.patch
>
>
> Related discussion is here:
> http://markmail.org/thread/iiy6utvsqew6nn6m
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (ODE-626) Unpack details blob from ODE_JOB table
Posted by "Rafal Rusin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rafal Rusin resolved ODE-626.
-----------------------------
Resolution: Fixed
I committed a version without factory method for JobDetails interface.
> Unpack details blob from ODE_JOB table
> --------------------------------------
>
> Key: ODE-626
> URL: https://issues.apache.org/jira/browse/ODE-626
> Project: ODE
> Issue Type: Improvement
> Components: BPEL Runtime
> Affects Versions: 2.0
> Reporter: Rafal Rusin
> Fix For: 2.0
>
> Attachments: unpackJobDetails.patch
>
>
> Related discussion is here:
> http://markmail.org/thread/iiy6utvsqew6nn6m
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ODE-626) Unpack details blob from ODE_JOB table
Posted by "Rafal Rusin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725483#action_12725483 ]
Rafal Rusin commented on ODE-626:
---------------------------------
Thanks for reply.
As for:
#1 - suggestion is OK. I just wanted to keep interface separation, because JobDetailsImpl is not strictly POJO. For example is converts JobType enum to String type field or pid QName to String pid field. JdbcDelegate makes use of those public fields. But I agree, it's less mess without separation.
#3 - I kept it for naming reasons. There's a lot of code, which references it. But I agree it's for removal, so I'll do that.
#4 - OK, I'll do that. I haven't considered migration yet, because Alex pointed it's not necessary for ODE 2.X, sice it's not in production yet.
> Unpack details blob from ODE_JOB table
> --------------------------------------
>
> Key: ODE-626
> URL: https://issues.apache.org/jira/browse/ODE-626
> Project: ODE
> Issue Type: Improvement
> Components: BPEL Runtime
> Affects Versions: 2.0
> Reporter: Rafal Rusin
> Assignee: Rafal Rusin
> Fix For: 2.0
>
> Attachments: unpackJobDetails.patch
>
>
> Related discussion is here:
> http://markmail.org/thread/iiy6utvsqew6nn6m
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (ODE-626) Unpack details blob from ODE_JOB table
Posted by "Alexis Midon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexis Midon reopened ODE-626:
------------------------------
#1. Regarding an eventual factory method to instantiate JobDetails, I'm wondering why we need an interface in the first place. JodDetails is a pojo and I can't think of any other implementations. I think the interface & factory is trying to solve an issue that does not exist yet, which is not good. So my opinion is: turns JodDetail into a class, delete JobDetailsimpl.
#2. Regarding ProcessCleanUpRunnable, RuntimeDataCleanupRunnable, I think Sean will know. I'll ping him for feedback.
#3 why should we keep the WorkEvent class? The purpose of this class was to "wraps around job detail map", witch is what your patch solves.
#4 don't you think we could maintain compatibility between old (packed) jobs and the new (unpacked) ones? This could spare a lot of migration pain for existing databases. JdbcDelegate#dequeueImmediate could check the detailsExt map for old keys and assign values to the corresponding new instance attributes.
> Unpack details blob from ODE_JOB table
> --------------------------------------
>
> Key: ODE-626
> URL: https://issues.apache.org/jira/browse/ODE-626
> Project: ODE
> Issue Type: Improvement
> Components: BPEL Runtime
> Affects Versions: 2.0
> Reporter: Rafal Rusin
> Fix For: 2.0
>
> Attachments: unpackJobDetails.patch
>
>
> Related discussion is here:
> http://markmail.org/thread/iiy6utvsqew6nn6m
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ODE-626) Unpack details blob from ODE_JOB table
Posted by "Rafal Rusin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rafal Rusin updated ODE-626:
----------------------------
Fix Version/s: 1.3.4
> Unpack details blob from ODE_JOB table
> --------------------------------------
>
> Key: ODE-626
> URL: https://issues.apache.org/jira/browse/ODE-626
> Project: ODE
> Issue Type: Improvement
> Components: BPEL Runtime
> Affects Versions: 2.0
> Reporter: Rafal Rusin
> Assignee: Rafal Rusin
> Fix For: 1.3.4, 2.0
>
> Attachments: unpackJobDetails.patch
>
>
> Related discussion is here:
> http://markmail.org/thread/iiy6utvsqew6nn6m
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ODE-626) Unpack details blob from ODE_JOB table
Posted by "Rafal Rusin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725525#action_12725525 ]
Rafal Rusin commented on ODE-626:
---------------------------------
I addressed issues #1, #3, #4.
> Unpack details blob from ODE_JOB table
> --------------------------------------
>
> Key: ODE-626
> URL: https://issues.apache.org/jira/browse/ODE-626
> Project: ODE
> Issue Type: Improvement
> Components: BPEL Runtime
> Affects Versions: 2.0
> Reporter: Rafal Rusin
> Assignee: Rafal Rusin
> Fix For: 2.0
>
> Attachments: unpackJobDetails.patch
>
>
> Related discussion is here:
> http://markmail.org/thread/iiy6utvsqew6nn6m
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ODE-626) Unpack details blob from ODE_JOB table
Posted by "Sean Ahn (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725379#action_12725379 ]
Sean Ahn commented on ODE-626:
------------------------------
Rafal,
I think you can do any refactoring you want to do. I agree with Alexis on that the code has already become pretty messy around the this job details map.
Thanks for the refactoring effort.
> Unpack details blob from ODE_JOB table
> --------------------------------------
>
> Key: ODE-626
> URL: https://issues.apache.org/jira/browse/ODE-626
> Project: ODE
> Issue Type: Improvement
> Components: BPEL Runtime
> Affects Versions: 2.0
> Reporter: Rafal Rusin
> Assignee: Rafal Rusin
> Fix For: 2.0
>
> Attachments: unpackJobDetails.patch
>
>
> Related discussion is here:
> http://markmail.org/thread/iiy6utvsqew6nn6m
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ODE-626) Unpack details blob from ODE_JOB table
Posted by "Alexis Midon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725663#action_12725663 ]
Alexis Midon commented on ODE-626:
----------------------------------
great! thanks a lot
> Unpack details blob from ODE_JOB table
> --------------------------------------
>
> Key: ODE-626
> URL: https://issues.apache.org/jira/browse/ODE-626
> Project: ODE
> Issue Type: Improvement
> Components: BPEL Runtime
> Affects Versions: 2.0
> Reporter: Rafal Rusin
> Assignee: Rafal Rusin
> Fix For: 2.0
>
> Attachments: unpackJobDetails.patch
>
>
> Related discussion is here:
> http://markmail.org/thread/iiy6utvsqew6nn6m
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ODE-626) Unpack details blob from ODE_JOB table
Posted by "Rafal Rusin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rafal Rusin updated ODE-626:
----------------------------
Attachment: unpackJobDetails.patch
I ended up with quite large changes. Work is almost done (it passes all test cases), but I've got a few questions about cron scheduling implementation yet.
I extracted entries for:
+ instanceId BIGINT,
+ mexId varchar(255),
+ processId varchar(255),
+ type varchar(255),
+ channel varchar(255),
+ correlatorId varchar(255),
+ correlationKey varchar(255),
+ retryCount int,
+ inMem int,
+ detailsExt blob,
I needed to hold blob column - detailsExt, which is used for instance cleanup. It uses columns cleanupInfo, pidsToExclude, pid and trasactionTimeout. I believe it's convenient to leave such blob column for various extensions. If extensions map is empty, then it's serialized to null in DB.
However, I've got 2 issues.
- I needed to put JobDetailsImpl to bpel-iapi, because job details are instantiated inside ProcessConfImpl. I'd like to add factory method createDetails into Scheduler bpel-api and add scheduler dependency to ProcessConfImpl, but please confirm it.
- I left pid column in cleanup runnables (ProcessCleanUpRunnable, RuntimeDataCleanupRunnable) inside detailsExt blob, but please confirm if I can change constructor
public ProcessCleanUpRunnable(Serializable pid)
with _pid to QName and pass toString() here:
_contexts.dao.getConnection().createTransientProcess(_pid.toString())
OK, it's all.
Thanks in advance for reply.
> Unpack details blob from ODE_JOB table
> --------------------------------------
>
> Key: ODE-626
> URL: https://issues.apache.org/jira/browse/ODE-626
> Project: ODE
> Issue Type: Improvement
> Components: BPEL Runtime
> Affects Versions: 2.0
> Reporter: Rafal Rusin
> Fix For: 2.0
>
> Attachments: unpackJobDetails.patch
>
>
> Related discussion is here:
> http://markmail.org/thread/iiy6utvsqew6nn6m
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ODE-626) Unpack details blob from ODE_JOB table
Posted by "Alexis Midon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexis Midon reassigned ODE-626:
--------------------------------
Assignee: Rafal Rusin
it's all yours! ;)
> Unpack details blob from ODE_JOB table
> --------------------------------------
>
> Key: ODE-626
> URL: https://issues.apache.org/jira/browse/ODE-626
> Project: ODE
> Issue Type: Improvement
> Components: BPEL Runtime
> Affects Versions: 2.0
> Reporter: Rafal Rusin
> Assignee: Rafal Rusin
> Fix For: 2.0
>
> Attachments: unpackJobDetails.patch
>
>
> Related discussion is here:
> http://markmail.org/thread/iiy6utvsqew6nn6m
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.