[GitHub] [airflow] dstandish commented on pull request #28440: Propagate logs to stdout when in k8s executor pod

[GitBox <gi...@apache.org>]

dstandish commented on PR #28440:
URL: https://github.com/apache/airflow/pull/28440#issuecomment-1362454819

   two changes that are sort of elective in this one are (1) overridable "maintain propagate" and (2) checking if ti is actually a TI
   
   both of these were required because while fixing some tests that were failing i noticed that the test replaced the whole logging config with something completely different and i curious why that was necessary so i dug in.  we needed to check TI because in some of the test it's a mock value (and checking doesn't hurt anything -- if it's not TI it will fail anyway.  then overriding maintain propagate is necessary to ensure that pytest caplog works... again... it doesn't hurt anything being there and allows us to do less manipulation in the tests which, all else equal, is a good thing. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org