You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/06/15 22:09:49 UTC

[GitHub] [commons-collections] aherbert commented on pull request #313: Remove redundant local variable.

aherbert commented on PR #313:
URL: https://github.com/apache/commons-collections/pull/313#issuecomment-1157001745

   Certainly in the case of the BloomFilter Shape, the code has been written as a direct translation of the known formulas. Running it through the `javap` decompiler the code is 32 bytes in java byte code and so will be inlined anyway (it is under the 35 byte default). Once the bytecode has been optimised in the JVM I expected there will be no difference with this code revision given that the call to log1p will take longer than the rest of the code put together.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org