[GitHub] brooklyn-ui pull request #100: Landscape view - initial refactor

[ahgittin <gi...@git.apache.org>]

GitHub user ahgittin opened a pull request:

    https://github.com/apache/brooklyn-ui/pull/100

    Landscape view - initial refactor

    This refactors the blueprint code to allow dev work on a new "landscape" graphical mode.
    
    It is disabled in the last commit so should be no change to UX with this,
    but the other changes should make it easier to work on a landscape view by playing with the sizes of nodes.  They refactor much more of the layout-specific logic into subclasses, make the elements being rendered more flexible, and make more of the computations derived from known values.
    
    There is more work to make things like ghost nodes fully derived from the nodes they ghost, which we will need for the landscape view to be able to fill the space but this gets us a good bit of the way there.
    
    If landscape is enabled, it doesn't do what we want, but it has slightly different boxier behaviour to the normal mode to indicate the direction of travel.
    
    <img width="1238" alt="visual1" src="https://user-images.githubusercontent.com/496540/48207969-b3a7f400-e369-11e8-8eb7-f3c087cad685.png">


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ahgittin/brooklyn-ui landscape-view

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-ui/pull/100.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #100
    
----
commit a21c4386bd96ece3a74f2485d746bf9b45b0951a
Author: Alex Heneveld <al...@...>
Date:   2018-11-07T10:16:17Z

    initial refactor for a mgmt view

commit 84311027a77968a85d1a0bbf3b10c0cde4262399
Author: Alex Heneveld <al...@...>
Date:   2018-11-07T11:05:08Z

    new landscape view mode known in code and UI -- does nothing yet, but can click to it

commit 041febc34ae34569f5bcf6bbd9b826cfdc69eb3f
Author: Alex Heneveld <al...@...>
Date:   2018-11-07T15:39:57Z

    refactor how positions set in designer in prep for landscape view,
    with placeholder landscape view (doesn't do any filling, just squarer bits)

commit c6e1dec702a9c93523fcc35ec47c76841b96771b
Author: Alex Heneveld <al...@...>
Date:   2018-11-08T15:14:20Z

    comment out the enablement of landscape view

----


---