(texera) branch gh-readonly-queue/main/pr-8155-48da91c6048f4365a514d1a180f6e51685dbf649 created (now 2a21b6610c)

[gi...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

github-merge-queue[bot] pushed a change to branch gh-readonly-queue/main/pr-8155-48da91c6048f4365a514d1a180f6e51685dbf649
in repository https://gitbox.apache.org/repos/asf/texera.git


      at 2a21b6610c feat(amber): reject missing hub entity type (#8155)

This branch includes the following new commits:

     new 2a21b6610c feat(amber): reject missing hub entity type (#8155)

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.

(texera) 01/01: feat(amber): reject missing hub entity type (#8155)

[gi...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

github-merge-queue[bot] pushed a commit to branch gh-readonly-queue/main/pr-8155-48da91c6048f4365a514d1a180f6e51685dbf649
in repository https://gitbox.apache.org/repos/asf/texera.git

commit 2a21b6610c6e51a6bf956f4101571609e5e7d796
Author: carloea2 <ca...@uci.edu>
AuthorDate: Fri Sep 4 19:33:37 2026 +0000

    feat(amber): reject missing hub entity type (#8155)
    
    ### What changes were proposed in this PR?
    
    Reject a missing hub entity type with a clear 400 response before table
    lookup.
    
    Before: missing entity type -> unhandled match error -> 500
    After: missing entity type -> 400 with `Missing entityType`
    
    ### Any related issues, documentation, discussions?
    
    Closes #8154
    
    ### How was this PR tested?
    
    Added a regression test for the missing value. Existing tests retain
    positive coverage for both workflow and dataset table dispatch.
    
    `sbt "WorkflowExecutionService / Test / testOnly
    org.apache.texera.web.resource.dashboard.hub.EntityTablesSpec"`
    
    `sbt scalafmtCheckAll`
    
    `sbt "scalafixAll --check"`
    
    Live local checks against the built branch:
    
    | Request | Before | After |
    | --- | --- | --- |
    | missing `entityType` | 500 | 400 |
    | invalid `entityType` | 404 | 404 |
    | `entityType=workflow` | 200 | 200 |
    | `entityType=dataset` | 200 | 200 |
    
    ### Was this PR authored or co-authored using generative AI tooling?
    
    Generated-by: Codex
---
 .../apache/texera/web/resource/dashboard/hub/EntityTables.scala    | 3 +++
 .../texera/web/resource/dashboard/hub/EntityTablesSpec.scala       | 7 +++++++
 .../apache/texera/web/resource/dashboard/hub/HubResourceSpec.scala | 5 +++++
 3 files changed, 15 insertions(+)

diff --git a/amber/src/main/scala/org/apache/texera/web/resource/dashboard/hub/EntityTables.scala b/amber/src/main/scala/org/apache/texera/web/resource/dashboard/hub/EntityTables.scala
index 0e557f40f7..1e1bc472cb 100644
--- a/amber/src/main/scala/org/apache/texera/web/resource/dashboard/hub/EntityTables.scala
+++ b/amber/src/main/scala/org/apache/texera/web/resource/dashboard/hub/EntityTables.scala
@@ -25,6 +25,8 @@ import org.apache.texera.dao.jooq.generated.tables.records._
 import org.apache.texera.web.resource.dashboard.VersionedResourceTables
 import org.jooq._
 
+import javax.ws.rs.BadRequestException
+
 object EntityTables {
 
   // ==================== THE REGISTRY ====================
@@ -80,6 +82,7 @@ object EntityTables {
 
   def apply(entityType: EntityType): EntityTableSet =
     entityType match {
+      case null                => throw new BadRequestException("Missing entityType")
       case EntityType.Workflow => WorkflowTableSet
       case EntityType.Dataset  => DatasetTableSet
       case EntityType.Model    => ModelTableSet
diff --git a/amber/src/test/scala/org/apache/texera/web/resource/dashboard/hub/EntityTablesSpec.scala b/amber/src/test/scala/org/apache/texera/web/resource/dashboard/hub/EntityTablesSpec.scala
index b888def78c..75b913e4a1 100644
--- a/amber/src/test/scala/org/apache/texera/web/resource/dashboard/hub/EntityTablesSpec.scala
+++ b/amber/src/test/scala/org/apache/texera/web/resource/dashboard/hub/EntityTablesSpec.scala
@@ -23,6 +23,8 @@ import org.apache.texera.web.resource.dashboard.VersionedResourceTables
 import org.scalatest.flatspec.AnyFlatSpec
 import org.scalatest.matchers.should.Matchers
 
+import javax.ws.rs.BadRequestException
+
 class EntityTablesSpec extends AnyFlatSpec with Matchers {
 
   // -- BaseEntityTable --------------------------------------------------------
@@ -145,6 +147,11 @@ class EntityTablesSpec extends AnyFlatSpec with Matchers {
     model.versionedResource shouldBe Some(VersionedResourceTables.ModelTables)
   }
 
+  it should "reject a missing entity type" in {
+    val error = intercept[BadRequestException](EntityTables(null))
+    error.getMessage shouldBe "Missing entityType"
+  }
+
   // -- AccessTable ------------------------------------------------------------
 
   "EntityTables.AccessTable" should "expose id, uid and privilege per entity" in {
diff --git a/amber/src/test/scala/org/apache/texera/web/resource/dashboard/hub/HubResourceSpec.scala b/amber/src/test/scala/org/apache/texera/web/resource/dashboard/hub/HubResourceSpec.scala
index 8b425c75d6..027716ee2d 100644
--- a/amber/src/test/scala/org/apache/texera/web/resource/dashboard/hub/HubResourceSpec.scala
+++ b/amber/src/test/scala/org/apache/texera/web/resource/dashboard/hub/HubResourceSpec.scala
@@ -682,6 +682,11 @@ class HubResourceSpec
     new HubResource().getCount(Wf).intValue() shouldBe 1
   }
 
+  it should "reject a missing entity type" in {
+    intercept[BadRequestException](hub.getCount(null))
+    intercept[BadRequestException](hub.getTops(null, null, null, null))
+  }
+
   it should "leave non-public workflows out of the count" in {
     // On top of the public fixture workflow (wid 7001) seeded in beforeAll.
     seedWorkflow(810501, "wf_public_a", isPublic = true, withOwnerRows = false)