[jira] [Commented] (FLINK-10789) Some new serializer snapshots added after 1.6 are not implementing the new TypeSerializerSnapshot interface

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-10789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676230#comment-16676230 ] 

ASF GitHub Bot commented on FLINK-10789:
----------------------------------------

tzulitai opened a new pull request #7028: [FLINK-10789] New serializer snapshots after 1.6 should implement TypeSerializerSnapshot
URL: https://github.com/apache/flink/pull/7028
 
 
   ## What is the purpose of the change
   
   Commit 3787b89105c6a005ddca999b0b8a0356e812ede6 added a few new serializer snapshots, but they extend the now deprecated `TypeSerializerConfigSnapshot`. Namely,
   
   - LockableSerializerConfigSnapshot
   - ListViewSerializerConfigSnapshot
   - MapViewSerializerConfigSnapshot
   - ScalaEitherSerializerConfigSnapshot
   
   While this doesn't break things, this means that they will be written with the old format and will require us to add migration code paths for them after the release.
   
   This PR changes so that they implement the new `TypeSerializerSnapshot` interface.
   There is one commit for changing each individual snapshot.
   
   ## Brief change log
   
   - Updated the `LockableSerializerConfigSnapshot` and added a migration test for it
   - Updated the `ListViewSerializerConfigSnapshot` and added a migration test for it. This also explicitly sets the serial version UID for the `ListViewSerializer` otherwise the migration test fails.
   - Updated the `MapViewSerializerConfigSnapshot` and added a migration test for it. This also explicitly sets the serial version UID for the `MapViewSerializer` otherwise the migration test fails.
   - Updated the `ScalaEitherSerializerConfigSnapshot` and added a migration test for it
   
   ## Verifying this change
   
   The change is covered by the new migration tests:
   
   - `LockableTypeSerializerSnapshotMigrationTest`
   - `ListViewSerializerSnapshotMigrationTest`
   - `MapViewSerializerSnapshotMigrationTest`
   - `ScalaEitherSerializerSnapshotMigrationTest`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (**yes** / no / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (**yes** / no / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Some new serializer snapshots added after 1.6 are not implementing the new TypeSerializerSnapshot interface
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-10789
>                 URL: https://issues.apache.org/jira/browse/FLINK-10789
>             Project: Flink
>          Issue Type: Improvement
>          Components: Type Serialization System
>            Reporter: Tzu-Li (Gordon) Tai
>            Assignee: Tzu-Li (Gordon) Tai
>            Priority: Critical
>              Labels: pull-request-available
>
> In commit [3787b89105c6a005ddca999b0b8a0356e812ede6|[https://github.com/apache/flink/commit/3787b89105c6a005ddca999b0b8a0356e812ede6],] there were a few serializer snapshot implementations that were newly added, namely:
> - {{LockableSerializerConfigSnapshot}}
> - {{ListViewSerializerConfigSnapshot}}
> - {{MapViewSerializerConfigSnapshot}}
> - {{ScalaEitherSerializerConfigSnapshot}}
> The problem is that instead of implementing the newer {{TypeSerializerSnapshot}}, they are extending the legacy deprecated {{TypeSerializerConfigSnapshot}}. This doesn't break things, but we will be redundantly writing Java-serialized with the new snapshots, as well as causing us to must introduce migration paths code later on after releasing them.
> It would be more ideal to implement them properly as {{TypeSerializerSnapshot}} for the release.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)