[jira] [Resolved] (SOLR-6214) Snapshots numberToKeep param only keeps n-1 backups

["Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-6214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shalin Shekhar Mangar resolved SOLR-6214.
-----------------------------------------
       Resolution: Fixed
    Fix Version/s: 5.1
                   Trunk

Thanks Mathias, Ramana and Varun!

> Snapshots numberToKeep param only keeps n-1 backups
> ---------------------------------------------------
>
>                 Key: SOLR-6214
>                 URL: https://issues.apache.org/jira/browse/SOLR-6214
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 4.9
>            Reporter: Mathias H.
>            Assignee: Shalin Shekhar Mangar
>            Priority: Minor
>             Fix For: Trunk, 5.1
>
>         Attachments: SOLR-6214.patch, SOLR-6214.patch, SOLR-6214.patch
>
>
> The numberToKeep param for snapshots doesn't work anymore. If you set the param to '2', only '1' backup is kept.
> In the ReplicationHandler in line 377 snapShooter.validateCreateSnapshot(); creates an empty directory for the new snapshot. The deleteOldBackups() method in Snapshooter which will be executed before the backup is created, now sees the two directories an deletes the old one. But this is wrong because the empty directory for the new backup should not be considered.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org