[GitHub] [geode] aditya87 opened pull request #2815: Introduce Lombok

["aditya87 (GitHub)" <gi...@apache.org>]

Signed-off-by: Peter Tran <pt...@pivotal.io>

Wanted to introduce Lombok (https://projectlombok.org/) as proof-of-concept of how it can reduce the size of some classes.

We see the following advantages of using Lombok:
-> Less boilerplate code.
-> Can use builder pattern implicitly, which allows for much better composeability of an object.
-> Increased readability

More details: https://projectlombok.org/features/all

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [X] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [X] Is your initial contribution a single, squashed commit?

- [X] Does `gradlew build` run cleanly?

- [X] Have you written or updated unit tests to verify your changes?

- [X] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2815 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] aditya87 commented on issue #2815: [GEODE-6021] Introduce Lombok

["aditya87 (GitHub)" <gi...@apache.org>]

Withdrawing for now. There are some risks associated with JDK10 that we need to investigate further. Further discussion on the geode-dev list.

[ Full content available at: https://github.com/apache/geode/pull/2815 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] aditya87 closed pull request #2815: [GEODE-6021] Introduce Lombok

["aditya87 (GitHub)" <gi...@apache.org>]

[ pull request closed by aditya87 ]

[ Full content available at: https://github.com/apache/geode/pull/2815 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] metatype commented on issue #2815: Introduce Lombok

["metatype (GitHub)" <gi...@apache.org>]

@aditya87 Can you poke the dev@ list with this proposed change?  I think it's a big enough change to warrant discussion.

[ Full content available at: https://github.com/apache/geode/pull/2815 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] aditya87 commented on pull request #2815: Introduce Lombok

["aditya87 (GitHub)" <gi...@apache.org>]

Sure

[ Full content available at: https://github.com/apache/geode/pull/2815 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] metatype commented on pull request #2815: Introduce Lombok

["metatype (GitHub)" <gi...@apache.org>]

Also, since Lombok is MIT licensed you'll need to reference it in the LICENSE in geode-assembly.

[ Full content available at: https://github.com/apache/geode/pull/2815 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] metatype commented on pull request #2815: Introduce Lombok

["metatype (GitHub)" <gi...@apache.org>]

Does Lombok need to be on the runtime classpath?  If so, you'll need to make sure it gets added to geode-dependencies.jar in the `geode-assembly/build.gradle` file.

[ Full content available at: https://github.com/apache/geode/pull/2815 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] aditya87 commented on pull request #2815: Introduce Lombok

["aditya87 (GitHub)" <gi...@apache.org>]

It’s compile only. I’m not too familiar with expected_jars, maybe it doesn’t need to be here.

[ Full content available at: https://github.com/apache/geode/pull/2815 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] aditya87 commented on pull request #2815: Introduce Lombok

["aditya87 (GitHub)" <gi...@apache.org>]

I think 1.16.20 is used by the gradle-lombok plugin.

[ Full content available at: https://github.com/apache/geode/pull/2815 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] metatype commented on pull request #2815: Introduce Lombok

["metatype (GitHub)" <gi...@apache.org>]

Probably only need only of these right?

[ Full content available at: https://github.com/apache/geode/pull/2815 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org