[GitHub] arunlakshman commented on issue #109: [NEMO-89] Clean up IRVertex#getClone()

[GitBox <gi...@apache.org>]

arunlakshman commented on issue #109: [NEMO-89] Clean up IRVertex#getClone()
URL: https://github.com/apache/incubator-nemo/pull/109#issuecomment-414130821
 
 
   Hi @johnyangk ,
   
      I have made the chnages so that the unit test passes. But I am unsure about the following,
   
   In `IRVertex.java`, if we change the line 50 from 
   ```super(IdManager.newVertexId());```
   to
   ```super(that.getId());```
   
     Then we get the following error in the tests
   
   ```
   Tests in error:
     testLoopFusionPass(edu.snu.nemo.compiler.optimizer.pass.compiletime.reshaping.LoopFusionPassTest): The DAG does not contain [destination] of the edge: [vertex-12]->[vertex-13] in [vertex-10, vertex-11, vertex-9, vertex-12, vertex-13, vertex-3, vertex-4, vertex-1, vertex-2, vertex-7, vertex-8, vertex-5, vertex-6]
   
   Tests run: 31, Failures: 0, Errors: 1, Skipped: 0
   ```
   
   1. Do we need to copy the ID of the existing vertex while cloning (That is what stated in the [JIRA](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-89))
   2. **OR** should we create new ID while cloning the vertex

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services