You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2020/05/31 20:26:32 UTC
[Impala-ASF-CR] IMPALA-9798: avoid racy hole punch check in test env
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16012
Change subject: IMPALA-9798: avoid racy hole punch check in test env
......................................................................
IMPALA-9798: avoid racy hole punch check in test env
The issue was that multiple Impala daemons would start up
around the same time and remove then re-create the impala-scratch
subdirectory. This raced with the hole punch check, which created
a file in that directory.
The fix is to create the hole punch test file up a level in
the directory structure, not inside impala-scratch.
Testing
* Ran exhaustive build.
Change-Id: I6ded24014486e930d1ab47a1e5e9c791c3d7de05
---
M be/src/runtime/tmp-file-mgr.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/16012/1
--
To view, visit http://gerrit.cloudera.org:8080/16012
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6ded24014486e930d1ab47a1e5e9c791c3d7de05
Gerrit-Change-Number: 16012
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9798: avoid racy hole punch check in test env
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Laszlo Gaal, Bikramjeet Vig, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16012
to look at the new patch set (#2).
Change subject: IMPALA-9798: avoid racy hole punch check in test env
......................................................................
IMPALA-9798: avoid racy hole punch check in test env
The issue was that multiple Impala daemons would start up
around the same time and remove then re-create the impala-scratch
subdirectory. This raced with the hole punch check, which created
a file in that directory.
The fix is to create the hole punch test file up a level in
the directory structure, not inside impala-scratch.
Testing
* Ran exhaustive build.
Change-Id: I6ded24014486e930d1ab47a1e5e9c791c3d7de05
---
M be/src/runtime/tmp-file-mgr.cc
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/16012/2
--
To view, visit http://gerrit.cloudera.org:8080/16012
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6ded24014486e930d1ab47a1e5e9c791c3d7de05
Gerrit-Change-Number: 16012
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
[Impala-ASF-CR] IMPALA-9798: avoid racy hole punch check in test env
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16012 )
Change subject: IMPALA-9798: avoid racy hole punch check in test env
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16012
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ded24014486e930d1ab47a1e5e9c791c3d7de05
Gerrit-Change-Number: 16012
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Jun 2020 23:49:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9798: avoid racy hole punch check in test env
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16012 )
Change subject: IMPALA-9798: avoid racy hole punch check in test env
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16012
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ded24014486e930d1ab47a1e5e9c791c3d7de05
Gerrit-Change-Number: 16012
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Jun 2020 05:00:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9798: avoid racy hole punch check in test env
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16012 )
Change subject: IMPALA-9798: avoid racy hole punch check in test env
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5926/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/16012
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ded24014486e930d1ab47a1e5e9c791c3d7de05
Gerrit-Change-Number: 16012
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Jun 2020 23:49:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9798: avoid racy hole punch check in test env
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16012 )
Change subject: IMPALA-9798: avoid racy hole punch check in test env
......................................................................
IMPALA-9798: avoid racy hole punch check in test env
The issue was that multiple Impala daemons would start up
around the same time and remove then re-create the impala-scratch
subdirectory. This raced with the hole punch check, which created
a file in that directory.
The fix is to create the hole punch test file up a level in
the directory structure, not inside impala-scratch.
Testing
* Ran exhaustive build.
Change-Id: I6ded24014486e930d1ab47a1e5e9c791c3d7de05
Reviewed-on: http://gerrit.cloudera.org:8080/16012
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/runtime/tmp-file-mgr.cc
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/16012
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6ded24014486e930d1ab47a1e5e9c791c3d7de05
Gerrit-Change-Number: 16012
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
[Impala-ASF-CR] IMPALA-9798: avoid racy hole punch check in test env
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16012 )
Change subject: IMPALA-9798: avoid racy hole punch check in test env
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6178/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16012
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ded24014486e930d1ab47a1e5e9c791c3d7de05
Gerrit-Change-Number: 16012
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Sun, 31 May 2020 21:14:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9798: avoid racy hole punch check in test env
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/16012 )
Change subject: IMPALA-9798: avoid racy hole punch check in test env
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16012
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ded24014486e930d1ab47a1e5e9c791c3d7de05
Gerrit-Change-Number: 16012
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Jun 2020 23:49:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9798: avoid racy hole punch check in test env
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16012 )
Change subject: IMPALA-9798: avoid racy hole punch check in test env
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6177/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16012
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ded24014486e930d1ab47a1e5e9c791c3d7de05
Gerrit-Change-Number: 16012
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Sun, 31 May 2020 21:14:09 +0000
Gerrit-HasComments: No