You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/11/13 09:59:45 UTC

[GitHub] [skywalking] wu-sheng opened a new pull request #3849: Refactor DataCarrier, support ArrayBlockingQueueBuffer as implementor

wu-sheng opened a new pull request #3849: Refactor DataCarrier, support ArrayBlockingQueueBuffer as implementor
URL: https://github.com/apache/skywalking/pull/3849
 
 
   Follow #3726, I am adding the new implementation for blocking mode, which is mostly used at the OAP server.  In this scenario, OAP is more sensitive about across threads visibility but has less concern about the blocking or lock issue. 
   
   DataCarrier implementation queue still has better performance and less lock time, so we will keep it in the agent, unless we have more evidence that the ArrayBlockingQueueBuffer implementor is also better.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services