You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/03/31 13:47:24 UTC
[GitHub] [incubator-apisix] qiujiayu opened a new pull request #1380: add
global name
qiujiayu opened a new pull request #1380: add global name
URL: https://github.com/apache/incubator-apisix/pull/1380
Fix #1379
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on a change in pull request
#1380: add global name
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1380: add global name
URL: https://github.com/apache/incubator-apisix/pull/1380#discussion_r400933188
##########
File path: conf/config.yaml
##########
@@ -15,6 +15,7 @@
# limitations under the License.
#
apisix:
+ name: APISIX # application name
Review comment:
how about `APISIX gateway name`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis closed pull request #1380: add global
name
Posted by GitBox <gi...@apache.org>.
membphis closed pull request #1380: add global name
URL: https://github.com/apache/incubator-apisix/pull/1380
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on issue #1380: add global
name
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1380: add global name
URL: https://github.com/apache/incubator-apisix/pull/1380#issuecomment-607071106
need test case
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] moonming commented on a change in pull request
#1380: add global name
Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #1380: add global name
URL: https://github.com/apache/incubator-apisix/pull/1380#discussion_r402707913
##########
File path: conf/config.yaml
##########
@@ -15,6 +15,7 @@
# limitations under the License.
#
apisix:
+ name: APISIX # APISIX gateway name
Review comment:
as discuss in mailing list:https://lists.apache.org/thread.html/r2856157a47272100b97cf8c93e93933edfcfc9724477625e531ee1b0%40%3Cdev.apisix.apache.org%3E, we'd better not add name in config.yaml.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on a change in pull request
#1380: add global name
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1380: add global name
URL: https://github.com/apache/incubator-apisix/pull/1380#discussion_r402745741
##########
File path: conf/config.yaml
##########
@@ -15,6 +15,7 @@
# limitations under the License.
#
apisix:
+ name: APISIX # APISIX gateway name
Review comment:
close it first
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services