You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by we...@apache.org on 2010/03/02 22:36:28 UTC

svn commit: r918200 - in /myfaces/extensions/scripting/trunk/core/core/src/main/java/org/apache/myfaces/scripting: core/dependencyScan/ core/dependencyScan/api/ loaders/java/

Author: werpu
Date: Tue Mar  2 21:36:28 2010
New Revision: 918200

URL: http://svn.apache.org/viewvc?rev=918200&view=rev
Log:
https://issues.apache.org/jira/browse/EXTSCRIPT-81

removed junk code

Removed:
    myfaces/extensions/scripting/trunk/core/core/src/main/java/org/apache/myfaces/scripting/core/dependencyScan/DependencyScanner.java
Modified:
    myfaces/extensions/scripting/trunk/core/core/src/main/java/org/apache/myfaces/scripting/core/dependencyScan/StandardDependencyScanner.java
    myfaces/extensions/scripting/trunk/core/core/src/main/java/org/apache/myfaces/scripting/core/dependencyScan/api/DependencyScanner.java
    myfaces/extensions/scripting/trunk/core/core/src/main/java/org/apache/myfaces/scripting/loaders/java/JavaDependencyScanner.java

Modified: myfaces/extensions/scripting/trunk/core/core/src/main/java/org/apache/myfaces/scripting/core/dependencyScan/StandardDependencyScanner.java
URL: http://svn.apache.org/viewvc/myfaces/extensions/scripting/trunk/core/core/src/main/java/org/apache/myfaces/scripting/core/dependencyScan/StandardDependencyScanner.java?rev=918200&r1=918199&r2=918200&view=diff
==============================================================================
--- myfaces/extensions/scripting/trunk/core/core/src/main/java/org/apache/myfaces/scripting/core/dependencyScan/StandardDependencyScanner.java (original)
+++ myfaces/extensions/scripting/trunk/core/core/src/main/java/org/apache/myfaces/scripting/core/dependencyScan/StandardDependencyScanner.java Tue Mar  2 21:36:28 2010
@@ -19,6 +19,7 @@
 package org.apache.myfaces.scripting.core.dependencyScan;
 
 import org.apache.myfaces.scripting.core.dependencyScan.api.DependencyRegistry;
+import org.apache.myfaces.scripting.core.dependencyScan.api.DependencyScanner;
 import org.apache.myfaces.scripting.core.dependencyScan.core.ClassScanUtils;
 import org.apache.myfaces.scripting.core.dependencyScan.core.ClassScanVisitor;
 import org.apache.myfaces.scripting.core.dependencyScan.core.ExtendedClassReader;

Modified: myfaces/extensions/scripting/trunk/core/core/src/main/java/org/apache/myfaces/scripting/core/dependencyScan/api/DependencyScanner.java
URL: http://svn.apache.org/viewvc/myfaces/extensions/scripting/trunk/core/core/src/main/java/org/apache/myfaces/scripting/core/dependencyScan/api/DependencyScanner.java?rev=918200&r1=918199&r2=918200&view=diff
==============================================================================
--- myfaces/extensions/scripting/trunk/core/core/src/main/java/org/apache/myfaces/scripting/core/dependencyScan/api/DependencyScanner.java (original)
+++ myfaces/extensions/scripting/trunk/core/core/src/main/java/org/apache/myfaces/scripting/core/dependencyScan/api/DependencyScanner.java Tue Mar  2 21:36:28 2010
@@ -18,45 +18,23 @@
  */
 package org.apache.myfaces.scripting.core.dependencyScan.api;
 
+import org.apache.myfaces.scripting.core.dependencyScan.api.DependencyRegistry;
 import org.apache.myfaces.scripting.core.dependencyScan.registry.ExternalFilterDependencyRegistry;
 
-import java.util.Set;
-
 /**
+ * Standard dependency scanner interface
+ *
  * @author Werner Punz (latest modification by $Author$)
  * @version $Revision$ $Date$
- *          <p/>
- *          A dependency scanner for
- *          our classes
- *          <p/>
- *          The idea beind it is that a dependency scanner
- *          should scan loaded classes for their dependencies
- *          into a whitelist of packages, a dynamically loaded class
- *          then now can taint other classes if altered
- *          which are in the whitelist so that those artefacts get reloaded
- *          <p/>
- *          The whitelist itself for now should only be
- *          classes from dynamically loaded packages
  */
 public interface DependencyScanner {
-
-    /**
-     * fetch the dependencies from a given classname and
-     * register them in a registry
-     *
-     * @param loader    the classloader responsible for serving the infrastructure
-     * @param className the classname from which the dependencies have to be fetched
-     * @param registry  our registry which should store the dependencies
-     */
-    public void fetchDependencies(ClassLoader loader, String className, ExternalFilterDependencyRegistry registry);
-
     /**
-     * soon to be deprecated, fetch dependencies working on an existing whitelist system
+     * main method every dependency scanner has to implement
      *
-     * @param loader
-     * @param className
-     * @param whiteList
-     * @return a list of dependencies from the class &lt;className&gt;
+     * @param loader     the classloader which is able to serve the requested class resources
+     * @param engineType integer value of the scanning triggering engine type
+     * @param className  of the class to be scanned
+     * @param registry   the registry which should receive the results of the scan
      */
-    public Set<String> fetchDependencies(ClassLoader loader, String className, Set<String> whiteList);
+    public void fetchDependencies(ClassLoader loader, Integer engineType, String className, DependencyRegistry registry);
 }

Modified: myfaces/extensions/scripting/trunk/core/core/src/main/java/org/apache/myfaces/scripting/loaders/java/JavaDependencyScanner.java
URL: http://svn.apache.org/viewvc/myfaces/extensions/scripting/trunk/core/core/src/main/java/org/apache/myfaces/scripting/loaders/java/JavaDependencyScanner.java?rev=918200&r1=918199&r2=918200&view=diff
==============================================================================
--- myfaces/extensions/scripting/trunk/core/core/src/main/java/org/apache/myfaces/scripting/loaders/java/JavaDependencyScanner.java (original)
+++ myfaces/extensions/scripting/trunk/core/core/src/main/java/org/apache/myfaces/scripting/loaders/java/JavaDependencyScanner.java Tue Mar  2 21:36:28 2010
@@ -22,7 +22,7 @@
 import org.apache.myfaces.scripting.api.ClassScanner;
 import org.apache.myfaces.scripting.api.ScriptingConst;
 import org.apache.myfaces.scripting.api.ScriptingWeaver;
-import org.apache.myfaces.scripting.core.dependencyScan.DependencyScanner;
+import org.apache.myfaces.scripting.core.dependencyScan.api.DependencyScanner;
 import org.apache.myfaces.scripting.core.dependencyScan.StandardDependencyScanner;
 import org.apache.myfaces.scripting.core.dependencyScan.filter.WhitelistFilter;
 import org.apache.myfaces.scripting.core.dependencyScan.registry.DependencyRegistryImpl;