You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "carloea2 (via GitHub)" <gi...@apache.org> on 2026/08/29 05:55:23 UTC
[PR] fix(amber): report malformed websocket messages [texera]
carloea2 opened a new pull request, #8092:
URL: https://github.com/apache/texera/pull/8092
### What changes were proposed in this PR?
Workflow WebSocket request parsing now runs inside the endpoint's existing error handler. Malformed JSON is reported with the same `WorkflowErrorEvent` used for other request failures, while the parsing exception still reaches the WebSocket container.
A regression test sends incomplete JSON through the real handler and verifies the error event. The existing heartbeat test continues to cover valid input.
Before: Malformed JSON escaped without an error event.
After: Malformed JSON produces a `WorkflowErrorEvent`.
### Any related issues, documentation, discussions?
Closes #8091
### How was this PR tested?
The regression test failed before the production change because no message was sent. After the change, all 16 tests in the WebSocket resource suite passed.
```shell
sbt "set DAO / Compile / sourceGenerators := Seq.empty" "WorkflowExecutionService / Test / testOnly org.apache.texera.web.resource.WorkflowWebsocketResourceSpec"
sbt "set DAO / Compile / sourceGenerators := Seq.empty" "scalafixAll --check"
sbt scalafmtCheckAll
```
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: OpenAI Codex, GPT-5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(amber): report malformed websocket messages [texera]
Posted by "carloea2 (via GitHub)" <gi...@apache.org>.
carloea2 commented on PR #8092:
URL: https://github.com/apache/texera/pull/8092#issuecomment-6045440724
Closing this duplicate in favor of #8164.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(amber): report malformed websocket messages [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8092:
URL: https://github.com/apache/texera/pull/8092#issuecomment-5460683183
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@Yicong-Huang`, `@aglinxinyuan`
You can notify them by mentioning `@Yicong-Huang`, `@aglinxinyuan` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(amber): report malformed websocket messages [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8092:
URL: https://github.com/apache/texera/pull/8092#issuecomment-5460735911
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/8092?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 93.52%. Comparing base ([`caeb27e`](https://app.codecov.io/gh/apache/texera/commit/caeb27ea5476f0596054b20ed06ec667778c330b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`372b58d`](https://app.codecov.io/gh/apache/texera/commit/372b58dc4278d5d4056dec607ba93f463f2fd16c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on main.
:white_check_mark: All tests successful. No failed tests found.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #8092 +/- ##
============================================
- Coverage 93.52% 93.52% -0.01%
+ Complexity 4731 4730 -1
============================================
Files 1195 1195
Lines 48504 48504
Branches 5379 5379
============================================
- Hits 45362 45361 -1
Misses 1695 1695
- Partials 1447 1448 +1
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/8092/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/8092/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.00% <ø> (ø)` | | Carriedforward from [caeb27e](https://app.codecov.io/gh/apache/texera/commit/caeb27ea5476f0596054b20ed06ec667778c330b?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/8092/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `99.32% <ø> (ø)` | | Carriedforward from [caeb27e](https://app.codecov.io/gh/apache/texera/commit/caeb27ea5476f0596054b20ed06ec667778c330b?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/8092/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `89.60% <100.00%> (-0.01%)` | :arrow_down: | |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/8092/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.67% <ø> (ø)` | | Carriedforward from [caeb27e](https://app.codecov.io/gh/apache/texera/commit/caeb27ea5476f0596054b20ed06ec667778c330b?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/8092/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `86.86% <ø> (ø)` | | Carriedforward from [caeb27e](https://app.codecov.io/gh/apache/texera/commit/caeb27ea5476f0596054b20ed06ec667778c330b?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/8092/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.91% <ø> (ø)` | | Carriedforward from [caeb27e](https://app.codecov.io/gh/apache/texera/commit/caeb27ea5476f0596054b20ed06ec667778c330b?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/8092/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `95.86% <ø> (ø)` | | Carriedforward from [caeb27e](https://app.codecov.io/gh/apache/texera/commit/caeb27ea5476f0596054b20ed06ec667778c330b?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/8092/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `79.31% <ø> (ø)` | | Carriedforward from [caeb27e](https://app.codecov.io/gh/apache/texera/commit/caeb27ea5476f0596054b20ed06ec667778c330b?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/8092/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `98.50% <ø> (ø)` | | Carriedforward from [caeb27e](https://app.codecov.io/gh/apache/texera/commit/caeb27ea5476f0596054b20ed06ec667778c330b?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/8092/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.19% <ø> (ø)` | | Carriedforward from [caeb27e](https://app.codecov.io/gh/apache/texera/commit/caeb27ea5476f0596054b20ed06ec667778c330b?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/8092?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(amber): report malformed websocket messages [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8092:
URL: https://github.com/apache/texera/pull/8092#issuecomment-5460683208
<!-- backport-auto-label-report -->
### Backport auto-label report
This `fix:` PR was checked against each actively-supported release branch. `release/*` labels drive the post-merge backport, so add or remove one to change where this fix lands.
| Release branch | Analysis |
| --- | --- |
| ✅ `release/v1.2` | Change detected on this branch — label added; this fix is queued to backport here. Requested review from @xuang7. |
_[Auto-label run](https://github.com/apache/texera/actions/runs/33237265099)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(amber): report malformed websocket messages [texera]
Posted by "carloea2 (via GitHub)" <gi...@apache.org>.
carloea2 closed pull request #8092: feat(amber): report malformed websocket messages
URL: https://github.com/apache/texera/pull/8092
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(amber): report malformed websocket messages [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8092:
URL: https://github.com/apache/texera/pull/8092#issuecomment-5460706992
<!-- texera-benchmarks-comment -->
## ⚠️ Benchmark changes need a look
🟢 0 better · 🔴 9 worse · ⚪ 6 noise (<±5%) · 0 without baseline
> Compared against main `caeb27e` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
[Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/33237272701)
| | config | throughput | MB/s | latency | max Δ latest / 7d |
|---|---|---:|---:|---:|---:|
| 🔴 | bs=10 sw=10 sl=64 | 372 | 0.227 | 27,038/37,265/37,265 us | 🔴 +22.3% / 🔴 +162.1% |
| 🔴 | bs=100 sw=10 sl=64 | 920 | 0.562 | 105,525/157,258/157,258 us | 🔴 +25.8% / 🔴 +65.4% |
| 🔴 | bs=1000 sw=10 sl=64 | 1,107 | 0.676 | 902,525/1,030,128/1,030,128 us | 🔴 +6.1% / 🔴 +12.4% |
<details><summary>Baseline details</summary>
Latest main `caeb27e` from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---:|---:|---:|---:|---:|
| bs=10 sw=10 sl=64 | throughput | 372 tuples/sec | 454 tuples/sec | 894.27 tuples/sec | -18.1% | -58.4% |
| bs=10 sw=10 sl=64 | MB/s | 0.227 MB/s | 0.277 MB/s | 0.546 MB/s | -18.1% | -58.4% |
| bs=10 sw=10 sl=64 | p50 | 27,038 us | 22,111 us | 11,164 us | +22.3% | +142.2% |
| bs=10 sw=10 sl=64 | p95 | 37,265 us | 34,458 us | 14,219 us | +8.1% | +162.1% |
| bs=10 sw=10 sl=64 | p99 | 37,265 us | 34,458 us | 16,863 us | +8.1% | +121.0% |
| bs=100 sw=10 sl=64 | throughput | 920 tuples/sec | 965 tuples/sec | 1,158 tuples/sec | -4.7% | -20.6% |
| bs=100 sw=10 sl=64 | MB/s | 0.562 MB/s | 0.589 MB/s | 0.707 MB/s | -4.6% | -20.5% |
| bs=100 sw=10 sl=64 | p50 | 105,525 us | 102,450 us | 88,711 us | +3.0% | +19.0% |
| bs=100 sw=10 sl=64 | p95 | 157,258 us | 125,031 us | 95,062 us | +25.8% | +65.4% |
| bs=100 sw=10 sl=64 | p99 | 157,258 us | 125,031 us | 102,275 us | +25.8% | +53.8% |
| bs=1000 sw=10 sl=64 | throughput | 1,107 tuples/sec | 1,112 tuples/sec | 1,188 tuples/sec | -0.4% | -6.8% |
| bs=1000 sw=10 sl=64 | MB/s | 0.676 MB/s | 0.679 MB/s | 0.725 MB/s | -0.4% | -6.8% |
| bs=1000 sw=10 sl=64 | p50 | 902,525 us | 890,780 us | 874,204 us | +1.3% | +3.2% |
| bs=1000 sw=10 sl=64 | p95 | 1,030,128 us | 970,467 us | 916,845 us | +6.1% | +12.4% |
| bs=1000 sw=10 sl=64 | p99 | 1,030,128 us | 970,467 us | 947,186 us | +6.1% | +8.8% |
</details>
<details><summary>Raw CSV</summary>
```csv
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,537.43,200,128000,372,0.227,27037.82,37264.52,37264.52
1,100,10,64,20,2173.61,2000,1280000,920,0.562,105524.86,157257.91,157257.91
2,1000,10,64,20,18060.42,20000,12800000,1107,0.676,902524.82,1030128.11,1030128.11
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org