[GitHub] [spark] amaliujia commented on a diff in pull request #38409: [SPARK-40930][CONNECT] Support Collect() in Python client

[GitBox <gi...@apache.org>]

amaliujia commented on code in PR #38409:
URL: https://github.com/apache/spark/pull/38409#discussion_r1010931805


##########
python/pyspark/sql/connect/dataframe.py:
##########
@@ -305,8 +308,12 @@ def _print_plan(self) -> str:
             return self._plan.print()
         return ""
 
-    def collect(self) -> None:
-        raise NotImplementedError("Please use toPandas().")
+    def collect(self) -> List[Row]:
+        pdf = self.toPandas()
+        if pdf is not None:
+            return list(pdf.apply(lambda fun: Row(*fun), axis=1))

Review Comment:
   Done. I found magic is to use `**` so that each lambda row will become `kwargs`. 
   
   Honestly I don't understand this magic but it is working at least.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org