You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2017/01/10 02:47:05 UTC

Re: Review Request 54590: Removed unused `peek` function.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54590/
-----------------------------------------------------------

(Updated Jan. 9, 2017, 6:47 p.m.)


Review request for mesos, Daniel Pravat and Joris Van Remoortere.


Changes
-------

Rebased.


Repository: mesos


Description (updated)
-------

See summary.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/io.hpp f5489dc66adb136d9f53f98ac64c3fbe7831a1c2 
  3rdparty/libprocess/src/io.cpp 8aa3576a11ed5e998492b4020cb37a45ec708093 
  3rdparty/libprocess/src/tests/io_tests.cpp 466e343e6d775fe09debce119eae4fc4849b7006 

Diff: https://reviews.apache.org/r/54590/diff/


Testing
-------


Thanks,

Michael Park

Re: Review Request 54590: Removed unused peek function.

Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54590/
-----------------------------------------------------------

(Updated Jan. 10, 2017, 5:22 p.m.)


Review request for mesos, Daniel Pravat and Joris Van Remoortere.


Changes
-------

Updated description.


Summary (updated)
-----------------

Removed unused peek function.


Repository: mesos


Description (updated)
-------

This essentially reverts the introduction of `peek` function from
0d87ec198b6f15d4e7025f82b7b9385175a10d4a. We can certainly re-introduce
it in the future, but as of now it has been sitting there for over
a year and we have no uses of it.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/io.hpp f5489dc66adb136d9f53f98ac64c3fbe7831a1c2 
  3rdparty/libprocess/src/io.cpp 8aa3576a11ed5e998492b4020cb37a45ec708093 
  3rdparty/libprocess/src/tests/io_tests.cpp 466e343e6d775fe09debce119eae4fc4849b7006 

Diff: https://reviews.apache.org/r/54590/diff/


Testing
-------


Thanks,

Michael Park

Re: Review Request 54590: Removed unused `peek` function.

Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54590/#review161164
-----------------------------------------------------------


Ship it!




LGTM.

I'd mention the original review in the commit description to make tracking the history easier:
https://reviews.apache.org/r/36404/

- Joseph Wu


On Jan. 9, 2017, 6:47 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54590/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2017, 6:47 p.m.)
> 
> 
> Review request for mesos, Daniel Pravat and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/io.hpp f5489dc66adb136d9f53f98ac64c3fbe7831a1c2 
>   3rdparty/libprocess/src/io.cpp 8aa3576a11ed5e998492b4020cb37a45ec708093 
>   3rdparty/libprocess/src/tests/io_tests.cpp 466e343e6d775fe09debce119eae4fc4849b7006 
> 
> Diff: https://reviews.apache.org/r/54590/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>