You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/05 04:51:52 UTC

[GitHub] [spark] LuciferYang commented on a change in pull request #30251: [SPARK-33347][CORE]Cleanup useless variables to simplify the definition of ApplicationInfo

LuciferYang commented on a change in pull request #30251:
URL: https://github.com/apache/spark/pull/30251#discussion_r517791307



##########
File path: core/src/test/scala/org/apache/spark/deploy/history/ApplicationCacheSuite.scala
##########
@@ -128,8 +128,8 @@ class ApplicationCacheSuite extends SparkFunSuite with Logging with MockitoSugar
       completed: Boolean,
       started: Long,
       ended: Long): SparkUI = {
-    val info = new ApplicationInfo(name, name, Some(1), Some(1), Some(1), Some(64),

Review comment:
       It seems that only the parameter pass to the constructor in this test case is not `None`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org