You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/07/04 13:37:03 UTC
[GitHub] [rocketmq] RongtongJin opened a new pull request, #4554: Fix bug that return IN_SYNC_REPLICAS_NOT_ENOUGH when enableSlaveActingMaster is false
RongtongJin opened a new pull request, #4554:
URL: https://github.com/apache/rocketmq/pull/4554
…alse
**Make sure set the target branch to `develop`**
## What is the purpose of the change
XXXXX
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] ShannonDing merged pull request #4554: Fix bug that return IN_SYNC_REPLICAS_NOT_ENOUGH when enableSlaveActingMaster is false
Posted by GitBox <gi...@apache.org>.
ShannonDing merged PR #4554:
URL: https://github.com/apache/rocketmq/pull/4554
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #4554: Fix bug that return IN_SYNC_REPLICAS_NOT_ENOUGH when enableSlaveActingMaster is false
Posted by GitBox <gi...@apache.org>.
coveralls commented on PR #4554:
URL: https://github.com/apache/rocketmq/pull/4554#issuecomment-1174513552
[](https://coveralls.io/builds/50586294)
Coverage increased (+0.05%) to 47.187% when pulling **5c78bea261f383ad9052489432d97f088f8b4149 on RongtongJin:fix-bug-in-5.0.0-beta** into **52d1c8cca1b676fd81ba147af2c4f1e2131dbfd3 on apache:5.0.0-beta**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] guyinyou commented on pull request #4554: Fix bug that return IN_SYNC_REPLICAS_NOT_ENOUGH when enableSlaveActingMaster is false
Posted by GitBox <gi...@apache.org>.
guyinyou commented on PR #4554:
URL: https://github.com/apache/rocketmq/pull/4554#issuecomment-1174526126
Before the change, there will be a situation where the message cannot be sent in the master-slave mode. I hope it can be merged as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org