You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jonahgao (via GitHub)" <gi...@apache.org> on 2024/02/19 08:52:02 UTC
[PR] Minor: fix warning of 'Unnecessary braces in use statement' [arrow-datafusion]
jonahgao opened a new pull request, #9271:
URL: https://github.com/apache/arrow-datafusion/pull/9271
## Which issue does this PR close?
N/A
## Rationale for this change
Reported by rust-analyzer diagnostics.
## What changes are included in this PR?
## Are these changes tested?
Yes
## Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Minor: fix warning of 'Unnecessary braces in use statement' [arrow-datafusion]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on PR #9271:
URL: https://github.com/apache/arrow-datafusion/pull/9271#issuecomment-1953073260
> Nice cleanup 👍
>
> Interesting that `cargo fmt` didn't catch this 🤔
I have the same question.....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Minor: fix warning of 'Unnecessary braces in use statement' [arrow-datafusion]
Posted by "jonahgao (via GitHub)" <gi...@apache.org>.
jonahgao commented on PR #9271:
URL: https://github.com/apache/arrow-datafusion/pull/9271#issuecomment-1952502529
> Nice cleanup 👍
>
> Interesting that `cargo fmt` didn't catch this 🤔
It seems that cargo-fmt has not covered these files, which might be related to creating modules within macros. I need to investigate it further.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Minor: fix warning of 'Unnecessary braces in use statement' [arrow-datafusion]
Posted by "jonahgao (via GitHub)" <gi...@apache.org>.
jonahgao commented on PR #9271:
URL: https://github.com/apache/arrow-datafusion/pull/9271#issuecomment-1953428097
> > Nice cleanup 👍
> > Interesting that `cargo fmt` didn't catch this 🤔
>
> I have the same question.....
Filled a new issue #9281.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Minor: fix warning of 'Unnecessary braces in use statement' [arrow-datafusion]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead merged PR #9271:
URL: https://github.com/apache/arrow-datafusion/pull/9271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org