You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/10/11 22:23:23 UTC

[GitHub] [airflow] ashb commented on a change in pull request #6288: AIRFLOW-5540 adding rise exception when the _resolve_connection method fails

ashb commented on a change in pull request #6288: AIRFLOW-5540 adding rise exception when the _resolve_connection  method fails
URL: https://github.com/apache/airflow/pull/6288#discussion_r334192786
 
 

 ##########
 File path: airflow/contrib/hooks/spark_submit_hook.py
 ##########
 @@ -200,6 +201,10 @@ def _resolve_connection(self):
                 self._conn_id, conn_data['master']
             )
 
+            raise AirflowException("Could not load connection string %s, defaulting to %s",
 
 Review comment:
   This message doesn't seem to match the behavoiur. It says "defaulting" but it's raising an error, so it can't continue.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services