You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Jean-Luc Rochat <jn...@cybercable.fr> on 2000/03/25 00:06:00 UTC
RFV: using the latest ajpv12 version.
Hi developpers,
The version of ajpv12 used here in Tomcat is not the version used in
JServ 1.1 final.
This is the main cause of incompatibility between mod_jserv compiled
from JServ source code and the one obtained from Tomcat.
I do propose this :
- use in Tomcat the latest version of ajpv12. (ie: 2 fields are added to
the protocol).
This impacts the java code (I do have here a patch), plus the
iis/netscape connector (2 lines).
At the same time there is a need for enhancing this existing protocol to
add dynamically environment variables. This impacts only the java side
for the moment, and will permit JServ improvments. This can be done
easily (too bad I didn't see this before) using a new type of packet,
without breaking anything, and without ANY overhead if unused.
So I do propose a patch here, that should allow us to do the job, and
merge the 2 worlds.
NB: the environment variables are left unused by Tomcat for the moment.
Jean-Luc
Waiting for votes to commit. (or not ;-)
[jak@r26m24]$ cvs diff Ajp12ConnectionHandler.java
Index: Ajp12ConnectionHandler.java
===================================================================
RCS file:
/home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/service/connector/Ajp12ConnectionHandler.java,v
retrieving revision 1.17
diff -r1.17 Ajp12ConnectionHandler.java
193a194,195
> // Hashtable env_vars=new Hashtable();
>
291a294,295
> * JServ 1.1 is far behind now.
> * - jluc
293,294c297,298
< // dummy =
ajpin.readString(""); //SSL_CLIENT_DN
< // dummy =
ajpin.readString(""); //SSL_CLIENT_IDN
---
> dummy = ajpin.readString(""); //SSL_CLIENT_DN
> dummy = ajpin.readString(""); //SSL_CLIENT_IDN
297a302,315
> break;
>
>
> /**
> * Marker = 5 will be used by JServ to send environment vars
> * as key+value.
> * can be considered as "reserved"
> * env_vars is (above in this code) commented out for performance issues.
> * - jluc
> */
> case 5: // Environment vars
> token1 = ajpin.readString(null);
> token2 = ajpin.readString("");
> // env_vars.put(token1, token2);
[jak@r26m24]$
Re: RFV: using the latest ajpv12 version.
Posted by Costin Manolache <co...@eng.sun.com>.
+1
Jean-Luc Rochat wrote:
> Hi developpers,
>
> The version of ajpv12 used here in Tomcat is not the version used in
> JServ 1.1 final.
> This is the main cause of incompatibility between mod_jserv compiled
> from JServ source code and the one obtained from Tomcat.
> I do propose this :
> - use in Tomcat the latest version of ajpv12. (ie: 2 fields are added to
> the protocol).
> This impacts the java code (I do have here a patch), plus the
> iis/netscape connector (2 lines).
>
> At the same time there is a need for enhancing this existing protocol to
> add dynamically environment variables. This impacts only the java side
> for the moment, and will permit JServ improvments. This can be done
> easily (too bad I didn't see this before) using a new type of packet,
> without breaking anything, and without ANY overhead if unused.
>
> So I do propose a patch here, that should allow us to do the job, and
> merge the 2 worlds.
> NB: the environment variables are left unused by Tomcat for the moment.
>
> Jean-Luc
>
> Waiting for votes to commit. (or not ;-)
>
> [jak@r26m24]$ cvs diff Ajp12ConnectionHandler.java
> Index: Ajp12ConnectionHandler.java
> ===================================================================
> RCS file:
> /home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/service/connector/Ajp12ConnectionHandler.java,v
> retrieving revision 1.17
> diff -r1.17 Ajp12ConnectionHandler.java
> 193a194,195
> > // Hashtable env_vars=new Hashtable();
> >
> 291a294,295
> > * JServ 1.1 is far behind now.
> > * - jluc
> 293,294c297,298
> < // dummy =
> ajpin.readString(""); //SSL_CLIENT_DN
> < // dummy =
> ajpin.readString(""); //SSL_CLIENT_IDN
> ---
> > dummy = ajpin.readString(""); //SSL_CLIENT_DN
> > dummy = ajpin.readString(""); //SSL_CLIENT_IDN
> 297a302,315
> > break;
> >
> >
> > /**
> > * Marker = 5 will be used by JServ to send environment vars
> > * as key+value.
> > * can be considered as "reserved"
> > * env_vars is (above in this code) commented out for performance issues.
> > * - jluc
> > */
> > case 5: // Environment vars
> > token1 = ajpin.readString(null);
> > token2 = ajpin.readString("");
> > // env_vars.put(token1, token2);
> [jak@r26m24]$
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
Re: RFV: using the latest ajpv12 version.
Posted by "Craig R. McClanahan" <Cr...@eng.sun.com>.
+1
Craig McClanahan