You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/12 10:26:48 UTC

[GitHub] [pulsar] RobertIndie opened a new pull request, #17079: [improve][c++] Add producerId to the log of closed producer

RobertIndie opened a new pull request, #17079:
URL: https://github.com/apache/pulsar/pull/17079

   <!--
   ### Contribution Checklist
     
     - PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.trs9rsex3xom)*. 
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ### Motivation
   
   When I investigate the c++ flaky tests, there is no producer id in the log of `closed producer`.
   Need to add the producer id like that in the consumer:
   https://github.com/apache/pulsar/blob/bc68f02a4060ef0042a50c2b1d834c6ab84cfd13/pulsar-client-cpp/lib/ConsumerImpl.cc#L1064
   
   ### Modifications
   
   * Add producerId to the log of closed producer.
   
   
   ### Documentation
   
   Check the box below or label this PR directly.
   
   Need to update docs? 
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
     
   - [x] `doc-not-needed` 
   (Please explain why)
     
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] codelipenghui merged pull request #17079: [improve][c++] Add producerId to the log of closed producer

Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #17079:
URL: https://github.com/apache/pulsar/pull/17079


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] HQebupt commented on pull request #17079: [improve][c++] Add producerId to the log of closed producer

Posted by GitBox <gi...@apache.org>.
HQebupt commented on PR #17079:
URL: https://github.com/apache/pulsar/pull/17079#issuecomment-1213172437

   Good catch 👍 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org