[arrow] branch master updated: PARQUET-1458: [C++] parquet::CompressionToString not recognizing brotli compression

[we...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

wesm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/master by this push:
     new 736b5b0  PARQUET-1458: [C++] parquet::CompressionToString not recognizing brotli compression
736b5b0 is described below

commit 736b5b04bb5b1c1950838ada7a681720f64d9816
Author: Hatem Helal <ha...@gmail.com>
AuthorDate: Wed Nov 14 19:25:10 2018 -0500

    PARQUET-1458: [C++] parquet::CompressionToString not recognizing brotli compression
    
    Author: Hatem Helal <ha...@gmail.com>
    
    Closes #2963 from hatemhelal/parquet_1458_stable and squashes the following commits:
    
    265c07d56 <Hatem Helal> parquet::CompressionToString not recognizing Brotli codec
---
 cpp/src/parquet/types-test.cc | 10 ++++++++++
 cpp/src/parquet/types.cc      |  2 ++
 2 files changed, 12 insertions(+)

diff --git a/cpp/src/parquet/types-test.cc b/cpp/src/parquet/types-test.cc
index 6fb0066..6d1e9bd 100644
--- a/cpp/src/parquet/types-test.cc
+++ b/cpp/src/parquet/types-test.cc
@@ -61,6 +61,16 @@ TEST(TestLogicalTypeToString, LogicalTypes) {
   ASSERT_STREQ("INTERVAL", LogicalTypeToString(LogicalType::INTERVAL).c_str());
 }
 
+TEST(TestCompressionToString, Compression) {
+  ASSERT_STREQ("UNCOMPRESSED", CompressionToString(Compression::UNCOMPRESSED).c_str());
+  ASSERT_STREQ("SNAPPY", CompressionToString(Compression::SNAPPY).c_str());
+  ASSERT_STREQ("GZIP", CompressionToString(Compression::GZIP).c_str());
+  ASSERT_STREQ("LZO", CompressionToString(Compression::LZO).c_str());
+  ASSERT_STREQ("BROTLI", CompressionToString(Compression::BROTLI).c_str());
+  ASSERT_STREQ("LZ4", CompressionToString(Compression::LZ4).c_str());
+  ASSERT_STREQ("ZSTD", CompressionToString(Compression::ZSTD).c_str());
+}
+
 #if !(defined(_WIN32) || defined(__CYGWIN__))
 #pragma GCC diagnostic push
 #pragma GCC diagnostic ignored "-Wdeprecated-declarations"
diff --git a/cpp/src/parquet/types.cc b/cpp/src/parquet/types.cc
index 3120963..f1ce665 100644
--- a/cpp/src/parquet/types.cc
+++ b/cpp/src/parquet/types.cc
@@ -129,6 +129,8 @@ std::string CompressionToString(Compression::type t) {
       return "GZIP";
     case Compression::LZO:
       return "LZO";
+    case Compression::BROTLI:
+      return "BROTLI";
     case Compression::LZ4:
       return "LZ4";
     case Compression::ZSTD: