You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Velmurugan Periasamy <vp...@hortonworks.com> on 2017/07/10 06:13:51 UTC
Re: Review Request 60385: Ranger KMS should validate key name before
importing into DB
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60385/#review180007
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On June 23, 2017, 6:19 a.m., Ankita Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60385/
> -----------------------------------------------------------
>
> (Updated June 23, 2017, 6:19 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1639
> https://issues.apache.org/jira/browse/RANGER-1639
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Actual :
> Ranger KMS does not validate key name before importing into DB. So the imported key can have special characters in Key name.
>
> Expected :
> Ranger KMS should validate key name before importing into DB.
>
>
> Diffs
> -----
>
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java a001c08
> kms/src/test/java/org/apache/hadoop/crypto/key/kms/TestRangerKeyStore.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/60385/diff/1/
>
>
> Testing
> -------
>
> Below steps were followed to test this scenario
>
> 1. Installed Hadoop KMS
> 2. Created encryption keys with combination of special characters, alphabets and numbers
> 3. Installed Ranger KMS
> 4. imported hadoop key jceks to Ranger KMS (Validation was successful)
>
>
> Thanks,
>
> Ankita Sinha
>
>