You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Tino Truppel (JIRA)" <ji...@apache.org> on 2015/08/04 09:25:05 UTC
[jira] [Issue Comment Deleted] (OAK-3146)
ExternalLoginModuleFactory should inject SyncManager and
ExternalIdentityProviderManager
[ https://issues.apache.org/jira/browse/OAK-3146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tino Truppel updated OAK-3146:
------------------------------
Comment: was deleted
(was: Hi -
Is there any chance to get this back ported to 1.0.18? Thx)
> ExternalLoginModuleFactory should inject SyncManager and ExternalIdentityProviderManager
> ----------------------------------------------------------------------------------------
>
> Key: OAK-3146
> URL: https://issues.apache.org/jira/browse/OAK-3146
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: security
> Reporter: Chetan Mehrotra
> Priority: Minor
> Labels: performance
> Fix For: 1.3.5
>
> Attachments: OAK-3146.patch
>
>
> {{ExternalLoginModule}} currently performs a lookup of {{SyncManager}} and {{ExternalIdentityProviderManager}} in initialize call which performs service lookup using ServiceTracker. Doing a service lookup in critical path would have adverse performance impact.
> Instead of performing the lookup {{ExternalLoginModuleFactory}} should track the two manager instances and pass them to {{ExternalLoginModule}}. This would ensure that expensive operation like service lookup is not performed in critical path
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)