questions about test framework

[Brian Denny <br...@briandenny.net>]

i am trying to write some tests for Issue 870.

basically i need to:
- add an executable file, and check that the svn:executable
  property was set;
- import an executable file and check the same thing.


i have two different ideas about where these tests should live.

1. in prop_tests.py, since they do after all deal with properties
2. in schedule_tests.py and commit_tests.py, since they deal with
   adding and importing respectively.

opinions on this?


-brian



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: questions about test framework

[Branko Čibej <br...@xbc.nu>]

Brian Denny wrote:

>i am trying to write some tests for Issue 870.
>
>basically i need to:
>- add an executable file, and check that the svn:executable
>  property was set;
>- import an executable file and check the same thing.
>
>
>i have two different ideas about where these tests should live.
>
>1. in prop_tests.py, since they do after all deal with properties
>2. in schedule_tests.py and commit_tests.py, since they deal with
>   adding and importing respectively.
>
>opinions on this?
>  
>
Well, first of all, those will have to be platform-specific tests. We 
don't have any of those yet. The funny thing is, we don't seem to have 
import tests, either, except the ones implicit in every test when the 
greek tre is created.

What do you say to this: For the import case, you can modify 
main.greek_state to contain an executable file (e.g., iota), and add a 
test to basic_tests.py (basic_check_executable?) that checks if the 
svn:executable prop is set. For the add case, the test should go into 
schedule_tests.py.

Both of these tests should be skipped on anything but Unix.

-- 
Brane Čibej   <br...@xbc.nu>   http://www.xbc.nu/brane/


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org