[GitHub] [spark] cloud-fan commented on a change in pull request #34041: [SPARK-36799][SQL] Pass queryExecution name in CLI when only select query

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #34041:
URL: https://github.com/apache/spark/pull/34041#discussion_r736285439



##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLDriver.scala
##########
@@ -65,7 +65,11 @@ private[hive] class SparkSQLDriver(val context: SQLContext = SparkSQLEnv.sqlCont
       }
       context.sparkContext.setJobDescription(substitutorCommand)
       val execution = context.sessionState.executePlan(context.sql(command).logicalPlan)
-      hiveResponse = SQLExecution.withNewExecutionId(execution) {
+      val queryExecutionName = execution.executedPlan match {
+        case _: CommandResultExec => None
+        case _ => Some("collect")
+      }
+      hiveResponse = SQLExecution.withNewExecutionId(execution, queryExecutionName) {

Review comment:
       why does the name matter? I checked `SQLExecution.withNewExecutionId`, the name is just a property.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org