You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Chris Douglas (JIRA)" <ji...@apache.org> on 2008/04/03 23:53:24 UTC

[jira] Created: (HADOOP-3166) SpillThread throws ArrayIndexOutOfBoundsException, which is ignored by MapTask

SpillThread throws ArrayIndexOutOfBoundsException, which is ignored by MapTask
------------------------------------------------------------------------------

                 Key: HADOOP-3166
                 URL: https://issues.apache.org/jira/browse/HADOOP-3166
             Project: Hadoop Core
          Issue Type: Bug
            Reporter: Chris Douglas
            Assignee: Chris Douglas
            Priority: Blocker
             Fix For: 0.17.0
         Attachments: 3166-0.patch

There is a flaw in the value bounds checking introduced by HADOOP-2919. When the index table determines the end offset of the value, it fails to detect that the next entry falls off the end of the array. This remains undetected by MapTask, which only notes IOExceptions from the spill thread. Both the boundary checking and the exception handling must be fixed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3166) SpillThread throws ArrayIndexOutOfBoundsException, which is ignored by MapTask

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-3166:
----------------------------------

    Attachment: 3166-1.patch

Catching Throwable instead of Exception, per Koji's recommendation.

> SpillThread throws ArrayIndexOutOfBoundsException, which is ignored by MapTask
> ------------------------------------------------------------------------------
>
>                 Key: HADOOP-3166
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3166
>             Project: Hadoop Core
>          Issue Type: Bug
>            Reporter: Chris Douglas
>            Assignee: Chris Douglas
>            Priority: Blocker
>             Fix For: 0.17.0
>
>         Attachments: 3166-0.patch, 3166-0.patch, 3166-1.patch
>
>
> There is a flaw in the value bounds checking introduced by HADOOP-2919. When the index table determines the end offset of the value, it fails to detect that the next entry falls off the end of the array. This remains undetected by MapTask, which only notes IOExceptions from the spill thread. Both the boundary checking and the exception handling must be fixed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3166) SpillThread throws ArrayIndexOutOfBoundsException, which is ignored by MapTask

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-3166:
----------------------------------

    Status: Patch Available  (was: Open)

> SpillThread throws ArrayIndexOutOfBoundsException, which is ignored by MapTask
> ------------------------------------------------------------------------------
>
>                 Key: HADOOP-3166
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3166
>             Project: Hadoop Core
>          Issue Type: Bug
>            Reporter: Chris Douglas
>            Assignee: Chris Douglas
>            Priority: Blocker
>             Fix For: 0.17.0
>
>         Attachments: 3166-0.patch, 3166-0.patch, 3166-1.patch
>
>
> There is a flaw in the value bounds checking introduced by HADOOP-2919. When the index table determines the end offset of the value, it fails to detect that the next entry falls off the end of the array. This remains undetected by MapTask, which only notes IOExceptions from the spill thread. Both the boundary checking and the exception handling must be fixed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3166) SpillThread throws ArrayIndexOutOfBoundsException, which is ignored by MapTask

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-3166:
----------------------------------

    Status: Open  (was: Patch Available)

> SpillThread throws ArrayIndexOutOfBoundsException, which is ignored by MapTask
> ------------------------------------------------------------------------------
>
>                 Key: HADOOP-3166
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3166
>             Project: Hadoop Core
>          Issue Type: Bug
>            Reporter: Chris Douglas
>            Assignee: Chris Douglas
>            Priority: Blocker
>             Fix For: 0.17.0
>
>         Attachments: 3166-0.patch, 3166-0.patch, 3166-1.patch
>
>
> There is a flaw in the value bounds checking introduced by HADOOP-2919. When the index table determines the end offset of the value, it fails to detect that the next entry falls off the end of the array. This remains undetected by MapTask, which only notes IOExceptions from the spill thread. Both the boundary checking and the exception handling must be fixed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3166) SpillThread throws ArrayIndexOutOfBoundsException, which is ignored by MapTask

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12585965#action_12585965 ] 

Hudson commented on HADOOP-3166:
--------------------------------

Integrated in Hadoop-trunk #451 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/451/])

> SpillThread throws ArrayIndexOutOfBoundsException, which is ignored by MapTask
> ------------------------------------------------------------------------------
>
>                 Key: HADOOP-3166
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3166
>             Project: Hadoop Core
>          Issue Type: Bug
>            Reporter: Chris Douglas
>            Assignee: Chris Douglas
>            Priority: Blocker
>             Fix For: 0.17.0
>
>         Attachments: 3166-0.patch, 3166-0.patch, 3166-1.patch
>
>
> There is a flaw in the value bounds checking introduced by HADOOP-2919. When the index table determines the end offset of the value, it fails to detect that the next entry falls off the end of the array. This remains undetected by MapTask, which only notes IOExceptions from the spill thread. Both the boundary checking and the exception handling must be fixed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3166) SpillThread throws ArrayIndexOutOfBoundsException, which is ignored by MapTask

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-3166:
----------------------------------

    Attachment: 3166-0.patch

> SpillThread throws ArrayIndexOutOfBoundsException, which is ignored by MapTask
> ------------------------------------------------------------------------------
>
>                 Key: HADOOP-3166
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3166
>             Project: Hadoop Core
>          Issue Type: Bug
>            Reporter: Chris Douglas
>            Assignee: Chris Douglas
>            Priority: Blocker
>             Fix For: 0.17.0
>
>         Attachments: 3166-0.patch
>
>
> There is a flaw in the value bounds checking introduced by HADOOP-2919. When the index table determines the end offset of the value, it fails to detect that the next entry falls off the end of the array. This remains undetected by MapTask, which only notes IOExceptions from the spill thread. Both the boundary checking and the exception handling must be fixed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3166) SpillThread throws ArrayIndexOutOfBoundsException, which is ignored by MapTask

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-3166:
----------------------------------

    Status: Patch Available  (was: Open)

> SpillThread throws ArrayIndexOutOfBoundsException, which is ignored by MapTask
> ------------------------------------------------------------------------------
>
>                 Key: HADOOP-3166
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3166
>             Project: Hadoop Core
>          Issue Type: Bug
>            Reporter: Chris Douglas
>            Assignee: Chris Douglas
>            Priority: Blocker
>             Fix For: 0.17.0
>
>         Attachments: 3166-0.patch
>
>
> There is a flaw in the value bounds checking introduced by HADOOP-2919. When the index table determines the end offset of the value, it fails to detect that the next entry falls off the end of the array. This remains undetected by MapTask, which only notes IOExceptions from the spill thread. Both the boundary checking and the exception handling must be fixed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3166) SpillThread throws ArrayIndexOutOfBoundsException, which is ignored by MapTask

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-3166:
----------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I just committed this.

> SpillThread throws ArrayIndexOutOfBoundsException, which is ignored by MapTask
> ------------------------------------------------------------------------------
>
>                 Key: HADOOP-3166
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3166
>             Project: Hadoop Core
>          Issue Type: Bug
>            Reporter: Chris Douglas
>            Assignee: Chris Douglas
>            Priority: Blocker
>             Fix For: 0.17.0
>
>         Attachments: 3166-0.patch, 3166-0.patch, 3166-1.patch
>
>
> There is a flaw in the value bounds checking introduced by HADOOP-2919. When the index table determines the end offset of the value, it fails to detect that the next entry falls off the end of the array. This remains undetected by MapTask, which only notes IOExceptions from the spill thread. Both the boundary checking and the exception handling must be fixed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3166) SpillThread throws ArrayIndexOutOfBoundsException, which is ignored by MapTask

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12585419#action_12585419 ] 

Hadoop QA commented on HADOOP-3166:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12379327/3166-1.patch
against trunk revision 643282.

    @author +1.  The patch does not contain any @author tags.

    tests included -1.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new javac compiler warnings.

    release audit +1.  The applied patch does not generate any new release audit warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests +1.  The patch passed core unit tests.

    contrib tests +1.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2153/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2153/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2153/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2153/console

This message is automatically generated.

> SpillThread throws ArrayIndexOutOfBoundsException, which is ignored by MapTask
> ------------------------------------------------------------------------------
>
>                 Key: HADOOP-3166
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3166
>             Project: Hadoop Core
>          Issue Type: Bug
>            Reporter: Chris Douglas
>            Assignee: Chris Douglas
>            Priority: Blocker
>             Fix For: 0.17.0
>
>         Attachments: 3166-0.patch, 3166-0.patch, 3166-1.patch
>
>
> There is a flaw in the value bounds checking introduced by HADOOP-2919. When the index table determines the end offset of the value, it fails to detect that the next entry falls off the end of the array. This remains undetected by MapTask, which only notes IOExceptions from the spill thread. Both the boundary checking and the exception handling must be fixed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3166) SpillThread throws ArrayIndexOutOfBoundsException, which is ignored by MapTask

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley updated HADOOP-3166:
----------------------------------

    Hadoop Flags: [Reviewed]

+1

> SpillThread throws ArrayIndexOutOfBoundsException, which is ignored by MapTask
> ------------------------------------------------------------------------------
>
>                 Key: HADOOP-3166
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3166
>             Project: Hadoop Core
>          Issue Type: Bug
>            Reporter: Chris Douglas
>            Assignee: Chris Douglas
>            Priority: Blocker
>             Fix For: 0.17.0
>
>         Attachments: 3166-0.patch, 3166-0.patch, 3166-1.patch
>
>
> There is a flaw in the value bounds checking introduced by HADOOP-2919. When the index table determines the end offset of the value, it fails to detect that the next entry falls off the end of the array. This remains undetected by MapTask, which only notes IOExceptions from the spill thread. Both the boundary checking and the exception handling must be fixed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3166) SpillThread throws ArrayIndexOutOfBoundsException, which is ignored by MapTask

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12585306#action_12585306 ] 

Owen O'Malley commented on HADOOP-3166:
---------------------------------------

Please add a string to the IOException.

> SpillThread throws ArrayIndexOutOfBoundsException, which is ignored by MapTask
> ------------------------------------------------------------------------------
>
>                 Key: HADOOP-3166
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3166
>             Project: Hadoop Core
>          Issue Type: Bug
>            Reporter: Chris Douglas
>            Assignee: Chris Douglas
>            Priority: Blocker
>             Fix For: 0.17.0
>
>         Attachments: 3166-0.patch
>
>
> There is a flaw in the value bounds checking introduced by HADOOP-2919. When the index table determines the end offset of the value, it fails to detect that the next entry falls off the end of the array. This remains undetected by MapTask, which only notes IOExceptions from the spill thread. Both the boundary checking and the exception handling must be fixed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3166) SpillThread throws ArrayIndexOutOfBoundsException, which is ignored by MapTask

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-3166:
----------------------------------

    Status: Patch Available  (was: Open)

> SpillThread throws ArrayIndexOutOfBoundsException, which is ignored by MapTask
> ------------------------------------------------------------------------------
>
>                 Key: HADOOP-3166
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3166
>             Project: Hadoop Core
>          Issue Type: Bug
>            Reporter: Chris Douglas
>            Assignee: Chris Douglas
>            Priority: Blocker
>             Fix For: 0.17.0
>
>         Attachments: 3166-0.patch, 3166-0.patch
>
>
> There is a flaw in the value bounds checking introduced by HADOOP-2919. When the index table determines the end offset of the value, it fails to detect that the next entry falls off the end of the array. This remains undetected by MapTask, which only notes IOExceptions from the spill thread. Both the boundary checking and the exception handling must be fixed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3166) SpillThread throws ArrayIndexOutOfBoundsException, which is ignored by MapTask

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-3166:
----------------------------------

    Attachment: 3166-0.patch

Added a note for the exception

> SpillThread throws ArrayIndexOutOfBoundsException, which is ignored by MapTask
> ------------------------------------------------------------------------------
>
>                 Key: HADOOP-3166
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3166
>             Project: Hadoop Core
>          Issue Type: Bug
>            Reporter: Chris Douglas
>            Assignee: Chris Douglas
>            Priority: Blocker
>             Fix For: 0.17.0
>
>         Attachments: 3166-0.patch, 3166-0.patch
>
>
> There is a flaw in the value bounds checking introduced by HADOOP-2919. When the index table determines the end offset of the value, it fails to detect that the next entry falls off the end of the array. This remains undetected by MapTask, which only notes IOExceptions from the spill thread. Both the boundary checking and the exception handling must be fixed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3166) SpillThread throws ArrayIndexOutOfBoundsException, which is ignored by MapTask

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-3166:
----------------------------------

    Status: Open  (was: Patch Available)

> SpillThread throws ArrayIndexOutOfBoundsException, which is ignored by MapTask
> ------------------------------------------------------------------------------
>
>                 Key: HADOOP-3166
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3166
>             Project: Hadoop Core
>          Issue Type: Bug
>            Reporter: Chris Douglas
>            Assignee: Chris Douglas
>            Priority: Blocker
>             Fix For: 0.17.0
>
>         Attachments: 3166-0.patch, 3166-0.patch
>
>
> There is a flaw in the value bounds checking introduced by HADOOP-2919. When the index table determines the end offset of the value, it fails to detect that the next entry falls off the end of the array. This remains undetected by MapTask, which only notes IOExceptions from the spill thread. Both the boundary checking and the exception handling must be fixed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.