You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by bo...@apache.org on 2017/03/31 21:17:35 UTC
geode git commit: GEODE-2638: Updated tests to not hardcode unknown
host name
Repository: geode
Updated Branches:
refs/heads/develop 1f07ec76d -> ac6937e99
GEODE-2638: Updated tests to not hardcode unknown host name
Project: http://git-wip-us.apache.org/repos/asf/geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/geode/commit/ac6937e9
Tree: http://git-wip-us.apache.org/repos/asf/geode/tree/ac6937e9
Diff: http://git-wip-us.apache.org/repos/asf/geode/diff/ac6937e9
Branch: refs/heads/develop
Commit: ac6937e99b6d839c4c4f1fe250ce4433eee7e53b
Parents: 1f07ec7
Author: Barry Oglesby <bo...@pivotal.io>
Authored: Fri Mar 31 14:02:10 2017 -0700
Committer: Barry Oglesby <bo...@pivotal.io>
Committed: Fri Mar 31 14:10:13 2017 -0700
----------------------------------------------------------------------
.../wan/misc/WanAutoDiscoveryDUnitTest.java | 25 ++++++++++++++++++--
1 file changed, 23 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/geode/blob/ac6937e9/geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/WanAutoDiscoveryDUnitTest.java
----------------------------------------------------------------------
diff --git a/geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/WanAutoDiscoveryDUnitTest.java b/geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/WanAutoDiscoveryDUnitTest.java
index 3e94697..42ddc48 100644
--- a/geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/WanAutoDiscoveryDUnitTest.java
+++ b/geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/WanAutoDiscoveryDUnitTest.java
@@ -26,7 +26,9 @@ import org.apache.geode.test.dunit.internal.JUnit4DistributedTestCase;
import org.apache.geode.test.junit.categories.DistributedTest;
import org.apache.geode.test.junit.categories.FlakyTest;
+import java.net.InetAddress;
import java.net.InetSocketAddress;
+import java.net.UnknownHostException;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.HashSet;
@@ -607,7 +609,7 @@ public class WanAutoDiscoveryDUnitTest extends WANTestBase {
.addIgnoredException("could not get remote locator information for remote site");
try {
Set<String> remoteLocators = new HashSet();
- remoteLocators.add("unknown[12345]");
+ addUnknownHost(remoteLocators);
testRemoteLocators(remoteLocators, false, 0);
} finally {
ie.remove();
@@ -618,10 +620,29 @@ public class WanAutoDiscoveryDUnitTest extends WANTestBase {
public void testValidAndInvalidHostRemoteLocators() {
Set<String> remoteLocators = new HashSet();
remoteLocators.add("localhost[12345]");
- remoteLocators.add("unknown[12345]");
+ addUnknownHost(remoteLocators);
testRemoteLocators(remoteLocators, true, 1);
}
+ private void addUnknownHost(Set<String> remoteLocators) {
+ String unknownHostName = "unknown";
+ boolean unknownHostFound = false;
+ int numTries = 10;
+ for (int i = 0; i < numTries; i++) {
+ try {
+ InetAddress.getByName(unknownHostName);
+ } catch (UnknownHostException e) {
+ unknownHostFound = true;
+ break;
+ }
+ unknownHostName = "_" + unknownHostName + "_";
+ }
+ assertTrue("An unknown host name could not be found in " + numTries + " tries",
+ unknownHostFound);
+
+ remoteLocators.add(unknownHostName + "[12345]");
+ }
+
private void testRemoteLocators(Set<String> remoteLocators, boolean poolShouldExist,
int expectedPoolLocatorsSize) {
// Start locator