You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2021/04/14 17:26:42 UTC

[Impala-ASF-CR] WIP IMPALA-7825: Upgrade Thrift version to 0.11.0

Csaba Ringhofer has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/17170 )

Change subject: WIP IMPALA-7825: Upgrade Thrift version to 0.11.0
......................................................................

WIP IMPALA-7825: Upgrade Thrift version to 0.11.0

Before this patch Impala mainly used Thrift 0.9.3, but it was
possible to compile Impala shell with Thrift 0.11.0, so the 0.11.0
Thrift lib was already included in toolchain.

Most of the changes are related to replacing boost:: with std::
shared_ptr-s in cpp code (this is a continuation of patch by Vihang).

The Thrift upgrade also needs an Impyla relase with Thrift 0.11.0, as
Impala's test framework relies on Impyla. A thrift_sasl release is also
needed, because it currently pins Thrift version to 0.9.3 for Python 2.

The current patch uses alpha releases from Impyla and thrift_sasl that
use thrift 0.11.0.

Testing:
- ran Impyla's test suite with Python 2 and 3

Other TODOs:
- remove preexisting extra logic needed to use 0.11.0 for python
- the thrift compilation was changed to generated template code -
  this was an easy solution to avoid a compilation issue after
  merging IMPALA-10600, but I should check its effect on compilation
  time

Change-Id: Idd13f177b4f7acc07872ea6399035aa180ef6ab6
---
M be/src/benchmarks/network-perf-benchmark.cc
M be/src/catalog/catalog-server.h
M be/src/catalog/catalog-service-client-wrapper.h
M be/src/catalog/catalogd-main.cc
M be/src/rpc/TAcceptQueueServer.cpp
M be/src/rpc/TAcceptQueueServer.h
M be/src/rpc/auth-provider.h
M be/src/rpc/authentication.cc
M be/src/rpc/hs2-http-test.cc
M be/src/rpc/thrift-client.h
M be/src/rpc/thrift-server-test.cc
M be/src/rpc/thrift-server.cc
M be/src/rpc/thrift-server.h
M be/src/rpc/thrift-thread.cc
M be/src/rpc/thrift-thread.h
M be/src/rpc/thrift-util.cc
M be/src/rpc/thrift-util.h
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M be/src/service/impalad-main.cc
M be/src/statestore/statestore-service-client-wrapper.h
M be/src/statestore/statestore-subscriber-client-wrapper.h
M be/src/statestore/statestore-subscriber.cc
M be/src/statestore/statestore-subscriber.h
M be/src/statestore/statestore.cc
M be/src/statestore/statestore.h
M be/src/testutil/in-process-servers.h
M be/src/transport/THttpServer.cpp
M be/src/transport/THttpServer.h
M be/src/transport/THttpTransport.cpp
M be/src/transport/THttpTransport.h
M be/src/transport/TSaslClientTransport.cpp
M be/src/transport/TSaslClientTransport.h
M be/src/transport/TSaslServerTransport.cpp
M be/src/transport/TSaslServerTransport.h
M be/src/transport/TSaslTransport.cpp
M be/src/transport/TSaslTransport.h
M be/src/util/parquet-reader.cc
M bin/impala-config.sh
M common/thrift/CMakeLists.txt
M infra/python/deps/requirements.txt
M java/pom.xml
M shell/ext-py/thrift_sasl-0.4.2/setup.py
43 files changed, 189 insertions(+), 190 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/17170/3
-- 
To view, visit http://gerrit.cloudera.org:8080/17170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd13f177b4f7acc07872ea6399035aa180ef6ab6
Gerrit-Change-Number: 17170
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>