You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by eb...@apache.org on 2013/12/13 08:43:38 UTC
svn commit: r1550661 - in
/commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/zip:
TestZipEncodings.java ZipEncodingTest.java
Author: ebourg
Date: Fri Dec 13 07:43:37 2013
New Revision: 1550661
URL: http://svn.apache.org/r1550661
Log:
Renamed TestZipEncodings to ZipEncodingTest for consistency
Added:
commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/zip/ZipEncodingTest.java
- copied, changed from r1548810, commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/zip/TestZipEncodings.java
Removed:
commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/zip/TestZipEncodings.java
Copied: commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/zip/ZipEncodingTest.java (from r1548810, commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/zip/TestZipEncodings.java)
URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/zip/ZipEncodingTest.java?p2=commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/zip/ZipEncodingTest.java&p1=commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/zip/TestZipEncodings.java&r1=1548810&r2=1550661&rev=1550661&view=diff
==============================================================================
--- commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/zip/TestZipEncodings.java (original)
+++ commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/zip/ZipEncodingTest.java Fri Dec 13 07:43:37 2013
@@ -29,7 +29,7 @@ import org.apache.commons.compress.utils
/**
* Test zip encodings.
*/
-public class TestZipEncodings extends TestCase {
+public class ZipEncodingTest extends TestCase {
private static final String UNENC_STRING = "\u2016";
// stress test for internal grow method.
@@ -106,14 +106,13 @@ public class TestZipEncodings extends Te
doSimpleEncodingTest("Cp1252",b);
}
- private static final void assertEquals(byte[] expected, ByteBuffer actual) {
+ private static void assertEquals(byte[] expected, ByteBuffer actual) {
assertEquals(expected.length, actual.limit());
- for (int i = 0; i < expected.length; ++i) {
-
+ for (byte anExpected : expected) {
byte a = actual.get();
- assertEquals(expected[i], a);
+ assertEquals(anExpected, a);
}
}