[GitHub] [incubator-zipkin-brave] adriancole commented on issue #609: Don't make spans for comments or SET statements in SQL

[GitBox <gi...@apache.org>]

adriancole commented on issue #609: Don't make spans for comments or SET statements in SQL
URL: https://github.com/apache/incubator-zipkin-brave/issues/609#issuecomment-492194138
 
 
   I was to make a similar comment to Jorg. we do want to consider what is
   required to do in impl vs composition. if this was the mysql driver.. with
   no means to configure except classpath or jdbc query params.. maybe we must
   define a pattern implementation at the brave abstraction.. or create a
   helper to do this.
   
   some things similar are web skip patterns. these can be implemented as
   decorating filters. a config project sleuth makes some pattern
   autoconfigurations.
   
   
   anyway this is the point to consider I think.. do we implement this or
   delegate to something else that can (ex decoration or another feature). I
   usually tend to the latter.
   
   cc @anuraaga
   
   
   
   On Tue, May 14, 2019, 12:16 AM Jorg Heymans <no...@github.com>
   wrote:
   
   > Note that brave uses P6spy for jdbc integration, it has a few
   > configuration options to exclude certain statements
   > https://p6spy.readthedocs.io/en/latest/configandusage.html#excludecategories
   > from being traced. The SET statement is not one of them AFAICT,
   > commit/rollback is.
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/incubator-zipkin-brave/issues/609?email_source=notifications&email_token=AAAPVVYZFBC5JXUDIRGPFZ3PVGH5DA5CNFSM4EQMPECKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVI2EOA#issuecomment-491889208>,
   > or mute the thread
   > <https://github.com/notifications/unsubscribe-auth/AAAPVV3HLKHC5ZAPQHYZYWDPVGH5DANCNFSM4EQMPECA>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
For additional commands, e-mail: dev-help@zipkin.apache.org