[GitHub] [airflow] RachitSharma2001 commented on a diff in pull request #28706: Update provide_bucket_name() decorator to handle new conn_type

[GitBox <gi...@apache.org>]

RachitSharma2001 commented on code in PR #28706:
URL: https://github.com/apache/airflow/pull/28706#discussion_r1062926098


##########
docs/apache-airflow-providers-amazon/connections/aws.rst:
##########
@@ -66,6 +66,8 @@ Extra (optional)
     Specify the extra parameters (as json dictionary) that can be used in AWS
     connection. All parameters are optional.
 
+    * ``s3_bucket_name``: Name of the S3 bucket that the hook should reference
+

Review Comment:
   That sounds good. I have updated airflow/providers/amazon/aws/hooks/s3.py to reflect the requested changes. From these changes, the user would be able to specify the S3 bucket name in the "extra" parameter when creating an aws connection, by entering the following json:
   ```
   {
     "service_config": {
       "s3": {
         "bucket_name": "[bucket name]"
       },
   }
   ```
   Let me know if this is what you had in mind, or if there are any other changes that are needed. 
   Also, I was not sure how to update the documentation to reflect this option of indicating S3 Bucket name. Would I just specify in `docs/apache-airflow-providers-amazon/connections/aws.rst` that the user should enter `"service_config.s3.bucket_name"` in `Extra's` in order to specify the bucket name, or is there a better way to indicate this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org