[GitHub] rabbah commented on a change in pull request #2319: Fix activation feed book-keeping in reactive pool (#2285)

[gi...@git.apache.org]

rabbah commented on a change in pull request #2319: Fix activation feed book-keeping in reactive pool (#2285)
URL: https://github.com/apache/incubator-openwhisk/pull/2319#discussion_r119879793
 
 

 ##########
 File path: core/invoker/src/main/scala/whisk/core/containerpool/ContainerProxy.scala
 ##########
 @@ -336,7 +362,8 @@ class ContainerProxy(
         // and do not block further execution of the future. They are completely
         // asynchronous.
         activation.andThen {
-            case Success(activation) => sendActiveAck(tid, activation)
+            // the activation future will always complete with Success
+            case Success(ack) => sendActiveAck(tid, ack)
 
 Review comment:
   I was tempted here to assert the invariant as:
   
   `case result => val Success(ack)` forcing an error should the contract be vioated
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services