You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2012/05/15 19:42:11 UTC

[jira] [Created] (HBASE-6000) Cleanup where we keep .proto files

stack created HBASE-6000:
----------------------------

             Summary: Cleanup where we keep .proto files
                 Key: HBASE-6000
                 URL: https://issues.apache.org/jira/browse/HBASE-6000
             Project: HBase
          Issue Type: Bug
            Reporter: stack


I see Andrew for his pb work over in rest has .protos files under src/main/resources.  We should unify where these files live.  The recently added .protos place them under src/main/protobuf  Its confusing.

The thift idl files are here under resources too.

Seems like we should move src/main/protobuf under src/resources to be consistent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6000) Cleanup where we keep .proto files

Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276371#comment-13276371 ] 

Enis Soztutar commented on HBASE-6000:
--------------------------------------

.proto files are source files, so +1 for putting them under src/main. 
bq. In my opinion it should not be necessary to have protoc installed to build HBase, just like it's not necessary to have the Thrift compiler available
+1 to that. I think we should make out-of-the-box compilation as easy as possible. If we commit the generated sources under src/, it should be ok. Also +1 on having "generated" in the package name. We have some maven targets depending on that convention.
                
> Cleanup where we keep .proto files
> ----------------------------------
>
>                 Key: HBASE-6000
>                 URL: https://issues.apache.org/jira/browse/HBASE-6000
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>
> I see Andrew for his pb work over in rest has .protos files under src/main/resources.  We should unify where these files live.  The recently added .protos place them under src/main/protobuf  Its confusing.
> The thift idl files are here under resources too.
> Seems like we should move src/main/protobuf under src/resources to be consistent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6000) Cleanup where we keep .proto files

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-6000:
-------------------------

    Attachment: 6000.txt

Retry.  Failure looks unrelated.
                
> Cleanup where we keep .proto files
> ----------------------------------
>
>                 Key: HBASE-6000
>                 URL: https://issues.apache.org/jira/browse/HBASE-6000
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.96.0
>            Reporter: stack
>            Assignee: stack
>         Attachments: 6000.txt, 6000.txt
>
>
> I see Andrew for his pb work over in rest has .protos files under src/main/resources.  We should unify where these files live.  The recently added .protos place them under src/main/protobuf  Its confusing.
> The thift idl files are here under resources too.
> Seems like we should move src/main/protobuf under src/resources to be consistent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6000) Cleanup where we keep .proto files

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-6000:
-------------------------

             Assignee: stack
    Affects Version/s: 0.96.0
         Release Note: Moves the REST proto files from src/main/resource to src/main/protobuf
               Status: Patch Available  (was: Open)
    
> Cleanup where we keep .proto files
> ----------------------------------
>
>                 Key: HBASE-6000
>                 URL: https://issues.apache.org/jira/browse/HBASE-6000
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.96.0
>            Reporter: stack
>            Assignee: stack
>         Attachments: 6000.txt
>
>
> I see Andrew for his pb work over in rest has .protos files under src/main/resources.  We should unify where these files live.  The recently added .protos place them under src/main/protobuf  Its confusing.
> The thift idl files are here under resources too.
> Seems like we should move src/main/protobuf under src/resources to be consistent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6000) Cleanup where we keep .proto files

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-6000:
-------------------------

      Tags: noob
    Labels: noob  (was: )
    
> Cleanup where we keep .proto files
> ----------------------------------
>
>                 Key: HBASE-6000
>                 URL: https://issues.apache.org/jira/browse/HBASE-6000
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.96.0
>            Reporter: stack
>            Assignee: stack
>              Labels: noob
>         Attachments: 6000.txt, 6000.txt
>
>
> I see Andrew for his pb work over in rest has .protos files under src/main/resources.  We should unify where these files live.  The recently added .protos place them under src/main/protobuf  Its confusing.
> The thift idl files are here under resources too.
> Seems like we should move src/main/protobuf under src/resources to be consistent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6000) Cleanup where we keep .proto files

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277554#comment-13277554 ] 

stack commented on HBASE-6000:
------------------------------

There is no requirement that you install protoc to build hbase; the generated classes are checked in as they are for thrift and avro.  Generated stuff is at src/main/java/org/apache/hadoop/hbase/protobuf/generated.
                
> Cleanup where we keep .proto files
> ----------------------------------
>
>                 Key: HBASE-6000
>                 URL: https://issues.apache.org/jira/browse/HBASE-6000
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>
> I see Andrew for his pb work over in rest has .protos files under src/main/resources.  We should unify where these files live.  The recently added .protos place them under src/main/protobuf  Its confusing.
> The thift idl files are here under resources too.
> Seems like we should move src/main/protobuf under src/resources to be consistent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6000) Cleanup where we keep .proto files

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-6000:
-------------------------

    Status: Patch Available  (was: Open)
    
> Cleanup where we keep .proto files
> ----------------------------------
>
>                 Key: HBASE-6000
>                 URL: https://issues.apache.org/jira/browse/HBASE-6000
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.96.0
>            Reporter: stack
>            Assignee: stack
>         Attachments: 6000.txt, 6000.txt
>
>
> I see Andrew for his pb work over in rest has .protos files under src/main/resources.  We should unify where these files live.  The recently added .protos place them under src/main/protobuf  Its confusing.
> The thift idl files are here under resources too.
> Seems like we should move src/main/protobuf under src/resources to be consistent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6000) Cleanup where we keep .proto files

Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276058#comment-13276058 ] 

Andrew Purtell commented on HBASE-6000:
---------------------------------------

I don't think we should consider protobuf IDL as source. In my opinion it should not be necessary to have protoc installed to build HBase, just like it's not necessary to have the Thrift compiler available. However, I will grant someone with an opposing view that now Hadoop core requires protoc on the path on the build host. (That is annoying because nothing keeps its version in sync with the protobuf jar that Hadoop is pulling down.)
                
> Cleanup where we keep .proto files
> ----------------------------------
>
>                 Key: HBASE-6000
>                 URL: https://issues.apache.org/jira/browse/HBASE-6000
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>
> I see Andrew for his pb work over in rest has .protos files under src/main/resources.  We should unify where these files live.  The recently added .protos place them under src/main/protobuf  Its confusing.
> The thift idl files are here under resources too.
> Seems like we should move src/main/protobuf under src/resources to be consistent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6000) Cleanup where we keep .proto files

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-6000:
-------------------------

    Status: Open  (was: Patch Available)
    
> Cleanup where we keep .proto files
> ----------------------------------
>
>                 Key: HBASE-6000
>                 URL: https://issues.apache.org/jira/browse/HBASE-6000
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.96.0
>            Reporter: stack
>            Assignee: stack
>         Attachments: 6000.txt
>
>
> I see Andrew for his pb work over in rest has .protos files under src/main/resources.  We should unify where these files live.  The recently added .protos place them under src/main/protobuf  Its confusing.
> The thift idl files are here under resources too.
> Seems like we should move src/main/protobuf under src/resources to be consistent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6000) Cleanup where we keep .proto files

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-6000:
-------------------------

    Attachment: 6000.txt

Here's a patch that moves it all under src/main/protobuf
                
> Cleanup where we keep .proto files
> ----------------------------------
>
>                 Key: HBASE-6000
>                 URL: https://issues.apache.org/jira/browse/HBASE-6000
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>         Attachments: 6000.txt
>
>
> I see Andrew for his pb work over in rest has .protos files under src/main/resources.  We should unify where these files live.  The recently added .protos place them under src/main/protobuf  Its confusing.
> The thift idl files are here under resources too.
> Seems like we should move src/main/protobuf under src/resources to be consistent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6000) Cleanup where we keep .proto files

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-6000:
-------------------------

    Status: Open  (was: Patch Available)

Patch no longer applicable.  Need new patch to move the stuff at src/main/resouces to src/main/protobuf:

{code}
./hbase-server/src/main/protobuf/Admin.proto
./hbase-server/src/main/protobuf/Client.proto
./hbase-server/src/main/protobuf/ClusterId.proto
./hbase-server/src/main/protobuf/ClusterStatus.proto
./hbase-server/src/main/protobuf/Filter.proto
./hbase-server/src/main/protobuf/FS.proto
./hbase-server/src/main/protobuf/hbase.proto
./hbase-server/src/main/protobuf/Master.proto
./hbase-server/src/main/protobuf/MasterAdmin.proto
./hbase-server/src/main/protobuf/MasterMonitor.proto
./hbase-server/src/main/protobuf/RegionServerStatus.proto
./hbase-server/src/main/protobuf/RPC.proto
./hbase-server/src/main/protobuf/ZooKeeper.proto
./hbase-server/src/main/resources/org/apache/hadoop/hbase/rest/protobuf/CellMessage.proto
./hbase-server/src/main/resources/org/apache/hadoop/hbase/rest/protobuf/CellSetMessage.proto
./hbase-server/src/main/resources/org/apache/hadoop/hbase/rest/protobuf/ColumnSchemaMessage.proto
./hbase-server/src/main/resources/org/apache/hadoop/hbase/rest/protobuf/ScannerMessage.proto
./hbase-server/src/main/resources/org/apache/hadoop/hbase/rest/protobuf/StorageClusterStatusMessage.proto
./hbase-server/src/main/resources/org/apache/hadoop/hbase/rest/protobuf/TableInfoMessage.proto
./hbase-server/src/main/resources/org/apache/hadoop/hbase/rest/protobuf/TableListMessage.proto
./hbase-server/src/main/resources/org/apache/hadoop/hbase/rest/protobuf/TableSchemaMessage.proto
./hbase-server/src/main/resources/org/apache/hadoop/hbase/rest/protobuf/VersionMessage.proto
./hbase-server/src/test/protobuf/test.proto
./hbase-server/src/test/protobuf/test_delayed_rpc.proto
./hbase-server/src/test/protobuf/test_rpc_service.proto
{code}
                
> Cleanup where we keep .proto files
> ----------------------------------
>
>                 Key: HBASE-6000
>                 URL: https://issues.apache.org/jira/browse/HBASE-6000
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.96.0
>            Reporter: stack
>            Assignee: stack
>              Labels: noob
>         Attachments: 6000.txt, 6000.txt
>
>
> I see Andrew for his pb work over in rest has .protos files under src/main/resources.  We should unify where these files live.  The recently added .protos place them under src/main/protobuf  Its confusing.
> The thift idl files are here under resources too.
> Seems like we should move src/main/protobuf under src/resources to be consistent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6000) Cleanup where we keep .proto files

Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13288798#comment-13288798 ] 

Gregory Chanan commented on HBASE-6000:
---------------------------------------

It looks like we have things under src/protobuf and src/main/protobuf, in addition to the definitions under resources.
                
> Cleanup where we keep .proto files
> ----------------------------------
>
>                 Key: HBASE-6000
>                 URL: https://issues.apache.org/jira/browse/HBASE-6000
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.96.0
>            Reporter: stack
>            Assignee: stack
>         Attachments: 6000.txt, 6000.txt
>
>
> I see Andrew for his pb work over in rest has .protos files under src/main/resources.  We should unify where these files live.  The recently added .protos place them under src/main/protobuf  Its confusing.
> The thift idl files are here under resources too.
> Seems like we should move src/main/protobuf under src/resources to be consistent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6000) Cleanup where we keep .proto files

Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276367#comment-13276367 ] 

Andrew Purtell commented on HBASE-6000:
---------------------------------------

bq. I don't think IDL belongs in "resources" because there's no reason for it to end up in the compiled jars.

Then I never "got" this maven convention.
                
> Cleanup where we keep .proto files
> ----------------------------------
>
>                 Key: HBASE-6000
>                 URL: https://issues.apache.org/jira/browse/HBASE-6000
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>
> I see Andrew for his pb work over in rest has .protos files under src/main/resources.  We should unify where these files live.  The recently added .protos place them under src/main/protobuf  Its confusing.
> The thift idl files are here under resources too.
> Seems like we should move src/main/protobuf under src/resources to be consistent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6000) Cleanup where we keep .proto files

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277591#comment-13277591 ] 

Hadoop QA commented on HBASE-6000:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12527779/6000.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 hadoop23.  The patch compiles against the hadoop 0.23.x profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 32 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.replication.TestMasterReplication

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1905//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1905//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1905//console

This message is automatically generated.
                
> Cleanup where we keep .proto files
> ----------------------------------
>
>                 Key: HBASE-6000
>                 URL: https://issues.apache.org/jira/browse/HBASE-6000
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.96.0
>            Reporter: stack
>            Assignee: stack
>         Attachments: 6000.txt
>
>
> I see Andrew for his pb work over in rest has .protos files under src/main/resources.  We should unify where these files live.  The recently added .protos place them under src/main/protobuf  Its confusing.
> The thift idl files are here under resources too.
> Seems like we should move src/main/protobuf under src/resources to be consistent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6000) Cleanup where we keep .proto files

Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276053#comment-13276053 ] 

Andrew Purtell commented on HBASE-6000:
---------------------------------------

+1

I propose this convention:

- IDL files should be under src/resources/, by package plus protobuf/, e.g. src/resources/org/apache/hadoop/hbase/rest/protobuf/

- Generated package names should go into the source tree with the suffix '.generated', e.g. src/main/java/org/apache/hadoop/hbase/rest/protobuf/generated

                
> Cleanup where we keep .proto files
> ----------------------------------
>
>                 Key: HBASE-6000
>                 URL: https://issues.apache.org/jira/browse/HBASE-6000
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>
> I see Andrew for his pb work over in rest has .protos files under src/main/resources.  We should unify where these files live.  The recently added .protos place them under src/main/protobuf  Its confusing.
> The thift idl files are here under resources too.
> Seems like we should move src/main/protobuf under src/resources to be consistent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6000) Cleanup where we keep .proto files

Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276370#comment-13276370 ] 

Andrew Purtell commented on HBASE-6000:
---------------------------------------

In which case, move the IDL to src/ to be consistent, I'm sorry I said anything.
                
> Cleanup where we keep .proto files
> ----------------------------------
>
>                 Key: HBASE-6000
>                 URL: https://issues.apache.org/jira/browse/HBASE-6000
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>
> I see Andrew for his pb work over in rest has .protos files under src/main/resources.  We should unify where these files live.  The recently added .protos place them under src/main/protobuf  Its confusing.
> The thift idl files are here under resources too.
> Seems like we should move src/main/protobuf under src/resources to be consistent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6000) Cleanup where we keep .proto files

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276366#comment-13276366 ] 

Todd Lipcon commented on HBASE-6000:
------------------------------------

I don't think IDL belongs in "resources" because there's no reason for it to end up in the compiled jars. resources are for things that need to be available to the classloader at runtime.
                
> Cleanup where we keep .proto files
> ----------------------------------
>
>                 Key: HBASE-6000
>                 URL: https://issues.apache.org/jira/browse/HBASE-6000
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>
> I see Andrew for his pb work over in rest has .protos files under src/main/resources.  We should unify where these files live.  The recently added .protos place them under src/main/protobuf  Its confusing.
> The thift idl files are here under resources too.
> Seems like we should move src/main/protobuf under src/resources to be consistent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira