You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Min Chen <mi...@citrix.com> on 2012/12/11 00:06:39 UTC

Review Request: Add missing InstanceGroupJoinDao to component library

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8450/
-----------------------------------------------------------

Review request for cloudstack and Rohit Yadav.


Description
-------

Add missing InstanceGroupJoinDao to component library to MS start error.


This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-527.


Diffs
-----

  server/src/com/cloud/configuration/DefaultComponentLibrary.java b3ef40a 

Diff: https://reviews.apache.org/r/8450/diff/


Testing
-------


Thanks,

Min Chen


Re: Review Request: Add missing InstanceGroupJoinDao to component library

Posted by Rohit Yadav <ro...@citrix.com>.

> On Dec. 10, 2012, 11:31 p.m., Rohit Yadav wrote:
> > Ship It!

Thanks Min, applied in api_refactoring;

commit 1cf8b86ce5734ebdfff39c141a6697607d2c09b6
Author: Min Chen <mi...@citrix.com>
Date:   Mon Dec 10 15:10:21 2012 -0800

    api: Load InstanceGroupJoinDao to component Library


- Rohit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8450/#review14273
-----------------------------------------------------------


On Dec. 10, 2012, 11:06 p.m., Min Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8450/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2012, 11:06 p.m.)
> 
> 
> Review request for cloudstack and Rohit Yadav.
> 
> 
> Description
> -------
> 
> Add missing InstanceGroupJoinDao to component library to MS start error.
> 
> 
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-527.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/configuration/DefaultComponentLibrary.java b3ef40a 
> 
> Diff: https://reviews.apache.org/r/8450/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Min Chen
> 
>


Re: Review Request: Add missing InstanceGroupJoinDao to component library

Posted by Rohit Yadav <ro...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8450/#review14273
-----------------------------------------------------------

Ship it!


Ship It!

- Rohit Yadav


On Dec. 10, 2012, 11:06 p.m., Min Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8450/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2012, 11:06 p.m.)
> 
> 
> Review request for cloudstack and Rohit Yadav.
> 
> 
> Description
> -------
> 
> Add missing InstanceGroupJoinDao to component library to MS start error.
> 
> 
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-527.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/configuration/DefaultComponentLibrary.java b3ef40a 
> 
> Diff: https://reviews.apache.org/r/8450/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Min Chen
> 
>