You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by jongyoul <gi...@git.apache.org> on 2016/10/05 06:48:29 UTC
[GitHub] zeppelin pull request #1487: [WIP] [ZEPPELIN-1520] Test with the local mode ...
GitHub user jongyoul opened a pull request:
https://github.com/apache/zeppelin/pull/1487
[WIP] [ZEPPELIN-1520] Test with the local mode of Apache Spark
### What is this PR for?
Simplify travis test to reduce usage of resources
### What type of PR is it?
[Improvement]
### Todos
* [] - Remove start-up/stop SparkCluster
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1520
### How should this be tested?
Travis will pass without any error
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jongyoul/zeppelin ZEPPELIN-1520
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1487.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1487
----
commit 2aac444a0681a4402ec84dc9b8ac9832395230e0
Author: Jongyoul Lee <jo...@gmail.com>
Date: 2016-10-05T06:46:07Z
Remove scripts of start/stop SparkCluster
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1487: [ZEPPELIN-1520] Change test environment to use the loc...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1487
Should we provide the option to allow user to use other modes ? Otherwise it seems the scripts under folder `test` can be removed as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1487: [ZEPPELIN-1520] Change test environment to use the loc...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1487
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1487: [ZEPPELIN-1520] Test with the local mode of Apache Spa...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1487
Ready to review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1487: [ZEPPELIN-1520] Change test environment to use the loc...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1487
@zjffdu I've missed remove some scripts in `testing`. I'll fix it. Concerning the modes, in an early stage of Spark, there're some different behaviours of different modes, thus we need to test Zeppelin with Spark in a standalone cluster, but for now, Spark become stable and if different modes have different behaviours, it's definitely Spark's problem and Spark should fix it. Thus I don't think we need to test Zeppelin a cluster mode. Furthermore, personally, I don't know what benefit we have in a different test environment between local and CI. In case of Python, I've experienced that some tests only failed in CI, not in a local with different setting between them. I think we should try to keep both environments equally.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1487: [ZEPPELIN-1520] Change test environment to use ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1487
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1487: [ZEPPELIN-1520] Change test environment to use the loc...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1487
And think again, how about making the local mode as the default mode for local dev (non-travis enviroment), and use standalone mode for travis ? Because local mode success doesn't mean other modes also succeed, there are subtle differences between them. For now, user can set enviroment variable `SPARK_MASTER` to control which mode to use. We can just export `SPARK_MASTER` to local for local dev. What do you think ? @jongyoul @felixcheung
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1487: [ZEPPELIN-1520] Change test environment to use the loc...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1487
Merging if there's no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---