You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/07/16 16:25:40 UTC

[GitHub] [commons-text] darkma773r commented on a diff in pull request #341: Interpolation Defaults

darkma773r commented on code in PR #341:
URL: https://github.com/apache/commons-text/pull/341#discussion_r922697105


##########
src/main/java/org/apache/commons/text/lookup/DefaultStringLookup.java:
##########
@@ -117,14 +115,6 @@ public enum DefaultStringLookup {
      */
     XML(StringLookupFactory.KEY_XML, StringLookupFactory.INSTANCE.xmlStringLookup());
 
-    /**

Review Comment:
   I don't believe it is appropriate to include a `main` method here. If the values are not easily accessible via the documentation, then that indicates a failure in the documentation and not a need for a one-off tool.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org