You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@datasketches.apache.org by "ariesdevil (via GitHub)" <gi...@apache.org> on 2026/07/10 15:33:18 UTC
[PR] feat: add tuple theta implementation and tests based on raw hashtable (datasketches-rust)
ariesdevil opened a new pull request, #147:
URL: https://github.com/apache/datasketches-rust/pull/147
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] feat: add tuple theta implementation and tests based on raw hashtable (datasketches-rust)
Posted by "ZENOTME (via GitHub)" <gi...@apache.org>.
ZENOTME commented on PR #147:
URL: https://github.com/apache/datasketches-rust/pull/147#issuecomment-5013781519
Thanks @ariesdevil ! This PR is a littble big to review, could you help to split it into independent part to make it easier to review:
1. Tuple sketch
2. Union operation
3. Intersection operation
4. a not b operation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] feat: add tuple theta implementation and tests based on raw hashtable (datasketches-rust)
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #147:
URL: https://github.com/apache/datasketches-rust/pull/147#discussion_r3608068362
##########
datasketches/src/theta/mod.rs:
##########
@@ -46,7 +46,17 @@ mod raw_hash_table;
mod serialization;
mod sketch;
+// These helpers are re-exported only for Tuple hash-table tests; production code uses the shared
+// raw table directly.
+#[cfg(all(feature = "tuple", test))]
+pub(crate) use self::hash_table::starting_sub_multiple;
+#[cfg(all(feature = "tuple", test))]
+pub(crate) use self::hash_table::starting_theta_from_sampling_probability;
pub use self::intersection::ThetaIntersection;
+#[cfg(feature = "tuple")]
+pub(crate) use self::raw_hash_table::RawHashTable;
+#[cfg(feature = "tuple")]
+pub(crate) use self::raw_hash_table::RawHashTableEntry;
Review Comment:
#145 moves these symbols to `thetacommon`, we'd avoid these `pub(crate) use` now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] feat: add tuple theta implementation and tests based on raw hashtable (datasketches-rust)
Posted by "ariesdevil (via GitHub)" <gi...@apache.org>.
ariesdevil closed pull request #147: feat: add tuple theta implementation and tests based on raw hashtable
URL: https://github.com/apache/datasketches-rust/pull/147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] feat: add tuple theta implementation and tests based on raw hashtable (datasketches-rust)
Posted by "ariesdevil (via GitHub)" <gi...@apache.org>.
ariesdevil commented on PR #147:
URL: https://github.com/apache/datasketches-rust/pull/147#issuecomment-5014163146
@ZENOTME Done #156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] feat: add tuple theta implementation and tests based on raw hashtable (datasketches-rust)
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #147:
URL: https://github.com/apache/datasketches-rust/pull/147#discussion_r3608069081
##########
datasketches/Cargo.toml:
##########
@@ -45,6 +45,7 @@ frequencies = []
hll = []
tdigest = []
theta = []
+tuple = ["theta"]
Review Comment:
We can enable `thetacommon` on either `theta` or `tuple`, and thus need not this dep.
```rust
#[cfg(any(feature = "theta", feature = "tuple"))]
pub mod thetacommon;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] feat: add tuple theta implementation and tests based on raw hashtable (datasketches-rust)
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #147:
URL: https://github.com/apache/datasketches-rust/pull/147#discussion_r3608069081
##########
datasketches/Cargo.toml:
##########
@@ -45,6 +45,7 @@ frequencies = []
hll = []
tdigest = []
theta = []
+tuple = ["theta"]
Review Comment:
We can enable `thetacommon` on either `theta` or `tuple`, and thus need not this dep.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org