You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by qinglin xia <xi...@gmail.com> on 2017/06/14 09:21:26 UTC
Review Request 60066: ATLAS-1865 - Cannot create trait/term in Chinese
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60066/
-----------------------------------------------------------
Review request for atlas.
Bugs: ATLAS-1865
https://issues.apache.org/jira/browse/ATLAS-1865
Repository: atlas
Description
-------
Fix ATLAS-1865 (https://issues.apache.org/jira/browse/ATLAS-1865), Atlas 0.9 can now create trait/term in Chinese
Diffs
-----
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java 89445048
Diff: https://reviews.apache.org/r/60066/diff/1/
Testing
-------
Create Term in Chinese
Create Trait in Chinese
Thanks,
qinglin xia
Re: Review Request 60066: ATLAS-1865 - Cannot create trait/term in
Chinese
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60066/#review178033
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java
Line 46 (original), 46 (patched)
<https://reviews.apache.org/r/60066/#comment251805>
TRAIT_NAME_REGEX may grow in size each time we decide to add a new language. We need to find the locale of the string and validate it against supported locales for Atlas.
- Sarath Subramanian
On June 14, 2017, 3:18 a.m., qinglin xia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60066/
> -----------------------------------------------------------
>
> (Updated June 14, 2017, 3:18 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1865
> https://issues.apache.org/jira/browse/ATLAS-1865
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Fix ATLAS-1865 (https://issues.apache.org/jira/browse/ATLAS-1865), Atlas 0.9 can not create trait/term in Chinese
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java 89445048
>
>
> Diff: https://reviews.apache.org/r/60066/diff/2/
>
>
> Testing
> -------
>
> Create Term in Chinese
> Create Trait in Chinese
>
>
> Thanks,
>
> qinglin xia
>
>
Re: Review Request 60066: ATLAS-1865 - Cannot create trait/term in
Chinese
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60066/#review177912
-----------------------------------------------------------
Can you add test cases for this ?
- Apoorv Naik
On June 14, 2017, 10:18 a.m., qinglin xia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60066/
> -----------------------------------------------------------
>
> (Updated June 14, 2017, 10:18 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1865
> https://issues.apache.org/jira/browse/ATLAS-1865
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Fix ATLAS-1865 (https://issues.apache.org/jira/browse/ATLAS-1865), Atlas 0.9 can not create trait/term in Chinese
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java 89445048
>
>
> Diff: https://reviews.apache.org/r/60066/diff/2/
>
>
> Testing
> -------
>
> Create Term in Chinese
> Create Trait in Chinese
>
>
> Thanks,
>
> qinglin xia
>
>
Re: Review Request 60066: ATLAS-1865 - Cannot create trait/term in
Chinese
Posted by qinglin xia <xi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60066/
-----------------------------------------------------------
(Updated June 14, 2017, 10:18 a.m.)
Review request for atlas.
Bugs: ATLAS-1865
https://issues.apache.org/jira/browse/ATLAS-1865
Repository: atlas
Description
-------
Fix ATLAS-1865 (https://issues.apache.org/jira/browse/ATLAS-1865), Atlas 0.9 can not create trait/term in Chinese
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java 89445048
Diff: https://reviews.apache.org/r/60066/diff/2/
Changes: https://reviews.apache.org/r/60066/diff/1-2/
Testing
-------
Create Term in Chinese
Create Trait in Chinese
Thanks,
qinglin xia
Re: Review Request 60066: ATLAS-1865 - Cannot create trait/term in
Chinese
Posted by qinglin xia <xi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60066/
-----------------------------------------------------------
(Updated June 14, 2017, 9:22 a.m.)
Review request for atlas.
Bugs: ATLAS-1865
https://issues.apache.org/jira/browse/ATLAS-1865
Repository: atlas
Description (updated)
-------
Fix ATLAS-1865 (https://issues.apache.org/jira/browse/ATLAS-1865), Atlas 0.9 can not create trait/term in Chinese
Diffs
-----
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java 89445048
Diff: https://reviews.apache.org/r/60066/diff/1/
Testing
-------
Create Term in Chinese
Create Trait in Chinese
Thanks,
qinglin xia