You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2018/01/25 06:38:12 UTC
[kudu-CR] client: fix UBSAN error in failover calculation
Hello Dan Burkert,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/9132
to review the following change.
Change subject: client: fix UBSAN error in failover calculation
......................................................................
client: fix UBSAN error in failover calculation
A misplaced typecast caused the following:
/data/somelongdirectorytoavoidrpathissues/src/kudu/src/kudu/client/scanner-internal.cc:433:72:
runtime error: unsigned integer overflow: 4 - 5 cannot be represented in type 'unsigned long'
This patch simply rearranges the expression a bit to avoid underflow
possibilities.
Change-Id: Icd137f86443bc4af59f8a4290a45151afda6c090
---
M src/kudu/client/scanner-internal.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/9132/1
--
To view, visit http://gerrit.cloudera.org:8080/9132
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icd137f86443bc4af59f8a4290a45151afda6c090
Gerrit-Change-Number: 9132
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
[kudu-CR] client: fix UBSAN error in failover calculation
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9132 )
Change subject: client: fix UBSAN error in failover calculation
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9132
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd137f86443bc4af59f8a4290a45151afda6c090
Gerrit-Change-Number: 9132
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 29 Jan 2018 19:32:01 +0000
Gerrit-HasComments: No
[kudu-CR] client: fix UBSAN error in failover calculation
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9132 )
Change subject: client: fix UBSAN error in failover calculation
......................................................................
client: fix UBSAN error in failover calculation
A misplaced typecast caused the following:
/data/somelongdirectorytoavoidrpathissues/src/kudu/src/kudu/client/scanner-internal.cc:433:72:
runtime error: unsigned integer overflow: 4 - 5 cannot be represented in type 'unsigned long'
This patch simply rearranges the expression a bit to avoid underflow
possibilities.
Change-Id: Icd137f86443bc4af59f8a4290a45151afda6c090
Reviewed-on: http://gerrit.cloudera.org:8080/9132
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Dan Burkert <da...@cloudera.com>
---
M src/kudu/client/scanner-internal.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
Dan Burkert: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/9132
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icd137f86443bc4af59f8a4290a45151afda6c090
Gerrit-Change-Number: 9132
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] client: fix UBSAN error in failover calculation
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9132 )
Change subject: client: fix UBSAN error in failover calculation
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9132
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd137f86443bc4af59f8a4290a45151afda6c090
Gerrit-Change-Number: 9132
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 25 Jan 2018 16:59:12 +0000
Gerrit-HasComments: No